tslint-no-circular-imports - npm Package Compare versions

Comparing version 0.6.1 to 0.6.2

noCircularImportsRule.js

@@ -8,3 +8,3 @@ "use strict";
         return extendStatics(d, b);
-    }
+    };
     return function (d, b) {
@@ -152,2 +152,5 @@ extendStatics(d, b);
         }
+        if (!ts.isSourceFile(node.parent)) {
+            return;
+        }
         var fileName = node.parent.fileName;
@@ -173,3 +176,3 @@ if (!ts.isStringLiteral(node.moduleSpecifier)) {
         if (iterationDepth === void 0) { iterationDepth = 0; }
-        var e_2, _a;
+        var e_2, _a, e_3, _b;
         var moduleImport = imports.get(moduleName);
@@ -184,7 +187,18 @@ if (!moduleImport)
         try {
-            for (var _b = __values(Array.from(moduleImport.keys())), _c = _b.next(); !_c.done; _c = _b.next()) {
-                var imp = _c.value;
+            for (var _c = __values(Array.from(moduleImport.keys())), _d = _c.next(); !_d.done; _d = _c.next()) {
+                var imp = _d.value;
                 var c = getAllCycles(imp, accumulator.concat(moduleName), iterationDepth + 1);
-                if (c.length)
-                    all.push.apply(all, __spread(c));
+                try {
+                    for (var c_1 = __values(c), c_1_1 = c_1.next(); !c_1_1.done; c_1_1 = c_1.next()) {
+                        var cycle = c_1_1.value;
+                        all.push(cycle);
+                    }
+                }
+                catch (e_3_1) { e_3 = { error: e_3_1 }; }
+                finally {
+                    try {
+                        if (c_1_1 && !c_1_1.done && (_b = c_1.return)) _b.call(c_1);
+                    }
+                    finally { if (e_3) throw e_3.error; }
+                }
             }
@@ -195,3 +209,3 @@ }
             try {
-                if (_c && !_c.done && (_a = _b.return)) _a.call(_b);
+                if (_d && !_d.done && (_a = _c.return)) _a.call(_c);
             }
@@ -198,0 +212,0 @@ finally { if (e_2) throw e_2.error; }

noCircularImportsRule.ts

@@ -118,2 +118,5 @@ import { relative, sep } from 'path'
     }
+    if (!ts.isSourceFile(node.parent)) {
+      return
+    }
     const fileName = node.parent.fileName
@@ -154,4 +157,4 @@
 
-      if (c.length)
-        all.push(...c)
+      for (const cycle of c)
+        all.push(cycle)
     }
@@ -158,0 +161,0 @@

package.json

 {
   "name": "tslint-no-circular-imports",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "TSLint plugin to detect and warn about circular imports",
@@ -28,6 +28,6 @@ "main": "tslint-no-circular-imports.json",
   "devDependencies": {
-    "@types/node": "^10.7.1",
-    "tslint": "^5.11.0",
-    "typescript": "^3.0.1"
+    "@types/node": "^11.10.4",
+    "tslint": "^5.13.1",
+    "typescript": "^3.3.3333"
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

35187

increased by2.17%

Lines of code

653

increased by2.67%

No dependency changes