victory-chart - npm Package Compare versions

Comparing version 21.1.1 to 21.1.2

CHANGELOG.md

 # VictoryChart Changelog
 
+## 21.1.2 (2017-06-15)
+
+[480](https://github.com/FormidableLabs/victory-chart/pull/480) Refactors `VictoryPolarAxis` to support native version
+
 ## 21.1.1 (2017-06-13)
@@ -4,0 +8,0 @@

lib/components/victory-polar-axis/victory-polar-axis.js

@@ -21,3 +21,3 @@ Object.defineProperty(exports,"__esModule",{value:true});var _partialRight2=require("lodash/partialRight");var _partialRight3=_interopRequireDefault(_partialRight2);var _assign2=require("lodash/assign");var _assign3=_interopRequireDefault(_assign2);var _jsxFileName="src/components/victory-polar-axis/victory-polar-axis.js";var _extends=Object.assign||function(target){for(var i=1;i<arguments.length;i++){var source=arguments[i];for(var key in source){if(Object.prototype.hasOwnProperty.call(source,key)){target[key]=source[key];}}}return target;};var _createClass=function(){function defineProperties(target,props){for(var i=0;i<props.length;i++){var descriptor=props[i];descriptor.enumerable=descriptor.enumerable||false;descriptor.configurable=true;if("value"in descriptor)descriptor.writable=true;Object.defineProperty(target,descriptor.key,descriptor);}}return function(Constructor,protoProps,staticProps){if(protoProps)defineProperties(Constructor.prototype,protoProps);if(staticProps)defineProperties(Constructor,staticProps);return Constructor;};}();var _react=require("react");var _react2=_interopRequireDefault(_react);
 
-VictoryPolarAxis=function(_React$Component){_inherits(VictoryPolarAxis,_React$Component);function VictoryPolarAxis(){_classCallCheck(this,VictoryPolarAxis);return _possibleConstructorReturn(this,(VictoryPolarAxis.__proto__||Object.getPrototypeOf(VictoryPolarAxis)).apply(this,arguments));}_createClass(VictoryPolarAxis,[{key:"getTransform",value:function getTransform(
+VictoryPolarAxis=function(_React$Component){_inherits(VictoryPolarAxis,_React$Component);function VictoryPolarAxis(){_classCallCheck(this,VictoryPolarAxis);return _possibleConstructorReturn(this,(VictoryPolarAxis.__proto__||Object.getPrototypeOf(VictoryPolarAxis)).apply(this,arguments));}_createClass(VictoryPolarAxis,[{key:"renderAxisLine",value:function renderAxisLine(
 
@@ -92,9 +92,2 @@
 
-props){
-var groupComponentProps=props.groupComponent.props||{};
-var origin=_victoryCore.Helpers.getPolarOrigin(props);
-var transform="translate("+origin.x+", "+origin.y+")";
-return groupComponentProps.transform||transform;
-}},{key:"renderAxisLine",value:function renderAxisLine(
-
 props){var
@@ -117,3 +110,3 @@ dependentAxis=props.dependentAxis;
 props){var _this2=this;var
-tickComponent=props.tickComponent,tickLabelComponent=props.tickLabelComponent,groupComponent=props.groupComponent;
+tickComponent=props.tickComponent,tickLabelComponent=props.tickLabelComponent;
 var axisType=props.dependentAxis?"radial":"angular";
@@ -146,3 +139,12 @@ var gridComponent=axisType==="radial"?props.circularGridComponent:props.gridComponent;
 
-return _react2.default.cloneElement(groupComponent,{transform:this.getTransform(props)},children);
+return this.renderGroup(props,children);
+}},{key:"renderGroup",value:function renderGroup(
+
+
+props,children){var
+groupComponent=props.groupComponent;
+var groupComponentProps=groupComponent.props||{};
+var origin=_victoryCore.Helpers.getPolarOrigin(props);
+var transform=groupComponentProps.transform||"translate("+origin.x+", "+origin.y+")";
+return _react2.default.cloneElement(groupComponent,{transform:transform},children);
 }},{key:"shouldAnimate",value:function shouldAnimate()
@@ -149,0 +151,0 @@

package.json

 {
   "name": "victory-chart",
-  "version": "21.1.1",
+  "version": "21.1.2",
   "description": "Chart Component for Victory",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/components/victory-polar-axis/victory-polar-axis.js

@@ -91,9 +91,2 @@ import React from "react";
 
-  getTransform(props) {
-    const groupComponentProps = props.groupComponent.props || {};
-    const origin = Helpers.getPolarOrigin(props);
-    const transform = `translate(${origin.x}, ${origin.y})`;
-    return groupComponentProps.transform || transform;
-  }
-
   renderAxisLine(props) {
@@ -116,3 +109,3 @@ const { dependentAxis } = props;
   renderAxis(props) {
-    const { tickComponent, tickLabelComponent, groupComponent } = props;
+    const { tickComponent, tickLabelComponent } = props;
     const axisType = props.dependentAxis ? "radial" : "angular";
@@ -145,5 +138,14 @@ const gridComponent = axisType === "radial" ? props.circularGridComponent : props.gridComponent;
     ];
-    return React.cloneElement(groupComponent, { transform: this.getTransform(props) }, children);
+    return this.renderGroup(props, children);
   }
 
+  // Overridden in victory-native
+  renderGroup(props, children) {
+    const { groupComponent } = props;
+    const groupComponentProps = groupComponent.props || {};
+    const origin = Helpers.getPolarOrigin(props);
+    const transform = groupComponentProps.transform || `translate(${origin.x}, ${origin.y})`;
+    return React.cloneElement(groupComponent, { transform }, children);
+  }
+
   shouldAnimate() {
@@ -150,0 +152,0 @@ return !!this.props.animate;

No alert changes

Improved metrics

Total package byte prevSize

1927420

0.02%

Lines of code

34337

0.03%

No dependency changes