webpack-node-externals - npm Package Compare versions

Comparing version 1.2.0 to 1.3.0

index.js

@@ -42,2 +42,10 @@ var fs = require("fs");
 
+function getModuleName(request, modulesDir) {
+    var req = request;
+    // in case absolute, strip all parts before */modulesDir/
+    req = req.replace(/^\/.*?node_modules\//, '');
+    // return the module name
+    return req.split('/')[0];
+}
+
 module.exports = function nodeExternals(options) {
@@ -57,8 +65,8 @@ options = options || {};
     // create the node modules list
-    var nodeModules = modulesFromFile ? readFromPackageJson(): readDir(modulesDir).filter(isNotBinary);
+    var nodeModules = modulesFromFile ? readFromPackageJson() : readDir(modulesDir).filter(isNotBinary);
 
     // return an externals function
     return function(context, request, callback) {
-        var pathStart = request.split('/')[0];
-        if (contains(nodeModules, pathStart) && !containsPattern(whitelist, request)) {
+        var moduleName = getModuleName(request);
+        if (contains(nodeModules, moduleName) && !containsPattern(whitelist, request)) {
             // mark this module as external
@@ -65,0 +73,0 @@ // https://webpack.github.io/docs/configuration.html#externals

package.json

 {
   "name": "webpack-node-externals",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "Easily exclude node_modules in Webpack bundle",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

7989

increased by2.77%

Lines of code

66

increased by11.86%

No dependency changes