xmlhttprequest - npm Package Compare versions

Comparing version 1.4.0 to 1.4.2

lib/XMLHttpRequest.js

@@ -36,3 +36,3 @@ /**
   var defaultHeaders = {
-    "User-Agent": "node.js",
+    "User-Agent": "node-XMLHttpRequest",
     "Accept": "*/*",
@@ -43,3 +43,5 @@ };
 
-  // These headers are not user setable
+  // These headers are not user setable.
+  // The following are allowed but banned in the spec:
+  // * user-agent
   var forbiddenRequestHeaders = [
@@ -65,3 +67,2 @@ "accept-charset",
     "upgrade",
-    "user-agent",
     "via"
@@ -180,3 +181,4 @@ ];
     if (!isAllowedHttpHeader(header)) {
-      throw "SYNTAX_ERR: This header is not allowed";
+      console.warn('Refused to set unsafe header "' + header + '"');
+      return;
     }
@@ -318,2 +320,5 @@ if (sendFlag) {
     headers["Host"] = host;
+    if (!((ssl && port === 443) || port === 80)) {
+      headers["Host"] += ':' + url.port;
+    }
 
@@ -330,3 +335,3 @@ // Set Basic Auth if necessary
     // Set content length header
-    if (settings.method == "GET" || settings.method == "HEAD") {
+    if (settings.method === "GET" || settings.method === "HEAD") {
       data = null;
@@ -339,2 +344,6 @@ } else if (data) {
       }
+    } else if (settings.method === "POST") {
+      // For a post with no data set Content-Length: 0.
+      // This is required by buggy servers that don't meet the specs.
+      headers["Content-Length"] = 0;
     }
@@ -341,0 +350,0 @@

package.json

 {
   "name": "xmlhttprequest"
 , "description": "XMLHttpRequest for Node"
-, "version": "1.4.0"
+, "version": "1.4.2"
 , "author": {
@@ -6,0 +6,0 @@ "name": "Dan DeFelippi"

tests/test-headers.js

@@ -52,3 +52,6 @@ var sys = require("util")
   xhr.open("GET", "http://localhost:8000/");
+  // Valid header
   xhr.setRequestHeader("X-Test", "Foobar");
+  // Invalid header
+  xhr.setRequestHeader("Content-Length", 0);
   // Test getRequestHeader
@@ -55,0 +58,0 @@ assert.equal("Foobar", xhr.getRequestHeader("X-Test"));

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25377

increased by1.96%

Lines of code

733

increased by1.66%

Number of medium supply chain risk alerts

6

decreased by-14.29%

No dependency changes