@0xproject/connect - npm Package Compare versions

Comparing version 0.6.3 to 0.6.4

CHANGELOG.md

 # CHANGELOG
 
+## v0.6.4 - _March 18, 2018_
+
+    * Consolidate `Order`, `SignedOrder`, and `ECSignature` into the `@0xproject/types` package (#456)
+
 ## v0.6.2 - _February 16, 2018_
@@ -4,0 +8,0 @@

lib/src/http_client.d.ts

@@ -0,3 +1,4 @@
+import { SignedOrder } from '@0xproject/types';
 import 'isomorphic-fetch';
-import { Client, FeesRequest, FeesResponse, OrderbookRequest, OrderbookResponse, OrdersRequestOpts, PagedRequestOpts, SignedOrder, TokenPairsItem, TokenPairsRequestOpts } from './types';
+import { Client, FeesRequest, FeesResponse, OrderbookRequest, OrderbookResponse, OrdersRequestOpts, PagedRequestOpts, TokenPairsItem, TokenPairsRequestOpts } from './types';
 /**
@@ -4,0 +5,0 @@ * This class includes all the functionality related to interacting with a set of HTTP endpoints

lib/src/index.d.ts

 export { HttpClient } from './http_client';
 export { WebSocketOrderbookChannel } from './ws_orderbook_channel';
-export { Client, ECSignature, FeesRequest, FeesResponse, Order, OrderbookChannel, OrderbookChannelHandler, OrderbookChannelSubscriptionOpts, OrderbookRequest, OrderbookResponse, OrdersRequestOpts, PagedRequestOpts, SignedOrder, TokenPairsItem, TokenPairsRequestOpts, TokenTradeInfo, WebSocketOrderbookChannelConfig } from './types';
+export { Client, FeesRequest, FeesResponse, OrderbookChannel, OrderbookChannelHandler, OrderbookChannelSubscriptionOpts, OrderbookRequest, OrderbookResponse, OrdersRequestOpts, PagedRequestOpts, TokenPairsItem, TokenPairsRequestOpts, TokenTradeInfo, WebSocketOrderbookChannelConfig } from './types';
+export { ECSignature, Order, SignedOrder } from '@0xproject/types';

lib/src/types.d.ts

@@ -0,27 +1,3 @@
+import { SignedOrder } from '@0xproject/types';
 import { BigNumber } from '@0xproject/utils';
-export interface Order {
-    maker: string;
-    taker: string;
-    makerFee: BigNumber;
-    takerFee: BigNumber;
-    makerTokenAmount: BigNumber;
-    takerTokenAmount: BigNumber;
-    makerTokenAddress: string;
-    takerTokenAddress: string;
-    salt: BigNumber;
-    exchangeContractAddress: string;
-    feeRecipient: string;
-    expirationUnixTimestampSec: BigNumber;
-}
-export interface SignedOrder extends Order {
-    ecSignature: ECSignature;
-}
-/**
- * Elliptic Curve signature
- */
-export interface ECSignature {
-    v: number;
-    r: string;
-    s: string;
-}
 export interface Client {
@@ -28,0 +4,0 @@ getTokenPairsAsync: (requestOpts?: TokenPairsRequestOpts & PagedRequestOpts) => Promise<TokenPairsItem[]>;

lib/src/utils/relayer_response_json_parsers.d.ts

@@ -1,2 +0,3 @@
-import { FeesResponse, OrderbookResponse, SignedOrder, TokenPairsItem } from '../types';
+import { SignedOrder } from '@0xproject/types';
+import { FeesResponse, OrderbookResponse, TokenPairsItem } from '../types';
 export declare const relayerResponseJsonParsers: {
@@ -3,0 +4,0 @@ parseTokenPairsJson(json: any): TokenPairsItem[];

package.json

 {
     "name": "@0xproject/connect",
-    "version": "0.6.3",
+    "version": "0.6.4",
     "description": "A javascript library for interacting with the standard relayer api",
@@ -16,4 +16,4 @@ "keywords": [
         "build:watch": "tsc -w",
-        "build": "tsc",
-        "clean": "shx rm -rf _bundles lib test_temp",
+        "build": "tsc && copyfiles -u 3 './lib/src/monorepo_scripts/**/*' ./scripts",
+        "clean": "shx rm -rf _bundles lib test_temp scripts",
         "docs:json": "typedoc --excludePrivate --excludeExternals --target ES5 --json $JSON_FILE_PATH $PROJECT_FILES",
@@ -25,4 +25,18 @@ "upload_docs_json": "aws s3 cp generated_docs/index.json $S3_URL --profile 0xproject --grants read=uri=http://acs.amazonaws.com/groups/global/AllUsers --content-type application/json",
         "test": "run-s clean build copy_test_fixtures run_mocha",
-        "test:circleci": "yarn test"
+        "test:coverage": "nyc npm run test --all && yarn coverage:report:lcov",
+        "coverage:report:lcov": "nyc report --reporter=text-lcov > coverage/lcov.info",
+        "test:circleci": "yarn test:coverage"
     },
+    "config": {
+        "postpublish": {
+            "assets": [
+                "_bundles/index.js",
+                "_bundles/index.min.js"
+            ],
+            "docPublishConfigs": {
+                "s3BucketPath": "s3://connect-docs-jsons/",
+                "s3StagingBucketPath": "s3://staging-connect-docs-jsons/"
+            }
+        }
+    },
     "repository": {
@@ -42,5 +56,6 @@ "type": "git",
     "dependencies": {
-        "@0xproject/assert": "^0.2.0",
-        "@0xproject/json-schemas": "^0.7.14",
-        "@0xproject/utils": "^0.4.1",
+        "@0xproject/assert": "^0.2.1",
+        "@0xproject/json-schemas": "^0.7.15",
+        "@0xproject/types": "^0.4.0",
+        "@0xproject/utils": "^0.4.2",
         "isomorphic-fetch": "^2.2.1",
@@ -52,3 +67,4 @@ "lodash": "^4.17.4",
     "devDependencies": {
-        "@0xproject/tslint-config": "^0.4.10",
+        "@0xproject/monorepo-scripts": "^0.1.13",
+        "@0xproject/tslint-config": "^0.4.11",
         "@types/fetch-mock": "^5.12.1",
@@ -59,6 +75,7 @@ "@types/lodash": "^4.14.86",
         "@types/websocket": "^0.0.34",
+        "async-child-process": "^1.1.1",
         "chai": "^4.0.1",
         "chai-as-promised": "^7.1.0",
-        "chai-as-promised-typescript-typings": "^0.0.10",
-        "chai-typescript-typings": "^0.0.4",
+        "chai-as-promised-typescript-typings": "^0.0.11",
+        "chai-typescript-typings": "^0.0.5",
         "copyfiles": "^1.2.0",
@@ -69,2 +86,3 @@ "dirty-chai": "^2.0.1",
         "npm-run-all": "^4.1.2",
+        "nyc": "^11.0.1",
         "shx": "^0.2.2",
@@ -74,4 +92,7 @@ "tslint": "5.8.0",
         "typescript": "2.7.1",
-        "web3-typescript-typings": "^0.10.0"
+        "web3-typescript-typings": "^0.10.1"
+    },
+    "publishConfig": {
+        "access": "public"
     }
 }

No alert changes

Worsened metrics

Total package byte prevSize

71408

decreased by-39.7%

Dependency count

8

increased by14.29%

Dev dependency count

23

increased by15%

Number of package files

52

decreased by-34.18%

Lines of code

1139

decreased by-35.94%

Dependency changes

• + Added@0xproject/types@^0.4.0

• Updated@0xproject/assert@^0.2.1

• Updated@0xproject/json-schemas@^0.7.15

• Updated@0xproject/utils@^0.4.2