@cardash/winston-datadog-tcp - npm Package Compare versions

Comparing version 2.0.1 to 2.0.2

2.x/index.js

 const tls = require('tls')
 const hostname = require('os').hostname()
+const safeStringify = require('fast-safe-stringify')
 
@@ -29,3 +30,3 @@ const createConnection = () => {
         status: loglevel,
-        message: `${text} ${JSON.stringify(data)}`,
+        message: `${text} ${safeStringify(data)}`,
         data,
@@ -40,3 +41,3 @@ ddtags,
         if (dd.queuedMessage) return dd.conn.write(dd.queuedMessage, () => {
-          dd.queuedMessage = `${apiKey} ${JSON.stringify(record)}\n`
+          dd.queuedMessage = `${apiKey} ${safeStringify(record)}\n`
           dd.conn.write(dd.queuedMessage, () => {
@@ -48,3 +49,3 @@ dd.queuedMessage = undefined
       }
-      dd.queuedMessage = `${apiKey} ${JSON.stringify(record)}\n`
+      dd.queuedMessage = `${apiKey} ${safeStringify(record)}\n`
       dd.conn.write(dd.queuedMessage, () => {
@@ -51,0 +52,0 @@ dd.queuedMessage = undefined

package.json

 {
   "name": "@cardash/winston-datadog-tcp",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "A Winston-compatible (2.x) Datadog logger via TCP+SSL. No local file taking up space, no log rotation management.",
@@ -35,4 +35,5 @@ "main": "index.js",
   "dependencies": {
+    "fast-safe-stringify": "^2.0.6",
     "winston-transport": "^4.3.0"
   }
 }

test/2.x.js

@@ -122,1 +122,29 @@ const hostname = require('os').hostname()
 }
+
+exports.testCircularLogging = (test) => {
+  test.expect(1)
+  const fakeConn = {
+    write: (str, cb) => {
+      test.equals(str, `FAKE_KEY ${JSON.stringify({
+        status: 'info',
+        message: 'Hello {"a":1,"o":"[Circular]"}',
+        data: {
+          a: 1,
+          o: '[Circular]'
+        },
+        ddtags: 'env:test',
+        ddsource: '@cardash/winston-datadog-tcp',
+        hostname,
+      })}\n`)
+      cb()
+    },
+  }
+
+  const logObj = winstonDatadogTcp('FAKE_KEY', { env: 'test', })
+  logObj.dd.conn = fakeConn
+  const data = {
+    a: 1,
+  }
+  data.o = data
+  logObj.log('info', 'Hello', data, () => test.done())
+}

No alert changes

Improved metrics

Total package byte prevSize

12133

increased by6.31%

Lines of code

273

increased by10.98%

Worsened metrics

Dependency count

2

increased by100%

Dependency changes

• + Addedfast-safe-stringify@^2.0.6

• + Addedfast-safe-stringify@2.1.1(transitive)