@github/auto-complete-element - npm Package Compare versions

Comparing version 0.8.0 to 0.8.1

dist/index.esm.js

@@ -65,3 +65,2 @@ function debounce(callback, wait) {
 
-/*  strict */
 function install(input, list) {
@@ -73,3 +72,2 @@ input.addEventListener('compositionstart', trackComposition);
 }
-
 function uninstall(input, list) {
@@ -82,3 +80,2 @@ input.removeAttribute('aria-activedescendant');
 }
-
 var isComposing = false;
@@ -140,3 +137,2 @@ var ctrlBindings = !!navigator.userAgent.match(/Macintosh/);
   if (!target) return;
-  event.preventDefault();
   if (target.getAttribute('aria-disabled') === 'true') return;
@@ -150,3 +146,3 @@ fireCommitEvent(target);
   if (target.getAttribute('aria-disabled') === 'true') return true;
-  fireCommitEvent(target);
+  target.click();
   return true;
@@ -175,30 +171,12 @@ }
   if (!target) return;
-  var _iteratorNormalCompletion = true;
-  var _didIteratorError = false;
-  var _iteratorError = undefined;
 
-  try {
-    for (var _iterator = els[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
-      var el = _step.value;
+  for (var _i = 0; _i < els.length; _i++) {
+    var el = els[_i];
 
-      if (target === el) {
-        input.setAttribute('aria-activedescendant', target.id);
-        target.setAttribute('aria-selected', 'true');
-      } else {
-        el.setAttribute('aria-selected', 'false');
-      }
+    if (target === el) {
+      input.setAttribute('aria-activedescendant', target.id);
+      target.setAttribute('aria-selected', 'true');
+    } else {
+      el.setAttribute('aria-selected', 'false');
     }
-  } catch (err) {
-    _didIteratorError = true;
-    _iteratorError = err;
-  } finally {
-    try {
-      if (!_iteratorNormalCompletion && _iterator.return) {
-        _iterator.return();
-      }
-    } finally {
-      if (_didIteratorError) {
-        throw _iteratorError;
-      }
-    }
   }
@@ -296,12 +274,6 @@ }
     if (!(selected instanceof HTMLElement)) return;
-
-    if (selected instanceof HTMLAnchorElement) {
-      selected.click();
-      this.container.open = false;
-      return;
-    }
-
+    this.container.open = false;
+    if (selected instanceof HTMLAnchorElement) return;
     const value = selected.getAttribute('data-autocomplete-value') || selected.textContent;
     this.container.value = value;
-    this.container.open = false;
   }
@@ -308,0 +280,0 @@

dist/index.umd.js

@@ -71,3 +71,2 @@ (function (global, factory) {
 
-  /*  strict */
   function install(input, list) {
@@ -79,3 +78,2 @@ input.addEventListener('compositionstart', trackComposition);
   }
-
   function uninstall(input, list) {
@@ -88,3 +86,2 @@ input.removeAttribute('aria-activedescendant');
   }
-
   var isComposing = false;
@@ -146,3 +143,2 @@ var ctrlBindings = !!navigator.userAgent.match(/Macintosh/);
     if (!target) return;
-    event.preventDefault();
     if (target.getAttribute('aria-disabled') === 'true') return;
@@ -156,3 +152,3 @@ fireCommitEvent(target);
     if (target.getAttribute('aria-disabled') === 'true') return true;
-    fireCommitEvent(target);
+    target.click();
     return true;
@@ -181,30 +177,12 @@ }
     if (!target) return;
-    var _iteratorNormalCompletion = true;
-    var _didIteratorError = false;
-    var _iteratorError = undefined;
 
-    try {
-      for (var _iterator = els[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
-        var el = _step.value;
+    for (var _i = 0; _i < els.length; _i++) {
+      var el = els[_i];
 
-        if (target === el) {
-          input.setAttribute('aria-activedescendant', target.id);
-          target.setAttribute('aria-selected', 'true');
-        } else {
-          el.setAttribute('aria-selected', 'false');
-        }
+      if (target === el) {
+        input.setAttribute('aria-activedescendant', target.id);
+        target.setAttribute('aria-selected', 'true');
+      } else {
+        el.setAttribute('aria-selected', 'false');
       }
-    } catch (err) {
-      _didIteratorError = true;
-      _iteratorError = err;
-    } finally {
-      try {
-        if (!_iteratorNormalCompletion && _iterator.return) {
-          _iterator.return();
-        }
-      } finally {
-        if (_didIteratorError) {
-          throw _iteratorError;
-        }
-      }
     }
@@ -302,12 +280,6 @@ }
       if (!(selected instanceof HTMLElement)) return;
-
-      if (selected instanceof HTMLAnchorElement) {
-        selected.click();
-        this.container.open = false;
-        return;
-      }
-
+      this.container.open = false;
+      if (selected instanceof HTMLAnchorElement) return;
       const value = selected.getAttribute('data-autocomplete-value') || selected.textContent;
       this.container.value = value;
-      this.container.open = false;
     }
@@ -314,0 +286,0 @@

package.json

 {
   "name": "@github/auto-complete-element",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Auto-complete input values from server results",
@@ -25,3 +25,3 @@ "repository": "github/auto-complete-element",
   "dependencies": {
-    "@github/combobox-nav": "^0.2.2"
+    "@github/combobox-nav": "^0.2.3"
   },
@@ -28,0 +28,0 @@ "devDependencies": {

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

30975

decreased by-4.24%

Lines of code

754

decreased by-5.99%

Dependency changes

• Updated@github/combobox-nav@^0.2.3