@github/check-all - npm Package Compare versions

Comparing version 0.2.1 to 0.2.2

dist/check-all.esm.js

@@ -15,3 +15,4 @@ function _slicedToArray(arr, i) { return _arrayWithHoles(arr) || _iterableToArrayLimit(arr, i) || _nonIterableRest(); }
 
-  function setChecked(target, input, checked, indeterminate) {
+  function setChecked(target, input, checked) {
+    var indeterminate = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : false;
     if (!(input instanceof HTMLInputElement)) return;
@@ -65,3 +66,3 @@ input.indeterminate = indeterminate;
         var input = _step.value;
-        setChecked(target, input, target.checked, false);
+        setChecked(target, input, target.checked);
       }
@@ -105,4 +106,2 @@ } catch (err) {
     if (!(target instanceof HTMLInputElement)) return;
-    var allCheckbox = container.querySelector('[data-check-all]');
-    if (!allCheckbox) return;
     var itemCheckboxes = Array.from(container.querySelectorAll('[data-check-all-item]'));
@@ -123,3 +122,3 @@
           var input = _step2.value;
-          setChecked(target, input, target.checked, false);
+          setChecked(target, input, target.checked);
         }
@@ -144,9 +143,14 @@ } catch (err) {
     lastCheckbox = target;
-    var total = itemCheckboxes.length;
-    var count = itemCheckboxes.filter(function (checkbox) {
-      return checkbox instanceof HTMLInputElement && checkbox.checked;
-    }).length;
-    var checked = count === total;
-    var indeterminate = total > count && count > 0;
-    setChecked(target, allCheckbox, checked, indeterminate);
+    var allCheckbox = container.querySelector('[data-check-all]');
+
+    if (allCheckbox) {
+      var total = itemCheckboxes.length;
+      var count = itemCheckboxes.filter(function (checkbox) {
+        return checkbox instanceof HTMLInputElement && checkbox.checked;
+      }).length;
+      var checked = count === total;
+      var indeterminate = total > count && count > 0;
+      setChecked(target, allCheckbox, checked, indeterminate);
+    }
+
     updateCount();
@@ -153,0 +157,0 @@ }

dist/check-all.umd.js

@@ -35,3 +35,4 @@ (function (global, factory) {
 
-    function setChecked(target, input, checked, indeterminate) {
+    function setChecked(target, input, checked) {
+      var indeterminate = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : false;
       if (!(input instanceof HTMLInputElement)) return;
@@ -85,3 +86,3 @@ input.indeterminate = indeterminate;
           var input = _step.value;
-          setChecked(target, input, target.checked, false);
+          setChecked(target, input, target.checked);
         }
@@ -125,4 +126,2 @@ } catch (err) {
       if (!(target instanceof HTMLInputElement)) return;
-      var allCheckbox = container.querySelector('[data-check-all]');
-      if (!allCheckbox) return;
       var itemCheckboxes = Array.from(container.querySelectorAll('[data-check-all-item]'));
@@ -143,3 +142,3 @@
             var input = _step2.value;
-            setChecked(target, input, target.checked, false);
+            setChecked(target, input, target.checked);
           }
@@ -164,9 +163,14 @@ } catch (err) {
       lastCheckbox = target;
-      var total = itemCheckboxes.length;
-      var count = itemCheckboxes.filter(function (checkbox) {
-        return checkbox instanceof HTMLInputElement && checkbox.checked;
-      }).length;
-      var checked = count === total;
-      var indeterminate = total > count && count > 0;
-      setChecked(target, allCheckbox, checked, indeterminate);
+      var allCheckbox = container.querySelector('[data-check-all]');
+
+      if (allCheckbox) {
+        var total = itemCheckboxes.length;
+        var count = itemCheckboxes.filter(function (checkbox) {
+          return checkbox instanceof HTMLInputElement && checkbox.checked;
+        }).length;
+        var checked = count === total;
+        var indeterminate = total > count && count > 0;
+        setChecked(target, allCheckbox, checked, indeterminate);
+      }
+
       updateCount();
@@ -173,0 +177,0 @@ }

package.json

 {
   "name": "@github/check-all",
   "description": "Multiple checkbox selection helper.",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "main": "dist/check-all.umd.js",
@@ -33,3 +33,3 @@ "module": "dist/check-all.esm.js",
     "flow-bin": "^0.93.0",
-    "karma": "^4.0.0",
+    "karma": "^4.1.0",
     "karma-chai": "^0.1.0",
@@ -39,4 +39,4 @@ "karma-chrome-launcher": "^2.2.0",
     "karma-mocha-reporter": "^2.2.5",
-    "mocha": "^6.0.2"
+    "mocha": "^6.1.4"
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

16243

increased by1.08%

Lines of code

307

increased by1.32%

No dependency changes