@github/hotkey - npm Package Compare versions

Comparing version 1.1.3 to 1.2.0

dist/index.esm.js

@@ -162,8 +162,19 @@ function _classCallCheck(instance, Constructor) {
   var type = (element.getAttribute('type') || '').toLowerCase();
-  return name === 'select' || name === 'textarea' || name === 'input' && type !== 'submit' && type !== 'reset' || element.isContentEditable;
+  return name === 'select' || name === 'textarea' || name === 'input' && type !== 'submit' && type !== 'reset' && type !== 'checkbox' && type !== 'radio' || element.isContentEditable;
 }
+
+function isActivableFormField(element) {
+  if (!(element instanceof HTMLElement)) {
+    return false;
+  }
+
+  var name = element.nodeName.toLowerCase();
+  var type = (element.getAttribute('type') || '').toLowerCase();
+  return name === 'input' && (type === 'checkbox' || type === 'radio');
+}
+
 function fireDeterminedAction(el) {
   if (isFormField(el)) {
     el.focus();
-  } else if (el instanceof HTMLAnchorElement && el.href || el.tagName === 'BUTTON' || el.tagName === 'SUMMARY') {
+  } else if (el instanceof HTMLAnchorElement && el.href || el.tagName === 'BUTTON' || el.tagName === 'SUMMARY' || isActivableFormField(el)) {
     el.click();
@@ -170,0 +181,0 @@ }

dist/index.umd.js

@@ -168,8 +168,19 @@ (function (global, factory) {
     var type = (element.getAttribute('type') || '').toLowerCase();
-    return name === 'select' || name === 'textarea' || name === 'input' && type !== 'submit' && type !== 'reset' || element.isContentEditable;
+    return name === 'select' || name === 'textarea' || name === 'input' && type !== 'submit' && type !== 'reset' && type !== 'checkbox' && type !== 'radio' || element.isContentEditable;
   }
+
+  function isActivableFormField(element) {
+    if (!(element instanceof HTMLElement)) {
+      return false;
+    }
+
+    var name = element.nodeName.toLowerCase();
+    var type = (element.getAttribute('type') || '').toLowerCase();
+    return name === 'input' && (type === 'checkbox' || type === 'radio');
+  }
+
   function fireDeterminedAction(el) {
     if (isFormField(el)) {
       el.focus();
-    } else if (el instanceof HTMLAnchorElement && el.href || el.tagName === 'BUTTON' || el.tagName === 'SUMMARY') {
+    } else if (el instanceof HTMLAnchorElement && el.href || el.tagName === 'BUTTON' || el.tagName === 'SUMMARY' || isActivableFormField(el)) {
       el.click();
@@ -176,0 +187,0 @@ }

package.json

 {
   "name": "@github/hotkey",
-  "version": "1.1.3",
+  "version": "1.2.0",
   "description": "",
@@ -5,0 +5,0 @@ "main": "dist/index.umd.js",

No alert changes

Improved metrics

Total package byte prevSize

22977

increased by3.35%

Lines of code

511

increased by3.23%

No dependency changes