@google-cloud/speech - npm Package Compare versions

Comparing version 4.0.0 to 4.1.0

build/src/v1/speech_client.js

@@ -78,11 +78,14 @@ "use strict";
         opts.port = opts.port || port;
+        // users can override the config from client side, like retry codes name.
+        // The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
+        // The way to override client config for Showcase API:
+        //
+        // const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
+        // const showcaseClient = new showcaseClient({ projectId, customConfig });
         opts.clientConfig = opts.clientConfig || {};
-        const isBrowser = typeof window !== 'undefined';
-        if (isBrowser) {
-            opts.fallback = true;
-        }
-        // If we are in browser, we are already using fallback because of the
-        // "browser" field in package.json.
-        // But if we were explicitly requested to use fallback, let's do it now.
-        this._gaxModule = !isBrowser && opts.fallback ? gax.fallback : gax;
+        // If we're running in browser, it's OK to omit `fallback` since
+        // google-gax has `browser` field in its `package.json`.
+        // For Electron (which does not respect `browser` field),
+        // pass `{fallback: true}` to the SpeechClient constructor.
+        this._gaxModule = opts.fallback ? gax.fallback : gax;
         // Create a `gaxGrpc` object, with any grpc-specific options
@@ -89,0 +92,0 @@ // sent to the client.

build/src/v1p1beta1/speech_client.js

@@ -78,11 +78,14 @@ "use strict";
         opts.port = opts.port || port;
+        // users can override the config from client side, like retry codes name.
+        // The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
+        // The way to override client config for Showcase API:
+        //
+        // const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
+        // const showcaseClient = new showcaseClient({ projectId, customConfig });
         opts.clientConfig = opts.clientConfig || {};
-        const isBrowser = typeof window !== 'undefined';
-        if (isBrowser) {
-            opts.fallback = true;
-        }
-        // If we are in browser, we are already using fallback because of the
-        // "browser" field in package.json.
-        // But if we were explicitly requested to use fallback, let's do it now.
-        this._gaxModule = !isBrowser && opts.fallback ? gax.fallback : gax;
+        // If we're running in browser, it's OK to omit `fallback` since
+        // google-gax has `browser` field in its `package.json`.
+        // For Electron (which does not respect `browser` field),
+        // pass `{fallback: true}` to the SpeechClient constructor.
+        this._gaxModule = opts.fallback ? gax.fallback : gax;
         // Create a `gaxGrpc` object, with any grpc-specific options
@@ -89,0 +92,0 @@ // sent to the client.

CHANGELOG.md

@@ -7,2 +7,14 @@ # Changelog
 
+## [4.1.0](https://www.github.com/googleapis/nodejs-speech/compare/v4.0.0...v4.1.0) (2020-06-12)
+
+
+### Features
+
+* **secrets:** begin migration to secret manager from keystore ([#605](https://www.github.com/googleapis/nodejs-speech/issues/605)) ([e3ac050](https://www.github.com/googleapis/nodejs-speech/commit/e3ac050fc99adf0907b29fe8ef54c24037dc7229))
+
+
+### Bug Fixes
+
+* handle fallback option properly ([#608](https://www.github.com/googleapis/nodejs-speech/issues/608)) ([2e8558c](https://www.github.com/googleapis/nodejs-speech/commit/2e8558c1a01d6924c3f443306bfa29f5bd87ad3b))
+
 ## [4.0.0](https://www.github.com/googleapis/nodejs-speech/compare/v3.6.0...v4.0.0) (2020-05-15)
@@ -9,0 +21,0 @@

package.json

 {
   "name": "@google-cloud/speech",
   "description": "Cloud Speech Client Library for Node.js",
-  "version": "4.0.0",
+  "version": "4.1.0",
   "license": "Apache-2.0",
@@ -66,3 +66,3 @@ "author": "Google Inc.",
     "linkinator": "^2.0.0",
-    "mocha": "^7.0.0",
+    "mocha": "^8.0.0",
     "null-loader": "^4.0.0",
@@ -69,0 +69,0 @@ "pack-n-play": "^1.0.0-2",

No alert changes

Improved metrics

Total package byte prevSize

2484669

increased by0.13%

Lines of code

34826

increased by0.1%

No dependency changes