@jsenv/eslint-config - npm Package Compare versions

Comparing version 16.2.4 to 16.2.5

package.json

 {
   "name": "@jsenv/eslint-config",
-  "version": "16.2.4",
+  "version": "16.2.5",
   "description": "Create ESLint configuration for any project",
@@ -52,4 +52,4 @@ "license": "MIT",
     "eslint-plugin-html": "7.1.0",
-    "eslint-plugin-react": "7.31.8"
+    "eslint-plugin-react": "7.31.10"
   }
 }

src/jsenvEslintRules.js

@@ -155,3 +155,3 @@ /*
   "no-labels": ["off"], // https://gist.github.com/getify/706e5e10822a298375da40f9cc1fa295
-  "no-lone-blocks": ["error"],
+  "no-lone-blocks": ["off"], // https://gist.github.com/getify/706e5e10822a298375da40f9cc1fa295
   "no-lonely-if": ["error"],
@@ -229,4 +229,23 @@ "no-loop-func": ["error"],
   "no-unused-vars": ["error"],
-  // this rule is bad, too much false positive, annoying
-  "no-use-before-define": ["off", "nofunc"],
+  "no-use-before-define": [
+    "error",
+    /*
+     * "no-use-before-define" is great to prevent a common mistake
+     * where code tries to use a variable before it's actually available.
+     * In practice this rule fails even on valid code.
+     * Enabling the default options of this rule would
+     * force variables,functions and classes to be declared in specific order
+     * which is very annoying because:
+     * - code is valid in the first place
+     * - it's SUPER NICE to put variables and functions that are
+     *   implementation details at the bottom of the file to make
+     *   important code more accesible
+     */
+    {
+      functions: false,
+      variables: false,
+      classes: false,
+      allowNamedExports: true,
+    },
+  ],
   "no-useless-call": ["error"],
@@ -233,0 +252,0 @@ "no-useless-concat": ["error"],

src/jsenvEslintRulesForImport.js

@@ -43,2 +43,6 @@ /*
   ],
+  "import/no-self-import": ["error"],
+  "import/no-cycle": ["error"],
+  "import/no-useless-path-segments": ["error"],
+  "import/no-default-export": ["error"],
 }

No alert changes

Improved metrics

Total package byte prevSize

48316

increased by3.67%

Lines of code

1199

increased by3.9%

No dependency changes