@knide/mp4box-player - npm Package Compare versions

Comparing version 2.0.7 to 2.0.8

package.json

 {
   "name": "@knide/mp4box-player",
-  "version": "2.0.7",
+  "version": "2.0.8",
   "author": "ashuvssut ([e-mail])",
@@ -5,0 +5,0 @@ "license": "MIT",

src/Downloader.js

@@ -169,2 +169,14 @@ import { Log } from "@knide/mp4box";
 
+        if (dl.eof) {
+          if (buffer.byteLength !== dl.chunkSize)
+            console.log(
+              `EOF Reason: Received Buffer length didn't match with Expected Buffer Length`,
+              `Buffer Length: ${buffer.byteLength.toLocaleString()}, Expected Length: ${dl.chunkSize.toLocaleString()}, Total Length: ${dl.totalLength.toLocaleString()}`
+            );
+          else if (buffer.byteLength === dl.totalLength)
+            console.log(
+              `EOF Reason: Total Length reached, Buffer Length: ${buffer.byteLength.toLocaleString()}, Expected Length: ${dl.totalLength.toLocaleString()}, Total Length: ${dl.totalLength.toLocaleString()}`
+            );
+        } else Log.info(`EOF:${dl.eof}`, `Received Buffer Length: ${buffer.byteLength.toLocaleString()}, Expected Length: ${dl.chunkSize.toLocaleString()}, Total Length: ${dl.totalLength.toLocaleString()}`);
+
         buffer.fileStart = dl.chunkStart;
@@ -203,7 +215,6 @@
       .catch(function (error) {
-        console.error(error);
         if (error.name === "AbortError") {
-          console.log("Fetch request aborted.");
+          console.info("Range request aborted.");
         } else {
-          dl.callback(null, false, true);
+          dl.callback(null, false, error);
         }
@@ -210,0 +221,0 @@ });

src/Mp4boxPlayer.js

@@ -39,6 +39,11 @@ import {
 
+    /** @private Only onStatusChange is callable */
     this.onStatusChangeCallback = null;
+    /** @private Only onMovieInfo is callable */
     this.onMovieInfoCallback = null;
+    /** @private Only onTrackInfo is callable */
     this.onTrackInfoCallback = null;
+    /** @private Only onError is callable */
     this.onErrorCallback = null;
+
     this.onWindowLoad();
@@ -76,3 +81,3 @@ }
    * @param {Object} error - Error object
-   * @param {string} message - Optional custom error message from Mp4boxPlayer.
+   * @param {any} extraContext - Optional custom error message/data from Mp4boxPlayer.
    */
@@ -336,3 +341,3 @@ /** @param {OnErrorCallback} callback - Called when the status of a control changes */
       }
-      this.generateMovieInfo(info); // TODO: miss
+      this.generateMovieInfo(info);
       this.addSourceBufferListener(info);
@@ -473,3 +478,7 @@ this.stop();
         this.reset();
-        this.onErrorCallback?.("Download error", error);
+        this.onErrorCallback?.(
+          "Download error",
+          error,
+          `EOF: ${end}, Buffer: ${response}`
+        );
         Log.error("Progress", "Download error!");
@@ -571,3 +580,9 @@ }
       if (sb.is_last) {
-        if (sb.ms.readyState === "open") sb.ms.endOfStream();
+        try {
+          if (sb.ms.readyState === "open" && !sb.updating) sb.ms.endOfStream();
+        } catch (e) {
+          const errId = `MSE - SourceBuffer #${sb.id}`;
+          Log.error(errId, e);
+          this.onErrorCallback?.(errId, e, sb);
+        }
       }
@@ -804,3 +819,3 @@ }
     SHOW_LOGS && console.log("initTrackViewer", track.id);
-    // TODO: miss
+    // TODO: miss::subtitles
     // if (track.mime === "image/x3d+xml" && typeof x3dom === "undefined") {
@@ -807,0 +822,0 @@ //   var link = document.createElement("link");

No alert changes

Improved metrics

Total package byte prevSize

83975

increased by1.61%

Lines of code

2315

increased by1.05%

No dependency changes