@lion/form-core - npm Package Compare versions

Comparing version 0.3.0 to 0.3.1

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.3.1](https://github.com/ing-bank/lion/compare/@lion/form-core@0.3.0...@lion/form-core@0.3.1) (2020-07-28)
+
+
+### Bug Fixes
+
+* resolve registrationComplete via microtask to be sync ([6b8daef](https://github.com/ing-bank/lion/commit/6b8daef5099ab7bab40f9bdd8aaa1a0795b56214))
+
+
+
+
+
 # [0.3.0](https://github.com/ing-bank/lion/compare/@lion/form-core@0.2.6...@lion/form-core@0.3.0) (2020-07-27)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/form-core",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Form-core contains all essential building blocks for creating form fields and fieldsets",
@@ -46,3 +46,3 @@ "license": "MIT",
   },
-  "gitHead": "bb4190d5212d570c0572c77a5946db250ad402da"
+  "gitHead": "0afd2edb79c5c611353b81aaa41d5e134957138b"
 }

src/choice-group/ChoiceGroupMixin.js

@@ -97,7 +97,4 @@ import { dedupeMixin } from '@lion/core';
         super.connectedCallback();
+        Promise.resolve().then(() => this.__resolveRegistrationComplete());
 
-        this.__registrationCompleteTimer = setTimeout(() => {
-          this.__resolveRegistrationComplete();
-        });
-
         this.registrationComplete.then(() => {
@@ -114,3 +111,2 @@ this.__isInitialModelValue = false;
 
-        clearTimeout(this.__registrationCompleteTimer);
         if (this.registrationComplete.done === false) {
@@ -117,0 +113,0 @@ this.__rejectRegistrationComplete();

src/form-group/FormGroupMixin.js

@@ -157,7 +157,4 @@ import { dedupeMixin, html, SlotMixin } from '@lion/core';
         this.setAttribute('role', 'group');
+        Promise.resolve().then(() => this.__resolveRegistrationComplete());
 
-        this.__registrationCompleteTimer = setTimeout(() => {
-          this.__resolveRegistrationComplete();
-        });
-
         this.registrationComplete.then(() => {
@@ -179,3 +176,2 @@ this.__isInitialModelValue = false;
         }
-        clearTimeout(this.__registrationCompleteTimer);
         if (this.registrationComplete.done === false) {
@@ -182,0 +178,0 @@ this.__rejectRegistrationComplete();

test/choice-group/ChoiceGroupMixin.test.js

@@ -67,3 +67,2 @@ import { html, LitElement } from '@lion/core';
     `);
-    await el.registrationComplete;
 
@@ -108,3 +107,2 @@ expect(el.formElements[0].name).to.equal('gender');
     `);
-    await el.registrationComplete;
 
@@ -123,3 +121,2 @@ expect(el.modelValue).to.equal('other');
     `);
-    await el.registrationComplete;
 
@@ -170,3 +167,2 @@ expect(el.serializedValue).to.equal('other');
     `);
-    await el.registrationComplete;
 
@@ -192,3 +188,2 @@ expect(el.modelValue).to.equal('female');
     `);
-    await el.registrationComplete;
 
@@ -287,3 +282,2 @@ counter = 0; // reset after setup which may result in different results
 
-      await el.registrationComplete;
       el.modelValue = ['male', 'other'];
@@ -304,3 +298,2 @@ expect(el.modelValue).to.eql(['male', 'other']);
 
-      await el.registrationComplete;
       expect(el.modelValue).to.eql(['male', 'other']);
@@ -307,0 +300,0 @@ expect(el.formElements[0].checked).to.be.true;

No alert changes

Worsened metrics

Total package byte prevSize

248139

decreased by-0.07%

Lines of code

5877

decreased by-0.22%

No dependency changes