@microsoft/vscode-azext-azureappservice - npm Package Compare versions

Comparing version 2.4.0-agent.3 to 3.0.0

out/src/createAppService/SiteNameStep.d.ts

@@ -7,5 +7,4 @@ import { AzureNameStep, IAzureAgentInput, ParameterAgentMetadata } from '@microsoft/vscode-azext-utils';
 export declare class SiteNameStep extends AzureNameStep<SiteNameStepWizardContext> {
-    private _skipValidation;
     private _inputBoxOptionsAgentMetadata;
-    constructor(skipValidation?: boolean, inputBoxOptionsAgentMetadata?: ParameterAgentMetadata);
+    constructor(inputBoxOptionsAgentMetadata?: ParameterAgentMetadata);
     prompt(context: SiteNameStepWizardContext): Promise<void>;
@@ -12,0 +11,0 @@ getRelatedName(context: IAppServiceWizardContext, name: string): Promise<string | undefined>;

out/src/createAppService/SiteNameStep.js

@@ -31,5 +31,4 @@ "use strict";
 class SiteNameStep extends vscode_azext_utils_1.AzureNameStep {
-    constructor(skipValidation, inputBoxOptionsAgentMetadata) {
+    constructor(inputBoxOptionsAgentMetadata) {
         super();
-        this._skipValidation = skipValidation !== null && skipValidation !== void 0 ? skipValidation : false;
         this._inputBoxOptionsAgentMetadata = inputBoxOptionsAgentMetadata;
@@ -73,3 +72,2 @@ }
                 agentMetadata: (_c = this._inputBoxOptionsAgentMetadata) !== null && _c !== void 0 ? _c : {
-                    parameterName: "siteName",
                     parameterDisplayTitle: "Site Name",
@@ -79,6 +77,2 @@ parameterDisplayDescription: "The name of the app service site.",
             };
-            if (this._skipValidation) {
-                options.validateInput = undefined;
-                options.asyncValidationTask = undefined;
-            }
             context.newSiteName = (yield context.ui.showInputBox(options)).trim();
@@ -85,0 +79,0 @@ context.valuesToMask.push(context.newSiteName);

out/src/deploy/wizard/createDeployWizard.js

@@ -55,3 +55,3 @@ "use strict";
                 const pathFileMap = new Map([
-                    [path.basename(context.workspaceFolder.uri.fsPath), 'app.jar']
+                    [path.basename(context.fsPath), 'app.jar']
                 ]);
@@ -70,5 +70,3 @@ executeSteps.push(new DeployZipPushExecuteStep_1.DeployZipPushExecuteStep(pathFileMap));
         executeSteps.push(new PostDeployTaskExecuteStep_1.PostDeployTaskExecuteStep(config));
-        if (context.syncTriggersPostDeploy) {
-            executeSteps.push(new PostDeploySyncTriggersExecuteStep_1.PostDeploySyncTriggersExecuteStep());
-        }
+        executeSteps.push(new PostDeploySyncTriggersExecuteStep_1.PostDeploySyncTriggersExecuteStep());
         return executeSteps;
@@ -75,0 +73,0 @@ });

out/src/deploy/wizard/DeployExecuteStepBase.js

@@ -58,3 +58,3 @@ "use strict";
     return __awaiter(this, void 0, void 0, function* () {
-        context.telemetry.properties.sourceHash = yield vscode_azext_utils_1.randomUtils.getPseudononymousStringHash(context.workspaceFolder.uri.fsPath);
+        context.telemetry.properties.sourceHash = yield vscode_azext_utils_1.randomUtils.getPseudononymousStringHash(context.fsPath);
         context.telemetry.properties.destHash = yield vscode_azext_utils_1.randomUtils.getPseudononymousStringHash(context.site.fullName);
@@ -61,0 +61,0 @@ context.telemetry.properties.scmType = String(config.scmType);

out/src/deploy/wizard/DeployLocalGitExecuteStep.js

@@ -22,3 +22,3 @@ "use strict";
         return __awaiter(this, void 0, void 0, function* () {
-            yield (0, localGitDeploy_1.localGitDeploy)(context.site, { fsPath: context.workspaceFolder.uri.fsPath }, context);
+            yield (0, localGitDeploy_1.localGitDeploy)(context.site, { fsPath: context.fsPath }, context);
         });
@@ -25,0 +25,0 @@ }

out/src/deploy/wizard/deployZip/DeployFlexExecuteStep.js

@@ -31,3 +31,3 @@ "use strict";
             return yield (0, runWithZipStream_1.runWithZipStream)(context, {
-                fsPath: context.workspaceFolder.uri.fsPath,
+                fsPath: context.fsPath,
                 site: context.site,
@@ -34,0 +34,0 @@ pathFileMap: this.pathFileMap,

out/src/deploy/wizard/deployZip/DeployWarExecuteStep.js

@@ -25,7 +25,7 @@ "use strict";
         return __awaiter(this, void 0, void 0, function* () {
-            if ((0, pathUtils_1.getFileExtension)(context.workspaceFolder.uri.fsPath) !== 'war') {
+            if ((0, pathUtils_1.getFileExtension)(context.fsPath) !== 'war') {
                 throw new Error(vscode_1.l10n.t('Path specified is not a war file'));
             }
             const kuduClient = yield context.site.createClient(context);
-            yield kuduClient.warPushDeploy(context, () => fs.createReadStream(context.workspaceFolder.uri.fsPath), {
+            yield kuduClient.warPushDeploy(context, () => fs.createReadStream(context.fsPath), {
                 isAsync: true,
@@ -32,0 +32,0 @@ author: constants_1.publisherName,

out/src/deploy/wizard/deployZip/DeployZipBaseExecuteStep.js

@@ -27,3 +27,3 @@ "use strict";
         return __awaiter(this, void 0, void 0, function* () {
-            const fsPath = context.workspaceFolder.uri.fsPath;
+            const fsPath = context.fsPath;
             if (!(yield vscode_azext_utils_1.AzExtFsExtra.pathExists(fsPath))) {
@@ -30,0 +30,0 @@ throw new Error(vscode_1.l10n.t('Failed to deploy path that does not exist: {0}', fsPath));

out/src/deploy/wizard/deployZip/DeployZipPushExecuteStep.js

@@ -33,3 +33,3 @@ "use strict";
             return yield (0, runWithZipStream_1.runWithZipStream)(context, {
-                fsPath: context.workspaceFolder.uri.fsPath,
+                fsPath: context.fsPath,
                 site: context.site,
@@ -36,0 +36,0 @@ pathFileMap: this.pathFileMap,

out/src/deploy/wizard/PostDeploySyncTriggersExecuteStep.d.ts

@@ -6,3 +6,3 @@ import { AzureWizardExecuteStep } from "@microsoft/vscode-azext-utils";
     execute(context: InnerDeployContext): Promise<void>;
-    shouldExecute(_context: InnerDeployContext): boolean;
+    shouldExecute(context: InnerDeployContext): boolean;
 }

out/src/deploy/wizard/PostDeploySyncTriggersExecuteStep.js

@@ -33,4 +33,5 @@ "use strict";
     }
-    shouldExecute(_context) {
-        return true;
+    shouldExecute(context) {
+        // this gets set in `waitForDeploymentToComplete` for consumption plans or storage account deployments
+        return !!context.syncTriggersPostDeploy;
     }
@@ -37,0 +38,0 @@ }

package.json

 {
     "name": "@microsoft/vscode-azext-azureappservice",
     "author": "Microsoft Corporation",
-    "version": "2.4.0-agent.3",
+    "version": "3.0.0",
     "description": "Common tools for developing Azure App Service extensions for VS Code",
@@ -43,5 +43,5 @@ "tags": [
         "@azure/storage-blob": "^12.3.0",
-        "@microsoft/vscode-azext-azureutils": "2.1.0-agent.4",
+        "@microsoft/vscode-azext-azureutils": "^3.0.0",
         "@microsoft/vscode-azext-github": "^1.0.0",
-        "@microsoft/vscode-azext-utils": "2.2.0-agent.7",
+        "@microsoft/vscode-azext-utils": "^2.2.0",
         "dayjs": "^1.11.2",
@@ -48,0 +48,0 @@ "fs-extra": "^10.0.0",

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

406201

decreased by-0.12%

Lines of code

7341

decreased by-0.11%

Dependency changes

• + Added@microsoft/vscode-azext-azureutils@3.0.1(transitive)

• - Removed@microsoft/vscode-azext-azureutils@2.1.0-agent.4(transitive)

• - Removed@microsoft/vscode-azext-utils@2.2.0-agent.7(transitive)

• Updated@microsoft/vscode-azext-azureutils@^3.0.0

• Updated@microsoft/vscode-azext-utils@^2.2.0