@nodelib/fs.walk - npm Package Compare versions

Comparing version 1.2.5 to 1.2.6

out/readers/common.js

@@ -23,4 +23,10 @@ "use strict";
     }
+    /**
+     * The correct handling of cases when the first segment is a root (`/`, `C:/`) or UNC path (`//?/C:/`).
+     */
+    if (a.endsWith(separator)) {
+        return a + b;
+    }
     return a + separator + b;
 }
 exports.joinPathSegments = joinPathSegments;

out/readers/common.spec.js

@@ -73,3 +73,14 @@ "use strict";
         });
+        it('should return correct string when the first segment ens with the separator symbol', () => {
+            // Unix
+            assert.strictEqual(common.joinPathSegments('/', 'a', '/'), '/a');
+            assert.strictEqual(common.joinPathSegments('//', 'a', '/'), '//a');
+            assert.strictEqual(common.joinPathSegments('/a/', 'b', '/'), '/a/b');
+            // Windows
+            assert.strictEqual(common.joinPathSegments('C:/', 'Users', '/'), 'C:/Users');
+            assert.strictEqual(common.joinPathSegments('C:\\', 'Users', '\\'), 'C:\\Users');
+            assert.strictEqual(common.joinPathSegments('//?/C:/', 'Users', '/'), '//?/C:/Users');
+            assert.strictEqual(common.joinPathSegments('\\\\?\\C:\\', 'Users', '\\'), '\\\\?\\C:\\Users');
+        });
     });
 });

package.json

 {
   "name": "@nodelib/fs.walk",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "A library for efficiently walking a directory recursively",
@@ -34,3 +34,3 @@ "license": "MIT",
   },
-  "gitHead": "cb5f7e893a986164c3b847a4f1faef6c54cadd68"
+  "gitHead": "bd149ea6dc1ef18c234730278271f6a7f3882ed2"
 }

src/readers/common.spec.ts

@@ -100,3 +100,16 @@ import * as assert from 'assert';
 		});
+
+		it('should return correct string when the first segment ens with the separator symbol', () => {
+			// Unix
+			assert.strictEqual(common.joinPathSegments('/', 'a', '/'), '/a');
+			assert.strictEqual(common.joinPathSegments('//', 'a', '/'), '//a');
+			assert.strictEqual(common.joinPathSegments('/a/', 'b', '/'), '/a/b');
+
+			// Windows
+			assert.strictEqual(common.joinPathSegments('C:/', 'Users', '/'), 'C:/Users');
+			assert.strictEqual(common.joinPathSegments('C:\\', 'Users', '\\'), 'C:\\Users');
+			assert.strictEqual(common.joinPathSegments('//?/C:/', 'Users', '/'), '//?/C:/Users');
+			assert.strictEqual(common.joinPathSegments('\\\\?\\C:\\', 'Users', '\\'), '\\\\?\\C:\\Users');
+		});
 	});
 });

src/readers/common.ts

@@ -25,3 +25,10 @@ import Settings, { FilterFunction } from '../settings';
 
+	/**
+	 * The correct handling of cases when the first segment is a root (`/`, `C:/`) or UNC path (`//?/C:/`).
+	 */
+	if (a.endsWith(separator)) {
+		return a + b;
+	}
+
 	return a + separator + b;
 }

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

209514

increased by0.89%

Lines of code

2186

increased by1.58%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes