@reach/combobox - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

es/index.js

@@ -319,4 +319,2 @@ var _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; };
 
-  // WHERE I LEFT OFF: focus is now opening the list, maybe it shouldn't, maybe
-  // make a <ComboboxButton/> that can control it instead.
   var handleFocus = function handleFocus() {
@@ -717,6 +715,3 @@ if (selectOnClick) {
         if (popoverRef.current.contains(document.activeElement)) {
-          // focus landed inside the combobox, keep it open, but we don't want
-          // "Enter" causing the popover to close, so we clear the navigation
-          // value to act like there's no navigation going on anymore (cause
-          // there isn't!)
+          // focus landed inside the combobox, keep it open
           if (state !== INTERACTING) {
@@ -723,0 +718,0 @@ transition(INTERACT);

index.js

@@ -338,4 +338,2 @@ "use strict";
 
-  // WHERE I LEFT OFF: focus is now opening the list, maybe it shouldn't, maybe
-  // make a <ComboboxButton/> that can control it instead.
   var handleFocus = function handleFocus() {
@@ -736,6 +734,3 @@ if (selectOnClick) {
         if (popoverRef.current.contains(document.activeElement)) {
-          // focus landed inside the combobox, keep it open, but we don't want
-          // "Enter" causing the popover to close, so we clear the navigation
-          // value to act like there's no navigation going on anymore (cause
-          // there isn't!)
+          // focus landed inside the combobox, keep it open
           if (state !== INTERACTING) {
@@ -742,0 +737,0 @@ transition(INTERACT);

package.json

 {
   "name": "@reach/combobox",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Accessible React Combobox (Autocomplete).",
@@ -5,0 +5,0 @@ "author": "Ryan Florence <@ryanflorence>",

src/index.js

@@ -378,4 +378,2 @@ /* eslint-disable jsx-a11y/role-has-required-aria-props */
 
-  // WHERE I LEFT OFF: focus is now opening the list, maybe it shouldn't, maybe
-  // make a <ComboboxButton/> that can control it instead.
   const handleFocus = () => {
@@ -790,6 +788,3 @@ if (selectOnClick) {
         if (popoverRef.current.contains(document.activeElement)) {
-          // focus landed inside the combobox, keep it open, but we don't want
-          // "Enter" causing the popover to close, so we clear the navigation
-          // value to act like there's no navigation going on anymore (cause
-          // there isn't!)
+          // focus landed inside the combobox, keep it open
           if (state !== INTERACTING) {
@@ -796,0 +791,0 @@ transition(INTERACT);

No alert changes

Worsened metrics

Total package byte prevSize

82572

decreased by-35.82%

Number of package files

5

decreased by-16.67%

Lines of code

2105

decreased by-0.71%

No dependency changes