@schibsted/niche-tracking - npm Package Compare versions

Comparing version 4.6.3 to 4.6.4

lib/tracker.d.ts

@@ -1,2 +0,2 @@
-import type { Mappers, Experiment, SingleTracker, TrackersConfig } from './types';
+import type { Mappers, Experiment, SingleTracker, EventMappers, TrackersConfig } from './types';
 declare class Tracker<PageViewEventType extends string, PageViewEventMapper extends Record<PageViewEventType, any>, EventType extends string, EventTypesMapper extends Record<EventType, any>, PageLeaveEventType extends string, PageLeaveEventTypeMapper extends Record<PageLeaveEventType, any>> {
@@ -24,4 +24,4 @@ private _initialized;
         pageViewTrackerMappers: Mappers<PageViewEventMapper[PageViewEventType]>;
-        eventTrackerMappers: Mappers<EventTypesMapper[EventType]>;
-        pageLeaveTrackerMappers: Mappers<PageLeaveEventTypeMapper[PageLeaveEventType]>;
+        eventTrackerMappers: EventMappers<EventTypesMapper[EventType]>;
+        pageLeaveTrackerMappers: EventMappers<PageLeaveEventTypeMapper[PageLeaveEventType]>;
     });
@@ -28,0 +28,0 @@ pageView: <T extends PageViewEventType>(type: T, payload?: PageViewEventMapper[T] | undefined) => void;

lib/tracker.js

@@ -50,3 +50,3 @@ import { eventTarget } from '@schibsted/niche-utils';
                                     const getTrackerOptions = (_b = (_a = this._pageLeaveTrackerMappers) === null || _a === void 0 ? void 0 : _a[leaveType]) === null || _b === void 0 ? void 0 : _b[tracker.name];
-                                    return getTrackerOptions === null || getTrackerOptions === void 0 ? void 0 : getTrackerOptions(options, (_c = this._lastPageViewEventData) === null || _c === void 0 ? void 0 : _c.pulse);
+                                    return getTrackerOptions === null || getTrackerOptions === void 0 ? void 0 : getTrackerOptions(options, (_c = this._lastPageViewEventData) === null || _c === void 0 ? void 0 : _c[tracker.name]);
                                 });
@@ -194,6 +194,6 @@ }
                                 const getTrackerOptions = (_b = (_a = this._pageLeaveTrackerMappers) === null || _a === void 0 ? void 0 : _a[type]) === null || _b === void 0 ? void 0 : _b[tracker.name];
-                                return getTrackerOptions === null || getTrackerOptions === void 0 ? void 0 : getTrackerOptions(payload, (_c = this._lastPageViewEventData) === null || _c === void 0 ? void 0 : _c.pulse);
+                                return getTrackerOptions === null || getTrackerOptions === void 0 ? void 0 : getTrackerOptions(payload, (_c = this._lastPageViewEventData) === null || _c === void 0 ? void 0 : _c[tracker.name]);
                             }
                             catch (err) {
-                                console.error('[pulse] Article leave mapper failed', err);
+                                console.error(`[${tracker.name}] Article leave mapper failed`, err);
                                 return {};
@@ -200,0 +200,0 @@ }

package.json

 {
     "name": "@schibsted/niche-tracking",
-    "version": "4.6.3",
+    "version": "4.6.4",
     "description": "Package containing tracking logic reused between multiple Schibsted niche sites",
@@ -26,3 +26,3 @@ "main": "lib/index.js",
     },
-    "gitHead": "25ccf53563e905bf2948060ed31f8c39ab7306ac"
+    "gitHead": "f82554852d691b1fd6fb7a4566650cdc8239019b"
 }

src/tracker.ts

@@ -72,4 +72,4 @@ import { eventTarget } from '@schibsted/niche-utils';
         pageViewTrackerMappers: Mappers<PageViewEventMapper[PageViewEventType]>;
-        eventTrackerMappers: Mappers<EventTypesMapper[EventType]>;
-        pageLeaveTrackerMappers: Mappers<PageLeaveEventTypeMapper[PageLeaveEventType]>;
+        eventTrackerMappers: EventMappers<EventTypesMapper[EventType]>;
+        pageLeaveTrackerMappers: EventMappers<PageLeaveEventTypeMapper[PageLeaveEventType]>;
     }) {
@@ -114,3 +114,3 @@ this._enabled = enabled;
 
-                                    return getTrackerOptions?.(options, this._lastPageViewEventData?.pulse);
+                                    return getTrackerOptions?.(options, this._lastPageViewEventData?.[tracker.name]);
                                 });
@@ -287,5 +287,5 @@ }
                                 const getTrackerOptions = this._pageLeaveTrackerMappers?.[type]?.[tracker.name];
-                                return getTrackerOptions?.(payload, this._lastPageViewEventData?.pulse);
+                                return getTrackerOptions?.(payload, this._lastPageViewEventData?.[tracker.name]);
                             } catch (err) {
-                                console.error('[pulse] Article leave mapper failed', err);
+                                console.error(`[${tracker.name}] Article leave mapper failed`, err);
 
@@ -292,0 +292,0 @@ return {};

No alert changes

Improved metrics

Total package byte prevSize

69315

increased by0.13%

No dependency changes