@segment/isodate-traverse - npm Package Compare versions

Comparing version 1.0.1 to 1.1.0

HISTORY.md

@@ -0,1 +1,7 @@
+1.1.0 / 2017-09-6
+==================
+
+  * Remove IE 7/8 from circle
+  * Fix array detection
+
 1.0.1 / 2016-05-12
@@ -2,0 +8,0 @@ ==================

karma.conf.ci.js

@@ -0,6 +1,5 @@
+/* eslint-env node */
 'use strict';
 
-if (!process.env.SAUCE_USERNAME || !process.env.SAUCE_ACCESS_KEY) {
-  throw new Error('SAUCE_USERNAME and SAUCE_ACCESS_KEY environment variables are required but are missing');
-}
+var baseConfig = require('./karma.conf');
 
@@ -37,12 +36,2 @@ var customLaunchers = {
   },
-  sl_ie_7: {
-    base: 'SauceLabs',
-    browserName: 'internet explorer',
-    version: '7'
-  },
-  sl_ie_8: {
-    base: 'SauceLabs',
-    browserName: 'internet explorer',
-    version: '8'
-  },
   sl_ie_9: {
@@ -69,20 +58,26 @@ base: 'SauceLabs',
 
-module.exports = {
-  concurrency: 1,
+module.exports = function(config) {
+  baseConfig(config);
 
-  singleRun: true,
+  if (!process.env.SAUCE_USERNAME || !process.env.SAUCE_ACCESS_KEY) {
+    throw new Error('SAUCE_USERNAME and SAUCE_ACCESS_KEY environment variables are required but are missing');
+  }
 
-  browsers: ['PhantomJS'].concat(Object.keys(customLaunchers)),
+  config.set({
+    singleRun: true,
 
-  customLaunchers: customLaunchers,
+    browsers: ['PhantomJS'].concat(Object.keys(customLaunchers)),
 
-  sauceLabs: {
-    testName: require('./package.json').name
-  },
+    customLaunchers: customLaunchers,
 
-  coverageReporter: {
-    reporters: [
-      { type: 'lcov' }
-    ]
-  }
+    sauceLabs: {
+      testName: require('./package.json').name
+    },
+
+    coverageReporter: {
+      reporters: [
+        { type: 'lcov' }
+      ]
+    }
+  });
 };

karma.conf.js

@@ -0,7 +1,8 @@
+/* eslint-env node */
 'use strict';
 
 module.exports = function(config) {
-  var baseConfig = {
+  config.set({
     files: [
-      'test/**/*.js'
+      'test/**/*.test.js'
     ],
@@ -16,6 +17,11 @@
     preprocessors: {
-      'lib/**/*.js': 'browserify',
       'test/**/*.js': 'browserify'
     },
 
+    client: {
+      mocha: {
+        grep: process.env.GREP
+      }
+    },
+
     browserify: {
@@ -42,9 +48,3 @@ debug: true,
     }
-  };
-
-  if (process.env.CI) {
-    Object.assign(baseConfig, require('./karma.conf.ci'));
-  }
-
-  config.set(baseConfig);
+  });
 };

lib/index.js

@@ -38,2 +38,7 @@ 'use strict';
 function object(obj, strict) {
+  // 'each' utility uses obj.length to check whether the obj is array. To avoid incorrect classification, wrap call to 'each' with rename of obj.length
+  if (obj.length && typeof obj.length === 'number' && !(obj.length - 1 in obj)) { // cross browser compatible way of checking has length and is not array
+    obj.lengthNonArray = obj.length;
+    delete obj.length;
+  }
   each(obj, function(key, val) {
@@ -46,2 +51,7 @@ if (isodate.is(val, strict)) {
   });
+  // restore obj.length if it was renamed
+  if (obj.lengthNonArray) {
+    obj.length = obj.lengthNonArray;
+    delete obj.lengthNonArray;
+  }
   return obj;
@@ -48,0 +58,0 @@ }

package.json

 {
   "name": "@segment/isodate-traverse",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "description": "Traverse an object and convert all ISO strings into Dates.",
@@ -33,3 +33,3 @@ "keywords": [
   "devDependencies": {
-    "@segment/eslint-config": "^3.0.0",
+    "@segment/eslint-config": "^3.1.1",
     "browserify": "^13.0.0",
@@ -39,2 +39,4 @@ "browserify-istanbul": "^2.0.0",
     "eslint": "^2.9.0",
+    "eslint-plugin-mocha": "^2.2.0",
+    "eslint-plugin-require-path-exists": "^1.1.5",
     "istanbul": "^0.4.3",
@@ -41,0 +43,0 @@ "karma": "^0.13.22",

README.md

 # isodate-traverse
 
-[![CircleCI](https://img.shields.io/circleci/project/segmentio/isodate-traverse/master.svg?maxAge=2592000)](https://circleci.com/gh/segmentio/isodate-traverse)
+[![CircleCI](https://circleci.com/gh/segmentio/isodate-traverse.svg?style=shield&circle-token=b57033c1550ba25dffa360fc7e11a3f82e0f9781)](https://circleci.com/gh/segmentio/isodate-traverse)
 [![Codecov](https://img.shields.io/codecov/c/github/segmentio/isodate-traverse/master.svg?maxAge=2592000)](https://codecov.io/gh/segmentio/isodate-traverse)
@@ -5,0 +5,0 @@

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 3 instances in 1 package

Improved metrics

Total package byte prevSize

13773

increased by12.26%

Lines of code

240

increased by4.35%

Worsened metrics

Dev dependency count

21

increased by10.53%

Number of low supply chain risk alerts

4

increased by33.33%

No dependency changes