@sentry/core - npm Package Compare versions

Comparing version 8.0.0-rc.2 to 8.0.0-rc.3

cjs/fetch.js

@@ -55,17 +55,20 @@ Object.defineProperty(exports, '__esModule', { value: true });
 
-  const span = shouldCreateSpanResult
-    ? trace.startInactiveSpan({
-        name: `${method} ${url}`,
-        attributes: {
-          url,
-          type: 'fetch',
-          'http.method': method,
-          'http.url': fullUrl,
-          'server.address': host,
-          [semanticAttributes.SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: spanOrigin,
-          [semanticAttributes.SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
-        },
-      })
-    : new sentryNonRecordingSpan.SentryNonRecordingSpan();
+  const hasParent = !!spanUtils.getActiveSpan();
 
+  const span =
+    shouldCreateSpanResult && hasParent
+      ? trace.startInactiveSpan({
+          name: `${method} ${url}`,
+          attributes: {
+            url,
+            type: 'fetch',
+            'http.method': method,
+            'http.url': fullUrl,
+            'server.address': host,
+            [semanticAttributes.SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: spanOrigin,
+            [semanticAttributes.SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
+          },
+        })
+      : new sentryNonRecordingSpan.SentryNonRecordingSpan();
+
   handlerData.fetchData.__span = span.spanContext().spanId;
@@ -88,5 +91,6 @@ spans[span.spanContext().spanId] = span;
       options,
-      // If performance is disabled (TWP), we do not want to use the span as base for the trace headers,
+      // If performance is disabled (TWP) or there's no active root span (pageload/navigation/interaction),
+      // we do not want to use the span as base for the trace headers,
       // which means that the headers will be generated from the scope and the sampling decision is deferred
-      hasTracingEnabled.hasTracingEnabled() ? span : undefined,
+      hasTracingEnabled.hasTracingEnabled() && hasParent ? span : undefined,
     );
@@ -93,0 +97,0 @@ }

cjs/version.js

 Object.defineProperty(exports, '__esModule', { value: true });
 
-const SDK_VERSION = '8.0.0-rc.2';
+const SDK_VERSION = '8.0.0-rc.3';
 
 exports.SDK_VERSION = SDK_VERSION;
 //# sourceMappingURL=version.js.map

esm/fetch.js

@@ -7,3 +7,3 @@ import { parseUrl, generateSentryTraceHeader, dynamicSamplingContextToSentryBaggageHeader, isInstanceOf, BAGGAGE_HEADER_NAME } from '@sentry/utils';
 import { hasTracingEnabled } from './utils/hasTracingEnabled.js';
-import { spanToTraceHeader } from './utils/spanUtils.js';
+import { getActiveSpan, spanToTraceHeader } from './utils/spanUtils.js';
 import { SentryNonRecordingSpan } from './tracing/sentryNonRecordingSpan.js';
@@ -54,17 +54,20 @@ import { setHttpStatus, SPAN_STATUS_ERROR } from './tracing/spanstatus.js';
 
-  const span = shouldCreateSpanResult
-    ? startInactiveSpan({
-        name: `${method} ${url}`,
-        attributes: {
-          url,
-          type: 'fetch',
-          'http.method': method,
-          'http.url': fullUrl,
-          'server.address': host,
-          [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: spanOrigin,
-          [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
-        },
-      })
-    : new SentryNonRecordingSpan();
+  const hasParent = !!getActiveSpan();
 
+  const span =
+    shouldCreateSpanResult && hasParent
+      ? startInactiveSpan({
+          name: `${method} ${url}`,
+          attributes: {
+            url,
+            type: 'fetch',
+            'http.method': method,
+            'http.url': fullUrl,
+            'server.address': host,
+            [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: spanOrigin,
+            [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.client',
+          },
+        })
+      : new SentryNonRecordingSpan();
+
   handlerData.fetchData.__span = span.spanContext().spanId;
@@ -87,5 +90,6 @@ spans[span.spanContext().spanId] = span;
       options,
-      // If performance is disabled (TWP), we do not want to use the span as base for the trace headers,
+      // If performance is disabled (TWP) or there's no active root span (pageload/navigation/interaction),
+      // we do not want to use the span as base for the trace headers,
       // which means that the headers will be generated from the scope and the sampling decision is deferred
-      hasTracingEnabled() ? span : undefined,
+      hasTracingEnabled() && hasParent ? span : undefined,
     );
@@ -92,0 +96,0 @@ }

esm/version.js

@@ -1,4 +0,4 @@
-const SDK_VERSION = '8.0.0-rc.2';
+const SDK_VERSION = '8.0.0-rc.3';
 
 export { SDK_VERSION };
 //# sourceMappingURL=version.js.map

package.json

 {
   "name": "@sentry/core",
-  "version": "8.0.0-rc.2",
+  "version": "8.0.0-rc.3",
   "description": "Base implementation for all Sentry JavaScript SDKs",
@@ -45,4 +45,4 @@ "repository": "git://github.com/getsentry/sentry-javascript.git",
   "dependencies": {
-    "@sentry/types": "8.0.0-rc.2",
-    "@sentry/utils": "8.0.0-rc.2"
+    "@sentry/types": "8.0.0-rc.3",
+    "@sentry/utils": "8.0.0-rc.3"
   },
@@ -49,0 +49,0 @@ "madge": {

types-ts3.8/version.d.ts

@@ -1,2 +0,2 @@
-export declare const SDK_VERSION = "8.0.0-rc.2";
+export declare const SDK_VERSION = "8.0.0-rc.3";
 //# sourceMappingURL=version.d.ts.map

types/version.d.ts

@@ -1,2 +0,2 @@
-export declare const SDK_VERSION = "8.0.0-rc.2";
+export declare const SDK_VERSION = "8.0.0-rc.3";
 //# sourceMappingURL=version.d.ts.map

No alert changes

Improved metrics

Total package byte prevSize

1780017

increased by0.05%

Lines of code

19463

increased by0.03%

Dependency changes

• + Added@sentry/types@8.0.0-rc.3(transitive)

• + Added@sentry/utils@8.0.0-rc.3(transitive)

• - Removed@sentry/types@8.0.0-rc.2(transitive)

• - Removed@sentry/utils@8.0.0-rc.2(transitive)

• Updated@sentry/types@8.0.0-rc.3

• Updated@sentry/utils@8.0.0-rc.3