@slack/client - npm Package Compare versions

Comparing version 3.2.1 to 3.3.0

CHANGELOG.md

@@ -0,1 +1,6 @@
+### v3.3.0 (2016-05-24)
+
+  * Creates a memory data store by default if an undefined, but not false|null value is passed for `opts.dataStore`
+  * Aliases the retry policies to be human readable
+ 
 ### v3.2.1 (2016-05-24)
@@ -2,0 +7,0 @@

lib/clients/client.js

@@ -14,6 +14,7 @@ /**
 var SlackAPIError = require('./errors').SlackAPIError;
+var callTransport = require('./transports/call-transport');
 var getLogger = require('../helpers').getLogger;
 var helpers = require('./helpers');
 var requestsTransport = require('./transports/request').requestTransport;
-var callTransport = require('./transports/call-transport');
+var retryPolicies = require('./retry-policies');
 
@@ -58,6 +59,3 @@
    */
-  this.retryConfig = clientOpts.retryConfig || {
-    retries: 5,
-    factor: 3.9
-  };
+  this.retryConfig = clientOpts.retryConfig || retryPolicies.FIVE_RETRIES_IN_FIVE_MINUTES;
 
@@ -64,0 +62,0 @@ /**

lib/clients/rtm/client.js

@@ -31,2 +31,4 @@ /**
 var BaseAPIClient = require('../client');
+var DataStore = require('../../data-store/data-store');
+var MemoryDataStore = require('../../data-store/memory-data-store');
 var RtmFacet = require('../web/facets').RtmFacet;
@@ -45,2 +47,3 @@ var SlackRTMSendError = require('../errors').SlackRTMSendError;
  * @param {object} opts.dataStore A store to cache Slack info, e.g. channels, users etc. in.
+ *     If you don't want a store, pass false or null as the value for this.
  * @param {boolean} opts.autoReconnect Whether or not to automatically reconnect when the connection
@@ -104,4 +107,9 @@ *     closes.
 
-  if (!isUndefined(clientOpts.dataStore)) {
+  if (clientOpts.dataStore instanceof DataStore) {
     this.registerDataStore(clientOpts.dataStore);
+  } else {
+    // Default to using the memory data store if the user didn't set anything here
+    if (isUndefined(clientOpts.dataStore)) {
+      this.registerDataStore(new MemoryDataStore());
+    }
   }
@@ -108,0 +116,0 @@

package.json

 {
   "name": "@slack/client",
-  "version": "3.2.1",
+  "version": "3.3.0",
   "description": "A library for creating a Slack client",
@@ -34,3 +34,3 @@ "main": "./index",
     "request": "^2.64.0",
-    "retry": "^0.8.0",
+    "retry": "^0.9.0",
     "url-join": "0.0.1",
@@ -37,0 +37,0 @@ "winston": "^2.1.1",

test/clients/web/client.js

@@ -9,2 +9,3 @@ var expect = require('chai').expect;
 var WebAPIClient = require('../../../lib/clients/web/client');
+var retryPolicies = require('../../../lib/clients/retry-policies');
 
@@ -90,6 +91,3 @@
       client = new WebAPIClient('test-token', {
-        retryConfig: {
-          minTimeout: 0,
-          maxTimeout: 1
-        }
+        retryConfig: retryPolicies.TEST_RETRY_POLICY
       });
@@ -96,0 +94,0 @@ sinon.spy(client, 'transport');

No alert changes

Improved metrics

Total package byte prevSize

255511

increased by0.41%

Number of package files

104

increased by0.97%

Lines of code

6561

increased by0.28%

Dependency changes

• + Addedretry@0.9.0(transitive)

• - Removedretry@0.8.0(transitive)

• Updatedretry@^0.9.0