@soundworks/core - npm Package Compare versions

Comparing version 4.0.0-alpha.23 to 4.0.0-alpha.24

CHANGELOG.md

@@ -0,1 +1,5 @@
+## v4.0.0-alpha.24 - 24/05/2025
+
+- Fix: unexpected behavior with new `serverAddress` behavior on browser clients and self-signed certificates
+
 ## v4.0.0-alpha.23 - 24/05/2025
@@ -2,0 +6,0 @@

package.json

 {
   "name": "@soundworks/core",
-  "version": "4.0.0-alpha.23",
+  "version": "4.0.0-alpha.24",
   "description": "Open-source creative coding framework for distributed applications based on Web technologies",
@@ -5,0 +5,0 @@ "authors": [

src/client/Socket.js

@@ -64,2 +64,3 @@ import { isBrowser } from '@ircam/sc-utils';
     if (isBrowser()) {
+      const hostname = window.location.hostname;
       // if a server address is given in config, use it, else fallback to URL hostname
@@ -69,5 +70,18 @@ if (config.env.serverAddress !== '') {
       } else {
+        serverAddress = hostname;
+      }
+
+      // when in https with self-signed certificates, we don't want to use
+      // the serverAddress defined in config as the socket would be blocked, so we
+      // just override serverAddress with hostname in this case
+      const localhosts = ['127.0.0.1', 'localhost'];
+
+      if (config.env.useHttps && localhosts.includes(hostname)) {
         serverAddress = window.location.hostname;
       }
 
+      if (config.env.useHttps && window.location.hostname !== serverAddress) {
+        console.warn(`The WebSocket will try to connect at ${serverAddress} as defined in environment configuration while the page is accessed from ${hostname}. If you run the application with self-signed certificates, this can lead to socket errors as the certificate may not have been accepted for ${serverAddress}. In such case you should rather access the page from ${serverAddress}.`);
+      }
+
       webSocketOptions = [];
@@ -160,2 +174,3 @@ } else {
                 logger.log('[soundworks.Socket] Connection refused, waiting for the server to start');
+                console.log(e.error);
                 connectionRefusedLogged = true;
@@ -162,0 +177,0 @@ }

src/common/version.js

 // [WARNING] This file is generated, do not edit
-export default '4.0.0-alpha.23';
+export default '4.0.0-alpha.24';

No alert changes

Improved metrics

Total package byte prevSize

424479

increased by0.26%

Lines of code

10757

increased by0.12%

No dependency changes