@syncfusion/ej2-calendars - npm Package Compare versions

Comparing version 16.1.38 to 16.1.42

CHANGELOG.md

@@ -5,2 +5,10 @@ # Changelog
 
+### DateTimePicker
+
+#### Bug Fixes
+
+- `ngOnDestroy` related issues has been fixed.
+
+## 16.1.38 (2018-05-02)
+
 ### Common
@@ -7,0 +15,0 @@

dist/global/index.d.ts

 /*!
 *  filename: index.d.ts
-*  version : 16.1.38
+*  version : 16.1.42
 *  Copyright Syncfusion Inc. 2001 - 2018. All rights reserved.
@@ -5,0 +5,0 @@ *  Use of this code is subject to the terms of our license.

package.json

 {
   "name": "@syncfusion/ej2-calendars",
-  "version": "16.1.38",
+  "version": "16.1.42",
   "description": "Essential JS 2 Calendar Components",
@@ -12,5 +12,5 @@ "author": "Syncfusion Inc.",
     "@syncfusion/ej2-base": "~16.1.38",
-    "@syncfusion/ej2-popups": "~16.1.37",
-    "@syncfusion/ej2-inputs": "~16.1.38",
-    "@syncfusion/ej2-lists": "~16.1.38",
+    "@syncfusion/ej2-popups": "~16.1.42",
+    "@syncfusion/ej2-inputs": "~16.1.40",
+    "@syncfusion/ej2-lists": "~16.1.42",
     "@syncfusion/ej2-buttons": "~16.1.37"
@@ -17,0 +17,0 @@ },

src/datepicker/datepicker.d.ts

@@ -12,4 +12,4 @@ /// <reference path="../calendar/calendar-model.d.ts" />
  * <input id="datepicker"/>
- * ````
- * ````typescript
+ * ```
+ * ```typescript
  * <script>
@@ -16,0 +16,0 @@ *   var datePickerObject = new DatePicker({ value: new Date() });

src/datepicker/datepicker.js

@@ -620,14 +620,22 @@ var __extends = (this && this.__extends) || (function () {
             };
-            ej2_inputs_1.Input.removeAttributes(ariaAttrs, this.inputElement);
+            if (this.inputElement) {
+                ej2_inputs_1.Input.removeAttributes(ariaAttrs, this.inputElement);
+                ej2_base_1.EventHandler.remove(this.inputElement, 'blur', this.inputBlurHandler);
+                ej2_base_1.EventHandler.remove(this.inputElement, 'focus', this.inputFocusHandler);
+                this.ensureInputAttribute();
+            }
             if (this.isCalendar()) {
-                ej2_base_3.detach(this.popupWrapper);
+                if (this.popupWrapper) {
+                    ej2_base_3.detach(this.popupWrapper);
+                }
                 this.popupObj = this.popupWrapper = null;
                 this.keyboardModule.destroy();
             }
-            ej2_base_1.EventHandler.remove(this.inputElement, 'blur', this.inputBlurHandler);
-            ej2_base_1.EventHandler.remove(this.inputElement, 'focus', this.inputFocusHandler);
-            this.ensureInputAttribute();
             if (this.ngTag === null) {
-                this.inputWrapper.container.insertAdjacentElement('afterend', this.inputElement);
-                ej2_base_3.removeClass([this.inputElement], [INPUTROOT]);
+                if (this.inputElement) {
+                    this.inputWrapper.container.insertAdjacentElement('afterend', this.inputElement);
+                }
+                if (this.inputElement) {
+                    ej2_base_3.removeClass([this.inputElement], [INPUTROOT]);
+                }
                 ej2_base_3.removeClass([this.element], [ROOT]);
@@ -634,0 +642,0 @@ ej2_base_3.detach(this.inputWrapper.container);

src/daterangepicker/daterangepicker-model.d.ts

@@ -15,3 +15,3 @@ import { Property, EventHandler, Internationalization, NotifyPropertyChanges, detach, getUniqueID } from '@syncfusion/ej2-base';import { KeyboardEvents, BaseEventArgs, KeyboardEventArgs, Event, EmitType, L10n, Browser, ChildProperty } from '@syncfusion/ej2-base';import { addClass, createElement, remove, closest, select, prepend, removeClass, attributes, Collection } from '@syncfusion/ej2-base';import { isNullOrUndefined, isUndefined, formatUnit, setValue, rippleEffect, merge, extend } from '@syncfusion/ej2-base';import { CalendarView, Calendar, NavigatedEventArgs, RenderDayCellEventArgs } from '../calendar/calendar';import { Popup } from '@syncfusion/ej2-popups';import { Button } from '@syncfusion/ej2-buttons';import { Input, InputObject, FloatLabelType } from '@syncfusion/ej2-inputs';import { ListBase, cssClass as ListBaseClasses } from '@syncfusion/ej2-lists';
     /**
-     * Defines the start date of the preset range 
+     * Defines the start date of the preset range.
      */
@@ -18,0 +18,0 @@ start?: Date;

src/daterangepicker/daterangepicker.d.ts

@@ -13,3 +13,3 @@ /// <reference path="../calendar/calendar-model.d.ts" />
     /**
-     * Defines the start date of the preset range
+     * Defines the start date of the preset range.
      */
@@ -426,2 +426,3 @@ start: Date;
     private refreshChange();
+    private setDate();
     /**
@@ -428,0 +429,0 @@ * Called internally if any of the property value changed.

src/datetimepicker/datetimepicker.d.ts

@@ -12,4 +12,4 @@ /// <reference path="../datepicker/datepicker-model.d.ts" />
  * <input id="dateTimePicker"/>
- * ````
- * ````typescript
+ * ```
+ * ```typescript
  * <script>
@@ -16,0 +16,0 @@ *   var dateTimePickerObject = new DateTimePicker({ value: new Date() });

src/datetimepicker/datetimepicker.js

@@ -85,6 +85,10 @@ var __extends = (this && this.__extends) || (function () {
             };
-            ej2_inputs_1.Input.removeAttributes(ariaAttribute, this.inputElement);
-            this.inputElement.removeAttribute('aria-placeholder');
+            if (this.inputElement) {
+                ej2_inputs_1.Input.removeAttributes(ariaAttribute, this.inputElement);
+                this.inputElement.removeAttribute('aria-placeholder');
+            }
             if (this.isCalendar()) {
-                ej2_base_2.detach(this.popupWrapper);
+                if (this.popupWrapper) {
+                    ej2_base_2.detach(this.popupWrapper);
+                }
                 this.popupObject = this.popupWrapper = null;
@@ -238,4 +242,6 @@ this.keyboardHandler.destroy();
             ej2_base_1.EventHandler.remove(this.inputWrapper.buttons[0], 'mousedown touchstart', this.dateHandler);
-            ej2_base_1.EventHandler.remove(this.inputElement, 'blur', this.focusOut);
-            ej2_base_1.EventHandler.remove(this.inputElement, 'focus', this.focusIn);
+            if (this.inputElement) {
+                ej2_base_1.EventHandler.remove(this.inputElement, 'blur', this.focusOut);
+                ej2_base_1.EventHandler.remove(this.inputElement, 'focus', this.focusIn);
+            }
             if (this.keyboardHandler) {
@@ -312,6 +318,4 @@ this.keyboardHandler.destroy();
         DateTimePicker.prototype.dateHandler = function (e) {
-            if (this.getModuleName() === 'datetimepicker') {
-                if (e.currentTarget === this.inputWrapper.buttons[0]) {
-                    e.preventDefault();
-                }
+            if (e.currentTarget === this.inputWrapper.buttons[0]) {
+                e.preventDefault();
             }
@@ -818,7 +822,2 @@ if (this.enabled && !this.readonly) {
                             break;
-                        case 'type':
-                            if (this.inputElement.getAttribute(prop) !== 'text') {
-                                this.inputElement.setAttribute('type', 'text');
-                            }
-                            break;
                     }
@@ -825,0 +824,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

16872346

increased by0.02%

Lines of code

196248

increased by0.02%

Dependency changes

• Updated@syncfusion/ej2-inputs@~16.1.40

• Updated@syncfusion/ej2-lists@~16.1.42

• Updated@syncfusion/ej2-popups@~16.1.42