@ui5/builder - npm Package Compare versions

Comparing version 3.0.7 to 3.0.8

CHANGELOG.md

@@ -5,6 +5,13 @@ # Changelog
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v3.0.7...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v3.0.8...HEAD).
 
+<a name="v3.0.8"></a>
+## [v3.0.8] - 2023-07-18
+### Bug Fixes
+- Revert "[INTERNAL] Remove implicit dependencies concept ([#913](https://github.com/SAP/ui5-builder/issues/913))" [`1043714`](https://github.com/SAP/ui5-builder/commit/1043714e3b952a8280f1ff7909f79db3b750eb0c)
+- **generateJsdoc:** Also process resources created by preceeding tasks [`04447bd`](https://github.com/SAP/ui5-builder/commit/04447bdec28b8bf18c24bd53e3fe8be9bdeed6c2)
+
+
 <a name="v3.0.7"></a>
-## [v3.0.7] - 2023-07-12
+## [v3.0.7] - 2023-07-13
 ### Bug Fixes
@@ -813,2 +820,3 @@ - Don't report a missing module that's contained in another bundle ([#915](https://github.com/SAP/ui5-builder/issues/915)) [`8f23f38`](https://github.com/SAP/ui5-builder/commit/8f23f388f6d64f313ae8a89d0fcaf39ba905a70b)
 - Add ability to configure component preloads and custom bundles [`2241e5f`](https://github.com/SAP/ui5-builder/commit/2241e5ff98fd95f1f80cc74959655ae7a9c660e7)
+[v3.0.8]: https://github.com/SAP/ui5-builder/compare/v3.0.7...v3.0.8
 [v3.0.7]: https://github.com/SAP/ui5-builder/compare/v3.0.6...v3.0.7
@@ -815,0 +823,0 @@ [v3.0.6]: https://github.com/SAP/ui5-builder/compare/v3.0.5...v3.0.6

lib/lbt/analyzer/JSModuleAnalyzer.js

@@ -6,2 +6,3 @@ import {Syntax, VisitorKeys} from "../utils/parseUtils.js";
 const ModuleFormat = moduleInfo.Format;
+import {MODULE__JQUERY_SAP_GLOBAL, MODULE__UI5LOADER_AUTOCONFIG} from "../UI5ClientConstants.js";
 import {
@@ -338,2 +339,13 @@ findOwnProperty,
 
+		// depending on the used module APIs, add an implicit dependency to the loader entry module
+		if ( info.format === ModuleFormat.UI5_LEGACY ) {
+			info.addImplicitDependency(MODULE__JQUERY_SAP_GLOBAL);
+		} else if ( info.format === ModuleFormat.UI5_DEFINE ) {
+			// Note: the implicit dependency for sap.ui.define modules points to the standard UI5
+			// loader config module. A more general approach would be to add a dependency to the loader
+			// only, but then standard configuration would be missed by dependency resolution
+			// (to be clarified)
+			info.addImplicitDependency(MODULE__UI5LOADER_AUTOCONFIG);
+		}
+
 		if ( !bIsUi5Module ) {
@@ -340,0 +352,0 @@ // when there are no indicators for module APIs, mark the module as 'raw' module

lib/lbt/analyzer/XMLTemplateAnalyzer.js

@@ -181,2 +181,4 @@
 				if ( isFragment ) {
+					// all fragments implicitly depend on the fragment class
+					this.info.addImplicitDependency(FRAGMENT_MODULE);
 					this._analyzeNode(result);
@@ -198,2 +200,4 @@ } else {
 	_analyzeViewRootNode(node) {
+		this.info.addImplicitDependency(XMLVIEW_MODULE);
+
 		const controllerName = getAttribute(node, XMLVIEW_CONTROLLERNAME_ATTRIBUTE);
@@ -200,0 +204,0 @@ if ( controllerName ) {

lib/lbt/resources/ModuleInfo.js

@@ -10,2 +10,10 @@
 /**
+ * An implicit dependency is also strict, but has not been declared. E.g. each UI5 module depends on
+ * jquery.sap.global.
+ *
+ * @private
+ */
+const IMPLICIT = 1;
+
+/**
  * A conditional dependency has to be resolved only under certain conditions that typically are
@@ -108,3 +116,3 @@ * checked at runtime.
 		// only when the new kind is stronger than the current one.
-		// STRICT is stronger than CONDITIONAL
+		// STRICT is stronger than IMPLICIT, IMPLICIT is stronger than CONDITIONAL
 		if ( dependency &&
@@ -118,2 +126,6 @@ dependency !== this.name &&
 
+	addImplicitDependency(dependency) {
+		this._addDependency(dependency, IMPLICIT);
+	}
+
 	addDependency(dependency, conditional) {
@@ -169,2 +181,6 @@ this._addDependency(dependency, conditional ? CONDITIONAL : STRICT);
 
+	isImplicitDependency(dependency) {
+		return this._dependencies[dependency] === IMPLICIT;
+	}
+
 	get name() {
@@ -171,0 +187,0 @@ return this._name;

lib/lbt/resources/ResourceCollector.js

@@ -127,3 +127,3 @@ import ResourceInfoList from "./ResourceInfoList.js";
 						resourceInfo.condRequired.add(dep);
-					} else {
+					} else if ( !moduleInfo.isImplicitDependency(dep) ) {
 						resourceInfo.required.add(dep);
@@ -162,3 +162,3 @@ }
 									}
-								} else {
+								} else if ( !subModuleInfo.isImplicitDependency(dep) ) {
 									// Move module from condRequired to required
@@ -165,0 +165,0 @@ if (resourceInfo.condRequired.has(dep)) {

lib/tasks/jsdoc/generateJsdoc.js

@@ -157,8 +157,3 @@ import {getLogger} from "@ui5/logger";
 
-		let allResources;
-		if (workspace.byGlobSource) { // API only available on duplex collections
-			allResources = await workspace.byGlobSource(pattern);
-		} else {
-			allResources = await workspace.byGlob(pattern);
-		}
+		const allResources = await workspace.byGlob(pattern);
 
@@ -165,0 +160,0 @@ // write all resources to the tmp folder

package.json

 {
 	"name": "@ui5/builder",
-	"version": "3.0.7",
+	"version": "3.0.8",
 	"description": "UI5 Tooling - Builder",
@@ -41,3 +41,3 @@ "author": {
 		"unit-watch": "rimraf test/tmp && ava --watch",
-		"unit-xunit": "rimraf test/tmp && ava --no-worker-threads --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\" --tap --timeout=1m | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
+		"unit-xunit": "rimraf test/tmp && ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\" --tap --timeout=1m | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
 		"unit-inspect": "cross-env UI5_LOG_LVL=verbose ava debug --break",
@@ -73,3 +73,4 @@ "coverage": "rimraf test/tmp && nyc ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\"",
 			"--no-warnings"
-		]
+		],
+		"workerThreads": false
 	},
@@ -128,3 +129,3 @@ "nyc": {
 		"escope": "^4.0.0",
-		"espree": "^9.6.0",
+		"espree": "^9.6.1",
 		"graceful-fs": "^4.2.11",
@@ -136,3 +137,3 @@ "jsdoc": "^4.0.2",
 		"semver": "^7.5.4",
-		"terser": "^5.18.2",
+		"terser": "^5.19.0",
 		"workerpool": "^6.4.0",
@@ -143,3 +144,3 @@ "xml2js": "^0.6.0"
 		"@istanbuljs/esm-loader-hook": "^0.2.0",
-		"@ui5/project": "^3.4.1",
+		"@ui5/project": "^3.4.2",
 		"ava": "^5.3.1",
@@ -152,6 +153,6 @@ "chai": "^4.3.7",
 		"docdash": "^2.0.1",
-		"eslint": "^8.44.0",
+		"eslint": "^8.45.0",
 		"eslint-config-google": "^0.14.0",
 		"eslint-plugin-ava": "^14.0.0",
-		"eslint-plugin-jsdoc": "^46.4.3",
+		"eslint-plugin-jsdoc": "^46.4.4",
 		"esmock": "^2.3.1",
@@ -158,0 +159,0 @@ "nyc": "^15.1.0",

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Fixed alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Improved metrics

Number of low supply chain risk alerts

7

decreased by-30%

Worsened metrics

Total package byte prevSize

758907

decreased by-4.04%

Lines of code

19096

decreased by-4.72%

Dependency changes

• Updatedespree@^9.6.1

• Updatedterser@^5.19.0