@vaadin/confirm-dialog - npm Package Compare versions

Comparing version 23.0.0-beta5 to 23.0.0-rc1

package.json

 {
   "name": "@vaadin/confirm-dialog",
-  "version": "23.0.0-beta5",
+  "version": "23.0.0-rc1",
   "publishConfig": {
@@ -37,10 +37,10 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/button": "23.0.0-beta5",
-    "@vaadin/component-base": "23.0.0-beta5",
-    "@vaadin/dialog": "23.0.0-beta5",
+    "@vaadin/button": "23.0.0-rc1",
+    "@vaadin/component-base": "23.0.0-rc1",
+    "@vaadin/dialog": "23.0.0-rc1",
     "@vaadin/vaadin-license-checker": "^2.1.0",
-    "@vaadin/vaadin-lumo-styles": "23.0.0-beta5",
-    "@vaadin/vaadin-material-styles": "23.0.0-beta5",
-    "@vaadin/vaadin-overlay": "23.0.0-beta5",
-    "@vaadin/vaadin-themable-mixin": "23.0.0-beta5"
+    "@vaadin/vaadin-lumo-styles": "23.0.0-rc1",
+    "@vaadin/vaadin-material-styles": "23.0.0-rc1",
+    "@vaadin/vaadin-overlay": "23.0.0-rc1",
+    "@vaadin/vaadin-themable-mixin": "23.0.0-rc1"
   },
@@ -52,3 +52,3 @@ "devDependencies": {
   },
-  "gitHead": "4c388aeec6623869c70896c909799804fc95d0f9"
+  "gitHead": "d241fd5b3627efd671e6db25f33f2e69795011d3"
 }

src/vaadin-confirm-dialog.d.ts

@@ -93,2 +93,3 @@ /**
    * Text displayed on confirm-button.
+   * This only affects the default button, custom slotted buttons will not be altered.
    * @attr {string} confirm-text
@@ -100,2 +101,3 @@ */
    * Theme for a confirm-button.
+   * This only affects the default button, custom slotted buttons will not be altered.
    * @attr {string} confirm-theme
@@ -118,2 +120,3 @@ */
    * Text displayed on reject-button.
+   * This only affects the default button, custom slotted buttons will not be altered.
    * @attr {string} reject-text
@@ -125,2 +128,3 @@ */
    * Theme for a reject-button.
+   * This only affects the default button, custom slotted buttons will not be altered.
    * @attr {string} reject-theme
@@ -137,2 +141,3 @@ */
    * Text displayed on cancel-button.
+   * This only affects the default button, custom slotted buttons will not be altered.
    * @attr {string} cancel-text
@@ -144,2 +149,3 @@ */
    * Theme for a cancel-button.
+   * This only affects the default button, custom slotted buttons will not be altered.
    * @attr {string} cancel-theme
@@ -146,0 +152,0 @@ */

src/vaadin-confirm-dialog.js

@@ -134,2 +134,3 @@ /**
        * Text displayed on confirm-button.
+       * This only affects the default button, custom slotted buttons will not be altered.
        * @attr {string} confirm-text
@@ -145,2 +146,3 @@ * @type {string}
        * Theme for a confirm-button.
+       * This only affects the default button, custom slotted buttons will not be altered.
        * @attr {string} confirm-theme
@@ -176,2 +178,3 @@ * @type {string}
        * Text displayed on reject-button.
+       * This only affects the default button, custom slotted buttons will not be altered.
        * @attr {string} reject-text
@@ -187,2 +190,3 @@ * @type {string}
        * Theme for a reject-button.
+       * This only affects the default button, custom slotted buttons will not be altered.
        * @attr {string} reject-theme
@@ -208,2 +212,3 @@ * @type {string}
        * Text displayed on cancel-button.
+       * This only affects the default button, custom slotted buttons will not be altered.
        * @attr {string} cancel-text
@@ -219,2 +224,3 @@ * @type {string}
        * Theme for a cancel-button.
+       * This only affects the default button, custom slotted buttons will not be altered.
        * @attr {string} cancel-theme
@@ -314,2 +320,3 @@ * @type {string}
         button.textContent = this.cancelText;
+        button._isDefaultButton = true;
         return button;
@@ -321,6 +328,9 @@ },
         button.textContent = this.rejectText;
+        button._isDefaultButton = true;
         return button;
       },
       'confirm-button': () => {
-        return document.createElement('vaadin-button');
+        const button = document.createElement('vaadin-button');
+        button._isDefaultButton = true;
+        return button;
       }
@@ -441,4 +451,6 @@ };
     if (button) {
-      button.textContent = cancelText;
-      button.setAttribute('theme', cancelTheme);
+      if (button._isDefaultButton) {
+        button.textContent = cancelText;
+        button.setAttribute('theme', cancelTheme);
+      }
       button.toggleAttribute('hidden', !showCancel);
@@ -450,3 +462,3 @@ }
   __updateConfirmButton(button, confirmText, confirmTheme) {
-    if (button) {
+    if (button && button._isDefaultButton) {
       button.textContent = confirmText;
@@ -476,4 +488,6 @@ button.setAttribute('theme', confirmTheme);
     if (button) {
-      button.textContent = rejectText;
-      button.setAttribute('theme', rejectTheme);
+      if (button._isDefaultButton) {
+        button.textContent = rejectText;
+        button.setAttribute('theme', rejectTheme);
+      }
       button.toggleAttribute('hidden', !showReject);
@@ -480,0 +494,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

47126

increased by2.9%

Lines of code

906

increased by2.26%

Dependency changes

• + Added@vaadin/button@23.0.0-rc1(transitive)

• + Added@vaadin/component-base@23.0.0-rc1(transitive)

• + Added@vaadin/dialog@23.0.0-rc1(transitive)

• + Added@vaadin/icon@23.0.0-rc1(transitive)

• + Added@vaadin/vaadin-lumo-styles@23.0.0-rc1(transitive)

• + Added@vaadin/vaadin-material-styles@23.0.0-rc1(transitive)

• + Added@vaadin/vaadin-overlay@23.0.0-rc1(transitive)

• + Added@vaadin/vaadin-themable-mixin@23.0.0-rc1(transitive)

• - Removed@vaadin/button@23.0.0-beta5(transitive)

• - Removed@vaadin/component-base@23.0.0-beta5(transitive)

• - Removed@vaadin/dialog@23.0.0-beta5(transitive)

• - Removed@vaadin/icon@23.0.0-beta5(transitive)

• - Removed@vaadin/vaadin-lumo-styles@23.0.0-beta5(transitive)

• - Removed@vaadin/vaadin-material-styles@23.0.0-beta5(transitive)

• - Removed@vaadin/vaadin-overlay@23.0.0-beta5(transitive)

• - Removed@vaadin/vaadin-themable-mixin@23.0.0-beta5(transitive)

• Updated@vaadin/button@23.0.0-rc1

• Updated@vaadin/component-base@23.0.0-rc1

• Updated@vaadin/dialog@23.0.0-rc1

• Updated@vaadin/vaadin-lumo-styles@23.0.0-rc1

• Updated@vaadin/vaadin-material-styles@23.0.0-rc1

• Updated@vaadin/vaadin-overlay@23.0.0-rc1

• Updated@vaadin/vaadin-themable-mixin@23.0.0-rc1