@webex/internal-plugin-metrics - npm Package Compare versions

Comparing version 3.0.0-beta.392 to 3.0.0-beta.393

dist/call-diagnostic/call-diagnostic-metrics-latencies.js

@@ -482,2 +482,13 @@ "use strict";
     }
+
+    /**
+     * Total latency for all other app api requests.
+     * Excludes meeting info, because it's measured separately.
+     */
+  }, {
+    key: "getOtherAppApiReqResp",
+    value: function getOtherAppApiReqResp() {
+      var otherAppApiJMT = this.precomputedLatencies.get('internal.other.app.api.time');
+      return otherAppApiJMT > 0 ? Math.floor(otherAppApiJMT) : undefined;
+    }
   }]);
@@ -484,0 +495,0 @@ return CallDiagnosticLatencies;

dist/call-diagnostic/call-diagnostic-metrics.util.js

@@ -229,2 +229,5 @@ "use strict";
       break;
+    case 'client.login.end':
+      joinTimes.otherAppApiReqResp = cdl.getOtherAppApiReqResp();
+      break;
     case 'client.interstitial-window.launched':
@@ -231,0 +234,0 @@ joinTimes.meetingInfoReqResp = cdl.getMeetingInfoReqResp();

dist/metrics.js

@@ -168,3 +168,3 @@ "use strict";
   },
-  version: "3.0.0-beta.392"
+  version: "3.0.0-beta.393"
 });
@@ -171,0 +171,0 @@ var _default = Metrics;

dist/types/call-diagnostic/call-diagnostic-metrics-latencies.d.ts

@@ -208,2 +208,7 @@ import { WebexPlugin } from '@webex/webex-core';
     getVideoJoinRespTxStart(): number;
+    /**
+     * Total latency for all other app api requests.
+     * Excludes meeting info, because it's measured separately.
+     */
+    getOtherAppApiReqResp(): number;
 }

dist/types/call-diagnostic/call-diagnostic-metrics.d.ts

@@ -90,14 +90,8 @@ import { StatelessWebexPlugin } from '@webex/webex-core';
             clientType?: "MEETING_CENTER" | "EVENT_CENTER" | "TRAINING_CENTER" | "TEAMS_CLIENT" | "TEAMS_DEVICE" | "TEAMS_SHARE" | "SIP" | "RECORDING" | "CLOUD_AWARE_SIP" | "TEAMS_WXC_CLIENT" | "WXC_CLIENT" | "WXC_DEVICE" | "WEBEX_JS_SDK" | "VOICEA_CLIENT" | "CISCO_SIP_GW" | "WEBEX_SDK" | "CPAAS_THIRD_PARTY_SDK" | "WXC_THIRD_PARTY" | "WXCC";
-            subClientType?: "TEAMS_DEVICE" | "DESKTOP_APP" | "DESKTOP_APP_VDI" | "DEVICE_CURRENT" | "DEVICE_LEGACY_2020" | "HOLOGRAM_HEADSET_APP" | "HVDI_APP" | "MOBILE_APP" | "MOBILE_NETWORK" | "VDI_APP" | "WEB_APP";
-            clientVersion?: string; /**
-             * Returns the login type of the current user
-             * @returns one of 'login-ci','unverified-guest', null
-             */
+            subClientType?: "TEAMS_DEVICE" | "DESKTOP_APP" | "DESKTOP_APP_VDI" | "DEVICE_CURRENT" | "DEVICE_LEGACY_2020" | "HOLOGRAM_HEADSET_APP" | "HVDI_APP" | "MIXED" | "MOBILE_APP" | "MOBILE_NETWORK" | "PAGE" | "VDI_APP" | "WEB_APP";
+            clientVersion?: string;
             clientVersionStatus?: "CURRENT" | "LEGACY" | "UNSUPPORTED";
             localClientVersion?: string;
             modelNumber?: string;
-            joinFirstUpdateLater?: "ep-enabled" | "sp-enabled" | "not-enabled"; /**
-             * Returns if the meeting has converged architecture enabled
-             * @param options.meetingId
-             */
+            joinFirstUpdateLater?: "ep-enabled" | "sp-enabled" | "not-enabled";
             standbyUsed?: boolean;
@@ -104,0 +98,0 @@ prefetchDocShowUsed?: boolean;

dist/types/index.d.ts

@@ -8,3 +8,3 @@ /*!
 import * as Utils from './utils';
-import { ClientEvent, ClientEventLeaveReason, SubmitBehavioralEvent, SubmitClientEvent, SubmitInternalEvent, SubmitOperationalEvent, SubmitMQE } from './metrics.types';
+import { ClientEvent, ClientEventLeaveReason, SubmitBehavioralEvent, SubmitClientEvent, SubmitInternalEvent, SubmitOperationalEvent, SubmitMQE, PreComputedLatencies } from './metrics.types';
 import * as CALL_DIAGNOSTIC_CONFIG from './call-diagnostic/config';
@@ -16,2 +16,2 @@ import * as CallDiagnosticUtils from './call-diagnostic/call-diagnostic-metrics.util';
 export { config, CALL_DIAGNOSTIC_CONFIG, NewMetrics, Utils, CallDiagnosticUtils, CallDiagnosticLatencies, CallDiagnosticMetrics, };
-export type { ClientEvent, ClientEventLeaveReason, SubmitBehavioralEvent, SubmitClientEvent, SubmitInternalEvent, SubmitMQE, SubmitOperationalEvent, };
+export type { ClientEvent, ClientEventLeaveReason, SubmitBehavioralEvent, SubmitClientEvent, SubmitInternalEvent, SubmitMQE, SubmitOperationalEvent, PreComputedLatencies, };

dist/types/metrics.types.d.ts

@@ -105,2 +105,2 @@ import { ClientEvent as RawClientEvent, Event as RawEvent, MediaQualityEvent as RawMediaQualityEvent } from '@webex/event-dictionary-ts';
 }) => Promise<any>;
-export type PreComputedLatencies = 'internal.client.pageJMT' | 'internal.download.time' | 'internal.click.to.interstitial' | 'internal.call.init.join.req';
+export type PreComputedLatencies = 'internal.client.pageJMT' | 'internal.download.time' | 'internal.click.to.interstitial' | 'internal.call.init.join.req' | 'internal.other.app.api.time';

package.json

 {
   "name": "@webex/internal-plugin-metrics",
-  "version": "3.0.0-beta.392",
+  "version": "3.0.0-beta.393",
   "description": "",
@@ -31,10 +31,10 @@ "license": "MIT",
   "dependencies": {
-    "@webex/common": "3.0.0-beta.392",
-    "@webex/common-timers": "3.0.0-beta.392",
-    "@webex/event-dictionary-ts": "^1.0.1329",
-    "@webex/internal-plugin-device": "3.0.0-beta.392",
-    "@webex/internal-plugin-metrics": "3.0.0-beta.392",
-    "@webex/test-helper-chai": "3.0.0-beta.392",
-    "@webex/test-helper-mock-webex": "3.0.0-beta.392",
-    "@webex/webex-core": "3.0.0-beta.392",
+    "@webex/common": "3.0.0-beta.393",
+    "@webex/common-timers": "3.0.0-beta.393",
+    "@webex/event-dictionary-ts": "^1.0.1387",
+    "@webex/internal-plugin-device": "3.0.0-beta.393",
+    "@webex/internal-plugin-metrics": "3.0.0-beta.393",
+    "@webex/test-helper-chai": "3.0.0-beta.393",
+    "@webex/test-helper-mock-webex": "3.0.0-beta.393",
+    "@webex/webex-core": "3.0.0-beta.393",
     "ip-anonymize": "^0.1.0",
@@ -41,0 +41,0 @@ "lodash": "^4.17.21",

src/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -447,2 +447,12 @@ /* eslint-disable class-methods-use-this */
   }
+
+  /**
+   * Total latency for all other app api requests.
+   * Excludes meeting info, because it's measured separately.
+   */
+  public getOtherAppApiReqResp() {
+    const otherAppApiJMT = this.precomputedLatencies.get('internal.other.app.api.time');
+
+    return otherAppApiJMT > 0 ? Math.floor(otherAppApiJMT) : undefined;
+  }
 }

src/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -247,2 +247,5 @@ /* eslint-disable valid-jsdoc */
       break;
+    case 'client.login.end':
+      joinTimes.otherAppApiReqResp = cdl.getOtherAppApiReqResp();
+      break;
     case 'client.interstitial-window.launched':
@@ -249,0 +252,0 @@ joinTimes.meetingInfoReqResp = cdl.getMeetingInfoReqResp();

src/index.ts

@@ -21,2 +21,3 @@ /*!
   SubmitMQE,
+  PreComputedLatencies,
 } from './metrics.types';
@@ -55,2 +56,3 @@ import * as CALL_DIAGNOSTIC_CONFIG from './call-diagnostic/config';
   SubmitOperationalEvent,
+  PreComputedLatencies,
 };

src/metrics.types.ts

@@ -168,2 +168,3 @@ import {
   | 'internal.click.to.interstitial'
-  | 'internal.call.init.join.req';
+  | 'internal.call.init.join.req'
+  | 'internal.other.app.api.time';

test/unit/spec/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -614,3 +614,27 @@ import {assert} from '@webex/test-helper-chai';
     });
+
+    describe('getOtherAppApiReqResp', () => {
+      it('returns undefined when no precomputed value available', () => {
+        assert.deepEqual(cdl.getOtherAppApiReqResp(), undefined);
+      });
+
+      it('returns undefined if it is less than 0', () => {
+        cdl.saveLatency('internal.other.app.api.time', 0);
+
+        assert.deepEqual(cdl.getOtherAppApiReqResp(), undefined);
+      });
+
+      it('returns the correct value', () => {
+        cdl.saveLatency('internal.other.app.api.time', 123);
+
+        assert.deepEqual(cdl.getOtherAppApiReqResp(), 123);
+      });
+
+      it('returns the correct whole number', () => {
+        cdl.saveLatency('internal.other.app.api.time', 321.44);
+
+        assert.deepEqual(cdl.getOtherAppApiReqResp(), 321);
+      });
+    });
   });
 });

test/unit/spec/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -305,2 +305,7 @@ import {assert} from '@webex/test-helper-chai';
       ['client.exit.app', {}],
+      ['client.login.end', {
+        joinTimes: {
+          otherAppApiReqResp: undefined,
+        }
+      }],
       ['client.webexapp.launched', {
@@ -307,0 +312,0 @@ joinTimes: {

No alert changes

Improved metrics

Total package byte prevSize

636657

increased by0.44%

Lines of code

12293

increased by0.39%

Dependency changes

• + Added@webex/common@3.0.0-beta.393(transitive)

• + Added@webex/common-timers@3.0.0-beta.393(transitive)

• + Added@webex/http-core@3.0.0-beta.393(transitive)

• + Added@webex/internal-plugin-device@3.0.0-beta.393(transitive)

• + Added@webex/plugin-logger@3.0.0-beta.393(transitive)

• + Added@webex/storage-adapter-spec@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-chai@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-file@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-make-local-url@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-mocha@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-mock-webex@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-retry@3.0.0-beta.393(transitive)

• + Added@webex/test-helper-test-users@3.0.0-beta.393(transitive)

• + Added@webex/test-users@3.0.0-beta.393(transitive)

• + Added@webex/webex-core@3.0.0-beta.393(transitive)

• - Removed@webex/common@3.0.0-beta.392(transitive)

• - Removed@webex/common-timers@3.0.0-beta.392(transitive)

• - Removed@webex/http-core@3.0.0-beta.392(transitive)

• - Removed@webex/internal-plugin-device@3.0.0-beta.392(transitive)

• - Removed@webex/plugin-logger@3.0.0-beta.392(transitive)

• - Removed@webex/storage-adapter-spec@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-chai@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-file@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-make-local-url@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-mocha@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-mock-webex@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-retry@3.0.0-beta.392(transitive)

• - Removed@webex/test-helper-test-users@3.0.0-beta.392(transitive)

• - Removed@webex/test-users@3.0.0-beta.392(transitive)

• - Removed@webex/webex-core@3.0.0-beta.392(transitive)

• Updated@webex/common@3.0.0-beta.393

• Updated@webex/common-timers@3.0.0-beta.393

• Updated@webex/event-dictionary-ts@^1.0.1387

• Updated@webex/internal-plugin-device@3.0.0-beta.393

• Updated@webex/internal-plugin-metrics@3.0.0-beta.393

• Updated@webex/test-helper-chai@3.0.0-beta.393

• Updated@webex/test-helper-mock-webex@3.0.0-beta.393

• Updated@webex/webex-core@3.0.0-beta.393