abstract-command - npm Package Compare versions

Comparing version 1.1.0 to 2.0.0

History.md

 
+2.0.0 / 2014-11-21
+==================
+
+  * test: update tests for new queryState and queryEnabled default return values
+  * index: add default return values for `queryState()` and `queryEnabled()`
+
 1.1.0 / 2014-11-21
@@ -3,0 +9,0 @@ ==================

index.d.ts

@@ -19,5 +19,5 @@ /// <reference path="types.d.ts" />
     protected _execute(range: Range, value?: any): void;
-    protected _queryEnabled(range: Range): void;
-    protected _queryState(range: Range): void;
+    protected _queryEnabled(range: Range): boolean;
+    protected _queryState(range: Range): boolean;
 }
 export = AbstractCommand;

index.js

@@ -54,6 +54,6 @@ /// <reference path='types.d.ts' />
     AbstractCommand.prototype._queryEnabled = function (range) {
-        throw new Error('implement _queryEnabled()!');
+        return !!range;
     };
     AbstractCommand.prototype._queryState = function (range) {
-        throw new Error('implement _queryState()!');
+        return false;
     };
@@ -60,0 +60,0 @@ return AbstractCommand;

index.ts

@@ -66,8 +66,8 @@ /// <reference path='types.d.ts' />
 
-  protected _queryEnabled(range: Range): void {
-    throw new Error('implement _queryEnabled()!');
+  protected _queryEnabled(range: Range): boolean {
+    return !! range;
   }
 
-  protected _queryState(range: Range): void {
-    throw new Error('implement _queryState()!');
+  protected _queryState(range: Range): boolean {
+    return false;
   }
@@ -74,0 +74,0 @@ }

package.json

 {
   "name": "abstract-command",
-  "version": "1.1.0",
+  "version": "2.0.0",
   "description": "Abstract `Command` base class to make implementing custom commands easier",
@@ -5,0 +5,0 @@ "main": "index.js",

test/test.js

@@ -54,3 +54,3 @@
 
-      it('should throw an Error', function () {
+      it('should return `false`', function () {
         div = document.createElement('div');
@@ -73,5 +73,3 @@ div.innerHTML = '<p>hello</p><p>world!</p>';
 
-        assert.throws(function () {
-          c.queryState();
-        }, /implement/);
+        assert.equal(false, c.queryState());
       });
@@ -83,3 +81,3 @@
 
-      it('should throw an Error', function () {
+      it('should return `true` with a Selection', function () {
         div = document.createElement('div');
@@ -102,7 +100,15 @@ div.innerHTML = '<p>hello</p><p>world!</p>';
 
-        assert.throws(function () {
-          c.queryEnabled();
-        }, /implement/);
+        assert.equal(true, c.queryEnabled());
       });
 
+      it('should return `false` without a Selection', function () {
+
+        var sel = window.getSelection();
+        sel.removeAllRanges();
+
+        var c = new AbstractCommand();
+
+        assert.equal(false, c.queryEnabled());
+      });
+
     });
@@ -109,0 +115,0 @@

No alert changes

Improved metrics

Total package byte prevSize

10469

increased by2.53%

Lines of code

261

increased by0.77%

No dependency changes