amqper - npm Package Compare versions

Comparing version 0.5.0 to 0.5.1

lib/client.js

@@ -122,16 +122,18 @@ "use strict";
     }
-    this.closing = true;
-    const that = this;
-    return close_connection(this.conn).then(function () {
-      return PromiseA.all(PromiseA.map(that.routers, function (router) {
-        return router.connection.then(function (conn) {
-          if (conn === that.conn) return;
-          return close_connection(conn);
-        });
-      }));
-    }).then(function () {
-      that.routers = [];
-      that.closed = true;
-      that.closing = false;
-      if (cb) cb();
+    return this.$promise.finally(() => {
+      this.closing = true;
+      const that = this;
+      return close_connection(this.conn).then(function () {
+        return PromiseA.all(PromiseA.map(that.routers, function (router) {
+          return router.connection.then(function (conn) {
+            if (conn === that.conn) return;
+            return close_connection(conn);
+          });
+        }));
+      }).then(function () {
+        that.routers = [];
+        that.closed = true;
+        that.closing = false;
+        if (cb) cb();
+      });
     });
@@ -138,0 +140,0 @@ };

package.json

 {
   "name": "amqper",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "A simple and elegant AMQP client for node based on amqplib.",
@@ -21,3 +21,3 @@ "homepage": "https://github.com/taoyuan/amqper",
     "debug": "^3.1.0",
-    "depd": "^1.1.1",
+    "depd": "^1.1.2",
     "houkou": "^0.2.2",
@@ -28,13 +28,13 @@ "lodash": "^4.17.4",
   "devDependencies": {
-    "@types/chai": "^4.0.10",
+    "@types/chai": "^4.1.0",
     "chai": "^4.1.2",
     "gulp": "^3.9.1",
     "gulp-exclude-gitignore": "^1.2.0",
-    "gulp-istanbul": "^1.1.2",
-    "gulp-jshint": "^2.0.4",
-    "gulp-mocha": "^4.3.1",
+    "gulp-istanbul": "^1.1.3",
+    "gulp-jshint": "^2.1.0",
+    "gulp-mocha": "^5.0.0",
     "gulp-nsp": "^2.4.2",
-    "gulp-plumber": "^1.1.0",
+    "gulp-plumber": "^1.2.0",
     "jshint-stylish": "^2.2.1",
-    "mocha": "^4.0.1",
+    "mocha": "^4.1.0",
     "uuid": "^3.1.0"
@@ -41,0 +41,0 @@ },

test/amqper.test.js

@@ -20,8 +20,12 @@ 'use strict';
   describe('connect', function () {
-    it('should connect to rabbit server', function (done) {
+    it('should connect to rabbit server', function () {
       const client = amqper.connect('amqp://guest:guest@localhost:5672');
+      let asserted = false;
       client.$promise.then(function (conn) {
         assert.ok(conn);
-        client.close(done);
+        asserted = true;
       });
+      return client.close().then(() => {
+        assert.ok(asserted);
+      });
     });
@@ -28,0 +32,0 @@ });

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

84488

increased by0.18%

Lines of code

495

increased by1.23%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

Dependency changes

• Updateddepd@^1.1.2