analytics-node - npm Package Compare versions

Comparing version 2.0.1 to 2.0.2

History.md

 
+2.0.2 / 2016-03-03
+==================
+
+  * updating travis.yml
+  * increase messageId entropy, and include one id per message
+
 2.0.1 / 2015-12-11
@@ -3,0 +9,0 @@ ==================

lib/index.js

@@ -9,3 +9,3 @@ var assert = require('assert');
 var join = require('join-component');
-var uid = require('uid');
+var uid = require('crypto-token');
 var version = require('../package.json').version;
@@ -140,4 +140,3 @@ var extend = require('lodash').extend;
     timestamp: new Date(),
-    sentAt: new Date(),
-    messageId: uid(8)
+    sentAt: new Date()
   };
@@ -176,2 +175,3 @@
   if (!message.timestamp) message.timestamp = new Date();
+  if (!message.messageId) message.messageId = 'node-' + uid(32);
 
@@ -178,0 +178,0 @@ debug('%s: %o', type, message);

package.json

 {
   "name": "analytics-node",
   "repository": "git://github.com/segmentio/analytics-node",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "The hassle-free way to integrate analytics into any node application.",
@@ -22,2 +22,4 @@ "keywords": [
     "component-type": "~1.0.0",
+    "crypto-token": "^1.0.1",
+    "debug": "^2.2.0",
     "join-component": "~1.0.0",
@@ -27,5 +29,3 @@ "lodash": "~2.4.1",
     "superagent-proxy": "^1.0.0",
-    "superagent-retry": "^0.5.1",
-    "debug": "^2.2.0",
-    "uid": "0.0.2"
+    "superagent-retry": "^0.5.1"
   },
@@ -32,0 +32,0 @@ "devDependencies": {

test/index.js

@@ -8,2 +8,3 @@ var assert = require('assert');
 var noop = function(){};
+var id = 'id';
 var context = {
@@ -76,6 +77,10 @@ library: {
 
-      assert.deepEqual(a.queue[0], {
-        message: { type: 'type', timestamp: date, context: context },
-        callback: noop
-      });
+      var msg = a.queue[0].message;
+      var callback = a.queue[0].callback;
+
+      assert.equal(callback, noop);
+      assert.equal(msg.type, 'type');
+      assert.deepEqual(msg.timestamp, date);
+      assert.deepEqual(msg.context, context);
+      assert(msg.messageId);
     });
@@ -126,2 +131,9 @@
     });
+
+    it('should add a message id', function(){
+      a.enqueue('type', { event: 'test' }, noop);
+      var msg = a.queue[0].message;
+      assert(msg.messageId);
+      assert(/node-[a-zA-Z0-9]{32}/.test(msg.messageId));
+    })
   });
@@ -142,3 +154,2 @@
         assert(data.sentAt instanceof Date);
-        assert(data.messageId && /[a-zA-Z0-9]{8}/.test(data.messageId));
         done();
@@ -161,3 +172,3 @@ });
       var date = new Date();
-      a.identify({ userId: 'id', timestamp: date });
+      a.identify({ userId: 'id', timestamp: date, messageId: id });
       assert.deepEqual(a.queue[0].message, {
@@ -167,3 +178,4 @@ type: 'identify',
         timestamp: date,
-        context: context
+        context: context,
+        messageId: id
       });
@@ -186,3 +198,3 @@ });
       var date = new Date();
-      a.group({ groupId: 'group', userId: 'user', timestamp: date });
+      a.group({ groupId: 'group', userId: 'user', timestamp: date, messageId: id });
       assert.deepEqual(a.queue[0].message, {
@@ -193,3 +205,4 @@ type: 'group',
         timestamp: date,
-        context: context
+        context: context,
+        messageId: id
       });
@@ -218,3 +231,3 @@ });
       var date = new Date();
-      a.track({ userId: 'id', event: 'event', timestamp: date });
+      a.track({ userId: 'id', event: 'event', timestamp: date, messageId: id });
       assert.deepEqual(a.queue[0].message, {
@@ -225,3 +238,4 @@ type: 'track',
         timestamp: date,
-        context: context
+        context: context,
+        messageId: id
       });
@@ -232,3 +246,3 @@ });
       var date = new Date();
-      a.track({ userId: 1, event: 'jumped the shark', timestamp: date });
+      a.track({ userId: 1, event: 'jumped the shark', timestamp: date, messageId: id });
       assert.deepEqual(a.queue[0].message, {
@@ -239,3 +253,4 @@ userId: 1,
         timestamp: date,
-        context: context
+        context: context,
+        messageId: id
       })
@@ -264,3 +279,3 @@ });
       var date = new Date();
-      a.page({ userId: 'id', timestamp: date });
+      a.page({ userId: 'id', timestamp: date, messageId: id });
       assert.deepEqual(a.queue[0].message, {
@@ -270,3 +285,4 @@ type: 'page',
         timestamp: date,
-        context: context
+        context: context,
+        messageId: id
       });
@@ -289,3 +305,3 @@ });
       var date = new Date();
-      a.alias({ previousId: 'previous', userId: 'id', timestamp: date });
+      a.alias({ previousId: 'previous', userId: 'id', timestamp: date, messageId: id });
       assert.deepEqual(a.queue[0].message, {
@@ -296,3 +312,4 @@ type: 'alias',
         timestamp: date,
-        context: context
+        context: context,
+        messageId: id
       });
@@ -299,0 +316,0 @@ });

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

384480

increased by0.18%

Lines of code

11495

increased by0.13%

Worsened metrics

Number of medium supply chain risk alerts

4

increased by33.33%

Dependency changes

• + Addedcrypto-token@^1.0.1

• + Addedcrypto-token@1.0.1(transitive)

• - Removeduid@0.0.2

• - Removeduid@0.0.2(transitive)