angular-star-rating - npm Package Compare versions

Comparing version 1.0.9 to 1.0.10

bower.json

 {
   "name": "angular-star-rating",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "description": "Angular Star Rating is a Angular1.5 component written in typescript.",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

CHANGELOG.md

@@ -0,1 +1,6 @@
+<a name="1.0.10"></a>
+## [1.0.10](https://github.com/BioPhoton/angular-star-rating/compare/v1.0.9...v1.0.10) (2016-11-27)
+
+
+
 <a name="1.0.9"></a>
@@ -2,0 +7,0 @@ ## [1.0.9](https://github.com/BioPhoton/angular-star-rating/compare/v1.0.7...v1.0.9) (2016-11-26)

package.json

 {
   "name": "angular-star-rating",
-  "version": "1.0.9",
+  "version": "1.0.10",
   "license": "MIT",
@@ -40,4 +40,2 @@ "keywords": [
     "angular-mocks": "^1.5.8",
-    "awesome-typescript-loader": "^2.2.4",
-    "baggage-loader": "^0.2.4",
     "css-loader": "^0.25.0",
@@ -68,2 +66,3 @@ "del": "^2.2.2",
     "karma-jasmine": "^1.0.2",
+    "karma-phantomjs-launcher": "^1.0.2",
     "karma-sourcemap-loader": "^0.3.7",
@@ -102,5 +101,5 @@ "karma-webpack": "^1.8.0",
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
-    "version:bump":"gulp version:bump",
+    "version:bump": "gulp version:bump",
     "release": "npm publish bower publish"
   }
-}
+}

README.md

 # Angular Star Rating
 #### Angular 1.5 Component written in typescript, based on css only techniques.
 
-[![Bower version](https://badge.fury.io/bo/angular1-star-rating.svg)](https://badge.fury.io/bo/angular1-star-rating)
-[![npm version](https://badge.fury.io/js/angular-star-rating.svg)](https://badge.fury.io/js/angular-star-rating)  
-[![Package Quality](http://npm.packagequality.com/badge/angular-star-rating.png)](http://packagequality.com/#?package=angular-star-rating)
+![License](https://img.shields.io/npm/l/angular-star-rating.svg) 
+![Bower Version](https://img.shields.io/bower/v/angular1-star-rating.svg)
+[![NPM Version](https://img.shields.io/npm/v/angular-star-rating.svg)](https://www.npmjs.com/package/angular-star-rating)  
+[![Standard Version](https://img.shields.io/badge/release-standard%20version-brightgreen.svg)](https://github.com/BioPhoton/angular-star-rating) 
 
+[![Build Status](https://travis-ci.org/BioPhoton/angular-star-rating.svg?branch=dev)](https://travis-ci.org/BioPhoton/angular-star-rating)
+[![npm](https://img.shields.io/npm/dt/angular-star-rating.svg)](https://www.npmjs.com/package/angular-star-rating)  
+
+[![Package Quality](http://npm.packagequality.com/badge/angular-star-rating.png)](http://packagequality.com/#?package=angular-star-rating)  
+
 Angular Star Rating is a >1.5 Angular component written in typescript.   
@@ -9,0 +15,0 @@ It is based on a fully customizable css only star rating component written in scss.

src/star-rating.controller.jasmine.ts

 import angular = require('angular');
 import ngMock = require('angular-mocks');
 
-
 import IRootScopeService = angular.IRootScopeService;
@@ -18,3 +17,5 @@
     let negativeValue: number = -1;
+    let defaultValue: number = 0;
 
+    let defaultColor: starRatingColors = "default";
     let negativeColor: starRatingColors = "negative";
@@ -35,3 +36,3 @@ let okColor: starRatingColors = "middle";
         expect(starRatingCtrl).toBeDefined();
-        expect(typeof starRatingCtrl.calculateColor).toBe('function');
+        expect(typeof starRatingCtrl._calculateColor).toBe('function');
     });
@@ -48,3 +49,3 @@
         expect(typeof starRatingCtrl.color).toBe("string");
-        expect(starRatingCtrl.color).toBe(starRatingCtrl.calculateColor(starRatingCtrl.rating, starRatingCtrl.numOfStars));
+        expect(starRatingCtrl.color).toBe(starRatingCtrl._calculateColor(starRatingCtrl.rating, starRatingCtrl.numOfStars));
         expect(starRatingCtrl.labelPosition).toBe(undefined);
@@ -94,2 +95,4 @@ expect(starRatingCtrl.speed).toBe(undefined);
                 return this.color
+            }, getHalfStarClass: function () {
+                return true;
             }
@@ -122,3 +125,3 @@ , onClick: function () {
 
-    it("should return proper values when firing calculateColor function", () => {
+    it("should return proper values when firing _calculateColor function", () => {
 
@@ -130,3 +133,4 @@ let lowRating = 1;
         let testValues = {};
-        testValues[negativeValue] = negativeColor;
+        testValues[defaultValue] = defaultColor;
+        testValues[negativeValue] = defaultColor;
         testValues[lowRating] = negativeColor;
@@ -144,3 +148,3 @@ testValues[okRating] = okColor;
             starRatingCtrl = getStarRatingCtrl(bindings);
-            expect(starRatingCtrl.calculateColor(starRatingCtrl.rating, starRatingCtrl.numOfStars, starRatingCtrl.color)).toBe(testValues[value]);
+            expect(starRatingCtrl._calculateColor(starRatingCtrl.rating, starRatingCtrl.numOfStars, starRatingCtrl.color)).toBe(testValues[value]);
         }
@@ -154,3 +158,3 @@
             starRatingCtrl = getStarRatingCtrl(bindings);
-            expect(starRatingCtrl.calculateColor(starRatingCtrl.rating, starRatingCtrl.numOfStars, staticColor)).toBe(staticColor);
+            expect(starRatingCtrl._calculateColor(starRatingCtrl.rating, starRatingCtrl.numOfStars, staticColor)).toBe(staticColor);
         }
@@ -160,2 +164,28 @@
 
+    it("should return proper values when firing _calcHalfStarClass function", () => {
+
+        let okRating = 3;
+
+        let testValues = {};
+        testValues[-0.1] = false;
+        testValues[-0.5] = false;
+        testValues[-0.9] = false;
+        testValues[defaultValue+0.1] = true;
+        testValues[defaultValue+0.5] = true;
+        testValues[defaultValue+0.9] = true;
+        testValues[okRating+0.1] = true;
+        testValues[okRating+0.5] = true;
+        testValues[okRating+0.9] = true;
+
+        let bindings = <IStarRatingCompBindings>{};
+
+        //default return values
+        for (let value in testValues) {
+            bindings.rating = parseFloat(value);
+            starRatingCtrl = getStarRatingCtrl(bindings);
+            expect(starRatingCtrl._calcHalfStarClass(starRatingCtrl.rating)).toBe(testValues[value]);
+        }
+
+    });
+
     it("should return proper values when firing updateNumOfStars function", () => {
@@ -169,2 +199,3 @@
         testValues[negativeValue] = okColor;
+        testValues[defaultValue] = okColor;
         testValues[lowNumOfStars] = positiveColor;
@@ -201,3 +232,4 @@ testValues[defaultNumOfStars] = okColor;
         let testValues = {};
-        testValues[negativeValue] = negativeColor;
+        testValues[negativeValue] = defaultColor;
+        testValues[defaultValue] = defaultColor;
         testValues[lowRating] = negativeColor;
@@ -220,2 +252,3 @@ testValues[okRating] = okColor;
             //@TODO spy on getColor
+
             expect(starRatingCtrl.color).toBe(testValues[rating]);
@@ -238,3 +271,4 @@ //@TODO spy on onUpdate
         let testValues = {};
-        testValues[negativeValue] = negativeColor;
+        testValues[negativeValue] = defaultColor;
+        testValues[defaultValue] = defaultColor;
         testValues[lowRating] = negativeColor;
@@ -276,3 +310,2 @@ testValues[okRating] = okColor;
         bindingsProperties = bindingsProperties || <IStarRatingCompBindings>{};
-
         return $componentController('starRatingComp', null, bindingsProperties);
@@ -279,0 +312,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

4329960

increased by0.05%

Dev dependency count

46

decreased by-2.13%

Number of package files

51

increased by2%

Lines of code

30427

increased by0.09%

Number of lines in readme file

224

increased by2.75%

No dependency changes