axe-core - npm Package Compare versions

Comparing version 2.2.0 to 2.2.1

doc/code-submission-guidelines.md

@@ -8,2 +8,3 @@ # Code Submission Guidelines
 - [Git Commits](#git-commits)
+- [Submitting a pull request](#submitting-a-pull-request)
 - [Merging a pull request](#merging-a-pull-request)
@@ -95,20 +96,32 @@ - [Squashing Commits](#squashing-everything-into-one-commit)
 
+## Submitting a pull request
 
-## Merging a pull request
+We want to keep our commit log clean by avoiding merge messages in branches. Before submitting a pull request, make sure your branch is up to date with the develop branch by either:
 
-To apply a pull request, make sure your local develop branch is up to date. Then, create a new branch
-for that pull request:
+- Pulling from develop before creating your branch
+- Doing a rebase from origin/develop (will require a force push **on your branch**)
+
+To rebase from origin/develop if we've pushed changes since you created your branch:
+
 ```sh
-git checkout -b some-user-feature
+git checkout your-branch
+git fetch
+git rebase origin/develop
+git push origin head -f
 ```
 
-Run the following commands to apply all commits from that pull request on top of your branch's local history:
+## Merging a pull request
 
-### Bitbucket
+If a pull request has many commits (especially if they don't follow our [commit policy](#git-commits)), you'll want to squash them into one clean commit.
 
+In the Github UI, you can use the new [Squash and Merge](https://github.com/blog/2141-squash-your-commits) feature to make this easy. If there are merge conflicts preventing this, either ask the committer to rebase from develop following the [PR submission steps above](#submitting-a-pull-request), or use the manual method below.
+
+To apply a pull request manually, make sure your local develop branch is up to date. Then, create a new branch for that pull request.
+
+Create a temporary, local branch:
+```sh
+git checkout -b temp-feature-branch
 ```
-curl -L https://bitbucket.org/api/2.0/repositories/dmusser/axe-core/pullrequests/85/patch | git am -3
-```
 
-### Github
+Run the following commands to apply all commits from that pull request on top of your branch's local history:
 
@@ -119,4 +132,2 @@ ```
 
-> In the Github UI, you can use the new [Squash and Merge](https://github.com/blog/2141-squash-your-commits) feature as an alternative.
-
 If the merge succeeds, use `git diff origin/develop` to review all the changes that will happen
@@ -127,8 +138,10 @@ post-merge.
 
-Before merging a pull request into develop, make sure there is only one commit representing the
-changes in the pull request, so the git log stays lean.
+Before merging a pull request with many commits into develop, make sure there is only one commit representing the
+changes in the pull request, so the git log stays lean. We particularly want to avoid merge messages and vague commits that don't follow our commit policy (like `Merged develop into featurebranch` or `fixed some stuff`).
 
 You can use git's interactive rebase to manipulate, merge, and rename commits in your local
-history.
+history. If these steps are followed, a force push shouldn't be necessary. 
 
+**Do not force push to develop or master under any circulstances.**
+
 To interactively rebase all of your commits on top of the latest in develop, run:
@@ -135,0 +148,0 @@

doc/projects.md

@@ -5,23 +5,27 @@ # Projects that use axe-core
 
+1. [WorldSpace Attest](https://www.deque.com/products/worldspace-attest/)
+1. [WorldSpace Assure](https://www.deque.com/products/worldspace-assure/)
+1. [WorldSpace Comply](https://www.deque.com/products/worldspace-comply/)
 1. [aXe Chrome plugin](https://chrome.google.com/webstore/detail/axe/lhdoppojpmngadmnindnejefpokejbdd)
-2. [axe-webdriverjs](https://www.npmjs.com/package/axe-webdriverjs)
-3. [ember-a11y-testing](https://www.npmjs.com/package/ember-a11y-testing)
-4. [axe-firefox-devtools](https://github.com/dequelabs/axe-firefox-devtools) and on the [Firefox extension page](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/)
-5. [axe-selenium-java](https://github.com/dequelabs/axe-selenium-java)
-6. [a11yChromePlugin - not the official Chrome plugin source code](https://github.com/ptrstpp950/a11yChromePlugin)
-7. [grunt-axe-webdriver](https://www.npmjs.com/package/grunt-axe-webdriver)
-8. [R-Spec and Cucumber](https://github.com/dequelabs/axe-matchers)
-9. [aXe audit runner for CrawlKit](https://github.com/crawlkit/runner-axe)
-10. [Web Accessibility Checker for Visual Studio](https://visualstudiogallery.msdn.microsoft.com/3aabefab-1681-4fea-8f95-6a62e2f0f1ec)
-11. [ReactJS Accessibility Checker](https://github.com/dylanb/react-axe) (react-axe)
-12. [Vorlon.js Remote Debugger](https://github.com/MicrosoftDX/Vorlonjs)
-13. [Selenium IDE aXe Extension](https://github.com/bkardell/selenium-ide-axe)
-14. [gulp-axe-webdriver](https://github.com/felixzapata/gulp-axe-webdriver)
-15. [AccessLint](https://accesslint.com/)
-16. [Lighthouse](https://github.com/GoogleChrome/lighthouse)
-17. [Axegrinder](https://github.com/claflamme/axegrinder)
-18. [Ghost-Axe](https://www.npmjs.com/package/ghost-axe)
-19. [Protractor accessibility plugin](https://github.com/angular/protractor-accessibility-plugin)
-20. [Storybook accessibility addon](https://github.com/jbovenschen/storybook-addon-a11y)
-21. [Intern](https://github.com/theintern/intern-a11y)
-22. [Protractor-axe-report Plugin](https://github.com/E1Edatatracker/protractor-axe-report-plugin)
+1. [axe-webdriverjs](https://www.npmjs.com/package/axe-webdriverjs)
+1. [ember-a11y-testing](https://www.npmjs.com/package/ember-a11y-testing)
+1. [axe-firefox-devtools](https://github.com/dequelabs/axe-firefox-devtools) and on the [Firefox extension page](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/)
+1. [axe-selenium-java](https://github.com/dequelabs/axe-selenium-java)
+1. [a11yChromePlugin - not the official Chrome plugin source code](https://github.com/ptrstpp950/a11yChromePlugin)
+1. [grunt-axe-webdriver](https://www.npmjs.com/package/grunt-axe-webdriver)
+1. [R-Spec and Cucumber](https://github.com/dequelabs/axe-matchers)
+1. [aXe audit runner for CrawlKit](https://github.com/crawlkit/runner-axe)
+1. [Web Accessibility Checker for Visual Studio](https://visualstudiogallery.msdn.microsoft.com/3aabefab-1681-4fea-8f95-6a62e2f0f1ec)
+1. [ReactJS Accessibility Checker](https://github.com/dylanb/react-axe) (react-axe)
+1. [Vorlon.js Remote Debugger](https://github.com/MicrosoftDX/Vorlonjs)
+1. [Selenium IDE aXe Extension](https://github.com/bkardell/selenium-ide-axe)
+1. [gulp-axe-webdriver](https://github.com/felixzapata/gulp-axe-webdriver)
+1. [AccessLint](https://accesslint.com/)
+1. [Lighthouse](https://github.com/GoogleChrome/lighthouse)
+1. [Axegrinder](https://github.com/claflamme/axegrinder)
+1. [Ghost-Axe](https://www.npmjs.com/package/ghost-axe)
+1. [Protractor accessibility plugin](https://github.com/angular/protractor-accessibility-plugin)
+1. [Storybook accessibility addon](https://github.com/jbovenschen/storybook-addon-a11y)
+1. [Intern](https://github.com/theintern/intern-a11y)
+1. [Protractor-axe-report Plugin](https://github.com/E1Edatatracker/protractor-axe-report-plugin)
+1. [Rocket Validator](https://rocketvalidator.com)

Gruntfile.js

@@ -196,3 +196,3 @@ //jshint maxcomplexity: 12, maxstatements: false, camelcase: false
 					},
-					preserveComments: 'some'
+					preserveComments: /^!/
 				}
@@ -199,0 +199,0 @@ },

lib/checks/color/link-in-text-block.js

@@ -47,3 +47,2 @@ /* global axe*/
 		axe.commons.color.incompleteData.set('fgColor', {
-			node: nodeColor ? parentBlock : node,
 			reason: 'bgContrast'
@@ -72,3 +71,2 @@ });
 		axe.commons.color.incompleteData.set('fgColor', {
-			node: nodeColor ? parentBlock : node,
 			reason: reason
@@ -75,0 +73,0 @@ });

lib/commons/color/get-background-color.js

@@ -10,3 +10,2 @@ /* global axe, color, dom */
 		axe.commons.color.incompleteData.set('bgColor', {
-			node: elm,
 			reason: 'imgNode'
@@ -23,3 +22,2 @@ });
 		axe.commons.color.incompleteData.set('bgColor', {
-			node: elm,
 			reason: (hasGradient ? 'bgGradient' : 'bgImage')
@@ -116,3 +114,2 @@ });
 		axe.commons.color.incompleteData.set('bgColor', {
-			node: elm,
 			reason: 'bgOverlap'
@@ -119,0 +116,0 @@ });

lib/commons/color/get-foreground-color.js

@@ -23,3 +23,2 @@ /*global axe, color */
 		axe.commons.color.incompleteData.set('fgColor', {
-			node: node,
 			reason: reason
@@ -26,0 +25,0 @@ });

lib/commons/color/incomplete-data.js

@@ -13,3 +13,2 @@ /* global color */
 		 * @param {Object} dataObj 				Missing data information
-		 * @param {Element} dataObj.node 	Node being tested for data point
 		 * @param {String} dataObj.reason Key for reason we couldn't tell
@@ -16,0 +15,0 @@ */

package.json

 {
   "name": "axe-core",
   "description": "Accessibility engine for automated Web UI testing",
-  "version": "2.2.0",
+  "version": "2.2.1",
   "license": "MPL-2.0",
@@ -6,0 +6,0 @@ "contributors": [

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1981972

increased by0.1%

Lines of code

46704

increased by0.02%

Number of medium supply chain risk alerts

1

decreased by-50%

No dependency changes