azlyrics - npm Package Compare versions

Comparing version 1.0.2 to 2.0.0

index.js

@@ -8,3 +8,3 @@ /*
 // Requires
-const request = require('sync-request'); 
+const request = require('request'); 
 const cheerio = require('cheerio');
@@ -48,19 +48,22 @@ // Constant
 	var URI = artistUrl(artistName);
-	// Get the response
-	var Response = request('GET', URI);
-	// Parse the body
-	var $ = cheerio.load(Response.getBody());
-	// Get the album list
-	var albumList = $('.album > b');
-	// Start pushing to the array
-	var returnValue = [];
-	for(var index = 0; index < albumList.length; index++)
-	{
-		// Remove the trailing "-s
-		var albumName = albumList[index].children[0].data.substr(1).slice(0, -1);
-		// Append the album name to the list
-		returnValue.push(albumName);
-	}
-	// Return the array
-	return returnValue;
+	return new Promise(r => {
+		// Get the response
+		request(URI, (error,response,body) => {
+			// Parse the body
+			var $ = cheerio.load(body);
+			// Get the album list
+			var albumList = $('.album > b');
+			// Start pushing to the array
+			var returnValue = [];
+			for(var index = 0; index < albumList.length; index++)
+			{
+				// Remove the trailing "-s
+				var albumName = albumList[index].children[0].data.substr(1).slice(0, -1);
+				// Append the album name to the list
+				returnValue.push(albumName);
+			}
+			// Return the array
+			r(returnValue);
+		});
+	});
 }
@@ -71,18 +74,21 @@ // Gets the songs from a specified artist
 	var URI = artistUrl(artistName);
-	// Get the response
-	var Response = request('GET', URI);
-	// Parse the body
-	var $ = cheerio.load(Response.getBody());
-	// Get the song list
-	var songList = $("#listAlbum > a[href]");
-	// Start pushing to the array
-	var returnValue = [];
-	for(var index = 0; index < songList.length; index++)
-	{
-		var songName = songList[index].children[0].data;
-		// Append the song name to the list
-		returnValue.push(songName);
-	}
-	// Return the array
-	return returnValue;
+	return new Promise(r => {
+		// Get the response
+		var Response = request(URI,(error,response,body) => {
+			// Parse the body
+			var $ = cheerio.load(body);
+			// Get the song list
+			var songList = $("#listAlbum > a[href]");
+			// Start pushing to the array
+			var returnValue = [];
+			for(var index = 0; index < songList.length; index++)
+			{
+				var songName = songList[index].children[0].data;
+				// Append the song name to the list
+				returnValue.push(songName);
+			}
+			// Return the array
+			r(returnValue);
+		});
+	});
 }
@@ -93,18 +99,21 @@ // Gets the lyrics for a song, artist must be specified
 	var URI = lyricsUrl(artistName,songName);
-	// Get the response
-	var Response = request('GET', URI);
-	// Parse the body
-	var $ = cheerio.load(Response.getBody());
-	// Get the lyrics
-	var lyricsDiv = $(".col-xs-12.col-lg-8.text-center")[0].children[16].children;
-	// Start getting the lyrics
-	var lyrics = lyricsDiv[2].data.substr(1)+"\n";
-	for(var index = 4; index < lyricsDiv.length; index+=2)
-	{
-		var line = lyricsDiv[index].data.substr(1)+"\n";
-		lyrics += line;
-	}
-	lyrics = lyrics.slice(0,-2);
-	// Return the lyrics
-	return lyrics;
+	return new Promise(r => {
+		// Get the response
+		var Response = request(URI,(error,response,body) => {;
+			// Parse the body
+			var $ = cheerio.load(body);
+			// Get the lyrics
+			var lyricsDiv = $(".col-xs-12.col-lg-8.text-center")[0].children[16].children;
+			// Start getting the lyrics
+			var lyrics = lyricsDiv[2].data.substr(1)+"\n";
+			for(var index = 4; index < lyricsDiv.length; index+=2)
+			{
+				var line = lyricsDiv[index].data.substr(1)+"\n";
+				lyrics += line;
+			}
+			lyrics = lyrics.slice(0,-2);
+			// Return the lyrics
+			r(lyrics);
+		});
+	});
 }

package.json

 {
   "name": "azlyrics",
-  "version": "1.0.2",
+  "version": "2.0.0",
   "description": "An AzLyrics API",
@@ -25,4 +25,4 @@ "main": "index.js",
     "cheerio": "^1.0.0-rc.2",
-    "sync-request": "^4.1.0"
+    "request": "^2.85.0"
   }
 }

README.md

 ### azlyrics.js
 `azlyrics.js` is a NodeJS package that interacts with the [AZLyrics](https://azlyrics.com/) website.
+All methods return promises which resolve different things.
 ## Supported methods
-| Name        | Returns          | Arguments  |
+| Name        | Resolves          | Arguments  |
 | ------------- |:-------------:| -----:|
@@ -6,0 +7,0 @@ | getAlbums      | Array | (artistName : String) |

Fixed alerts

Deprecated

Maintenance

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6286

increased by4.06%

Lines of code

114

increased by8.57%

Number of high maintenance alerts

0

decreased by-100%

Number of lines in readme file

10

increased by11.11%

Dependency changes

• + Addedrequest@^2.85.0

• + Addedajv@6.12.6(transitive)

• + Addedasn1@0.2.6(transitive)

• + Addedassert-plus@1.0.0(transitive)

• + Addedasynckit@0.4.0(transitive)

• + Addedaws-sign2@0.7.0(transitive)

• + Addedaws4@1.12.0(transitive)

• + Addedbcrypt-pbkdf@1.0.2(transitive)

• + Addedcaseless@0.12.0(transitive)

• + Addedcombined-stream@1.0.8(transitive)

• + Addedcore-util-is@1.0.2(transitive)

• + Addeddashdash@1.14.1(transitive)

• + Addeddelayed-stream@1.0.0(transitive)

• + Addedecc-jsbn@0.1.2(transitive)

• + Addedextend@3.0.2(transitive)

• + Addedextsprintf@1.3.0(transitive)

• + Addedfast-deep-equal@3.1.3(transitive)

• + Addedfast-json-stable-stringify@2.1.0(transitive)

• + Addedforever-agent@0.6.1(transitive)

• + Addedform-data@2.3.3(transitive)

• + Addedgetpass@0.1.7(transitive)

• + Addedhar-schema@2.0.0(transitive)

• + Addedhar-validator@5.1.5(transitive)

• + Addedhttp-signature@1.2.0(transitive)

• + Addedis-typedarray@1.0.0(transitive)

• + Addedisstream@0.1.2(transitive)

• + Addedjsbn@0.1.1(transitive)

• + Addedjson-schema@0.4.0(transitive)

• + Addedjson-schema-traverse@0.4.1(transitive)

• + Addedjson-stringify-safe@5.0.1(transitive)

• + Addedjsprim@1.4.2(transitive)

• + Addedmime-db@1.52.0(transitive)

• + Addedmime-types@2.1.35(transitive)

• + Addedoauth-sign@0.9.0(transitive)

• + Addedperformance-now@2.1.0(transitive)

• + Addedpsl@1.9.0(transitive)

• + Addedpunycode@2.3.1(transitive)

• + Addedqs@6.5.3(transitive)

• + Addedrequest@2.88.2(transitive)

• + Addedsafe-buffer@5.2.1(transitive)

• + Addedsafer-buffer@2.1.2(transitive)

• + Addedsshpk@1.18.0(transitive)

• + Addedtough-cookie@2.5.0(transitive)

• + Addedtunnel-agent@0.6.0(transitive)

• + Addedtweetnacl@0.14.5(transitive)

• + Addeduri-js@4.4.1(transitive)

• + Addeduuid@3.4.0(transitive)

• + Addedverror@1.10.0(transitive)

• - Removedsync-request@^4.1.0

• - Removedasap@2.0.6(transitive)

• - Removedbuffer-from@1.1.2(transitive)

• - Removedcall-bind@1.0.7(transitive)

• - Removedcaseless@0.11.0(transitive)

• - Removedcommand-exists@1.2.9(transitive)

• - Removedconcat-stream@1.6.2(transitive)

• - Removedcore-util-is@1.0.3(transitive)

• - Removeddefine-data-property@1.1.4(transitive)

• - Removedes-define-property@1.0.0(transitive)

• - Removedes-errors@1.3.0(transitive)

• - Removedfunction-bind@1.1.2(transitive)

• - Removedget-intrinsic@1.2.4(transitive)

• - Removedget-port@3.2.0(transitive)

• - Removedgopd@1.0.1(transitive)

• - Removedhas-property-descriptors@1.0.2(transitive)

• - Removedhas-proto@1.0.3(transitive)

• - Removedhas-symbols@1.0.3(transitive)

• - Removedhasown@2.0.2(transitive)

• - Removedhttp-basic@2.5.1(transitive)

• - Removedhttp-response-object@1.1.0(transitive)

• - Removedinherits@2.0.4(transitive)

• - Removedisarray@1.0.0(transitive)

• - Removedobject-inspect@1.13.1(transitive)

• - Removedprocess-nextick-args@2.0.1(transitive)

• - Removedpromise@7.3.1(transitive)

• - Removedqs@6.12.1(transitive)

• - Removedreadable-stream@2.3.8(transitive)

• - Removedsafe-buffer@5.1.2(transitive)

• - Removedset-function-length@1.2.2(transitive)

• - Removedside-channel@1.0.6(transitive)

• - Removedstring_decoder@1.1.1(transitive)

• - Removedsync-request@4.1.0(transitive)

• - Removedthen-request@2.2.0(transitive)

• - Removedtypedarray@0.0.6(transitive)

• - Removedutil-deprecate@1.0.2(transitive)