backbone-collection-proxy - npm Package Compare versions

Comparing version 0.2.3 to 0.2.4

backbone-collection-proxy.js

@@ -48,3 +48,3 @@ (function(root, factory) {
     if (_.contains(eventWhiteList, eventName)) {
-      if (_.contains(['add', 'remove', 'destory'], eventName)) {
+      if (_.contains(['add', 'remove', 'destroy'], eventName)) {
         args[2] = target;
@@ -51,0 +51,0 @@ } else if (_.contains(['reset', 'sort'], eventName)) {

bower.json

 {
   "name": "backbone-collection-proxy",
   "description": "Create a read-only copy of a backbone collection that stays in sync with the original",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "homepage": "http://github.com/jmorrell/backbone-collection-proxy",
@@ -6,0 +6,0 @@ "keywords": [],

CHANGELOG.md

@@ -0,1 +1,5 @@
+v0.2.4
+
+* Fixed type in event name
+
 v0.2.3
@@ -2,0 +6,0 @@

index.js

@@ -35,3 +35,3 @@
     if (_.contains(eventWhiteList, eventName)) {
-      if (_.contains(['add', 'remove', 'destory'], eventName)) {
+      if (_.contains(['add', 'remove', 'destroy'], eventName)) {
         args[2] = target;
@@ -38,0 +38,0 @@ } else if (_.contains(['reset', 'sort'], eventName)) {

package.json

 {
   "name": "backbone-collection-proxy",
   "description": "Create a read-only copy of a backbone collection that stays in sync with the original",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "homepage": "http://github.com/jmorrell/backbone-collection-proxy",
@@ -6,0 +6,0 @@ "main": "index.js",

test/backbone-collection-tests.js

@@ -152,14 +152,2 @@ $(document).ready(function() {
 
-  test("sortedIndex", function () {
-    var model = new Backbone.Model({key: 2});
-    var collection = getProxyCollection(new (Backbone.Collection.extend({
-      comparator: 'key'
-    }))([model, {key: 1}]));
-    equal(collection.sortedIndex(model), 1);
-    equal(collection.sortedIndex(model, 'key'), 1);
-    equal(collection.sortedIndex(model, function (model) {
-      return model.get('key');
-    }), 1);
-  });
-
   test("trigger custom events on models", 1, function() {
@@ -166,0 +154,0 @@ var fired = null;

No alert changes

Worsened metrics

Total package byte prevSize

32783

decreased by-1.14%

Lines of code

752

decreased by-1.44%

No dependency changes