bin-build - npm Package Compare versions

Comparing version 0.2.0 to 1.0.0

index.js

 'use strict';
 
 var exec = require('child_process').exec;
+var Download = require('download');
 var rm = require('rimraf');
@@ -61,17 +62,24 @@ var tempfile = require('tempfile');
 BinBuild.prototype.build = function (cb) {
-    var download = require('download');
+    cb = cb || function () {};
+
     var str = this.cmd().join(' && ');
     var tmp = tempfile();
+    var download = new Download({ strip: 1, extract: true })
+        .get(this.src(), tmp);
 
-    download(this.src(), tmp, { strip: 1, extract: true })
-        .on('error', cb)
-        .on('close', function () {
-            exec(str, { cwd: tmp }, function (err) {
-                if (err) {
-                    return cb(err);
-                }
+    download.run(function (err) {
+        if (err) {
+            cb(err);
+            return;
+        }
 
-                rm(tmp, cb);
-            });
+        exec(str, { cwd: tmp }, function (err) {
+            if (err) {
+                cb(err);
+                return;
+            }
+
+            rm(tmp, cb);
         });
+    });
 };
@@ -78,0 +86,0 @@

package.json

 {
   "name": "bin-build",
-  "version": "0.2.0",
+  "version": "1.0.0",
   "description": "Easily build binaries",
@@ -16,3 +16,3 @@ "license": "MIT",
   "scripts": {
-    "test": "mocha --reporter list --timeout 75000"
+    "test": "node test.js"
   },
@@ -28,9 +28,9 @@ "files": [
   "dependencies": {
-    "download": "^0.1.16",
+    "download": "^1.0.2",
     "rimraf": "^2.2.6",
-    "tempfile": "^0.1.3"
+    "tempfile": "^1.0.0"
   },
   "devDependencies": {
-    "mocha": "^1.18.2"
+    "ava": "^0.0.4"
   }
 }

README.md

@@ -15,15 +15,15 @@ # bin-build [![Build Status](https://travis-ci.org/kevva/bin-build.svg?branch=master)](https://travis-ci.org/kevva/bin-build)
 var BinBuild = require('bin-build');
-var build = new BinBuild();
 
-build
+var build = new BinBuild()
     .src('http://www.lcdf.org/gifsicle/gifsicle-1.80.tar.gz')
     .cmd('./configure --disable-gifview --disable-gifdiff')
-    .cmd('make install')
-    .build(function (err) {
-        if (err) {
-            throw err;
-        }
+    .cmd('make install');
 
-        console.log('gifsicle built successfully');
-    });
+build.build(function (err) {
+    if (err) {
+        throw err;
+    }
+
+    console.log('gifsicle built successfully');
+});
 ```
@@ -47,3 +47,3 @@
 
-Runs the build.
+Runs the build and returns an error if something has gone wrong
 
@@ -50,0 +50,0 @@ ## License

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2937

increased by3.16%

Lines of code

72

increased by9.09%

Number of low quality alerts

0

decreased by-100%

Dependency changes

• + Addedansi-regex@0.2.1(transitive)

• + Addedansi-styles@1.1.0(transitive)

• + Addedarchive-type@1.0.4(transitive)

• + Addedcamelcase@1.2.1(transitive)

• + Addedcamelcase-keys@1.0.0(transitive)

• + Addedchalk@0.5.1(transitive)

• + Addedcommander@2.20.3(transitive)

• + Addeddecompress@1.0.7(transitive)

• + Addeddecompress-tar@1.0.3(transitive)

• + Addeddecompress-tarbz2@1.0.2(transitive)

• + Addeddecompress-targz@1.0.3(transitive)

• + Addeddecompress-unzip@1.0.0(transitive)

• + Addeddownload@1.0.7(transitive)

• + Addedeach-async@1.1.1(transitive)

• + Addedescape-string-regexp@1.0.5(transitive)

• + Addedfs-extra@0.11.1(transitive)

• + Addedfstream@1.0.12(transitive)

• + Addedget-stdin@3.0.24.0.1(transitive)

• + Addedgraceful-fs@4.2.11(transitive)

• + Addedhas-ansi@0.1.0(transitive)

• + Addedindent-string@1.2.2(transitive)

• + Addedis-7zip@1.0.0(transitive)

• + Addedis-absolute@0.1.7(transitive)

• + Addedis-bzip2@1.0.0(transitive)

• + Addedis-finite@1.1.0(transitive)

• + Addedis-gzip@1.0.0(transitive)

• + Addedis-integer@1.0.7(transitive)

• + Addedis-rar@1.0.0(transitive)

• + Addedis-relative@0.1.3(transitive)

• + Addedis-tar@1.0.0(transitive)

• + Addedis-zip@0.1.01.0.0(transitive)

• + Addedjsonfile@2.4.0(transitive)

• + Addedmap-obj@1.0.1(transitive)

• + Addedmeow@2.1.0(transitive)

• + Addedncp@0.6.0(transitive)

• + Addednopt@3.0.6(transitive)

• + Addedobject-assign@1.0.02.1.1(transitive)

• + Addedonetime@1.1.0(transitive)

• + Addedos-tmpdir@1.0.2(transitive)

• + Addedread-chunk@1.0.1(transitive)

• + Addedrepeating@1.1.3(transitive)

• + Addedseek-bzip@1.0.6(transitive)

• + Addedset-immediate-shim@1.0.1(transitive)

• + Addedsimple-bufferstream@0.0.4(transitive)

• + Addedstrip-ansi@0.3.0(transitive)

• + Addedstrip-dirs@0.1.1(transitive)

• + Addedsupports-color@0.2.0(transitive)

• + Addedtar@1.0.3(transitive)

• + Addedtemp-write@1.1.2(transitive)

• + Addedtempfile@1.1.1(transitive)

• + Addeduuid@2.0.3(transitive)

• + Addedware@0.3.0(transitive)

• - Removedcore-util-is@1.0.3(transitive)

• - Removeddecompress@0.2.5(transitive)

• - Removeddownload@0.1.19(transitive)

• - Removedduplexer@0.1.2(transitive)

• - Removedeach-async@0.1.3(transitive)

• - Removedext-list@0.2.0(transitive)

• - Removedext-name@1.0.1(transitive)

• - Removedfstream@0.1.31(transitive)

• - Removedget-stdin@0.1.0(transitive)

• - Removedget-urls@0.1.2(transitive)

• - Removedgot@0.2.0(transitive)

• - Removedgraceful-fs@3.0.12(transitive)

• - Removedisarray@0.0.1(transitive)

• - Removedmkdirp@0.3.5(transitive)

• - Removednatives@1.1.6(transitive)

• - Removednopt@2.2.1(transitive)

• - Removedobject-assign@0.3.1(transitive)

• - Removedobject-keys@0.4.0(transitive)

• - Removedreadable-stream@1.0.34(transitive)

• - Removedstream-combiner@0.0.4(transitive)

• - Removedstring_decoder@0.10.31(transitive)

• - Removedtar@0.1.20(transitive)

• - Removedtempfile@0.1.3(transitive)

• - Removedthrough2@0.4.2(transitive)

• - Removedunderscore.string@2.3.3(transitive)

• - Removeduuid@1.4.2(transitive)

• - Removedxtend@2.1.2(transitive)

• Updateddownload@^1.0.2

• Updatedtempfile@^1.0.0