bitgener - npm Package Compare versions

Comparing version 1.0.2 to 1.1.0

CHANGELOG.md

 # CHANGELOG
 
+## 1.1.0 - delivery @14/08/2019
+
+- fix settings to be set with undefined values if missing
+- fix settings of type number that actually were parsed as integers
+
 ## 1.0.2 - delivery @14/08/2019
@@ -4,0 +9,0 @@

lib/index.js

@@ -22,3 +22,3 @@ /**
   cast: {
-    int,
+    num,
   },
@@ -142,16 +142,36 @@ color: {
   // padding
-  settings.padding = int(padding, { ge: 0, defaultValue: defaults.padding });
+  const paddingValue = num(padding, { ge: 0 });
 
+  if (exists(paddingValue)) {
+    settings.padding = paddingValue;
+  }
+
   // width
-  settings.width = int(w, { ge: 10, defaultValue: defaults.width });
+  const widthValue = num(w, { ge: 10 });
 
+  if (exists(widthValue)) {
+    settings.width = widthValue;
+  }
+
   // height
-  settings.height = int(h, { ge: 10, defaultValue: defaults.height });
+  const heightValue = num(h, { ge: 10 });
 
+  if (exists(heightValue)) {
+    settings.height = heightValue;
+  }
+
   // barWidth
-  settings.barWidth = int(barWidth, { ge: 1, defaultValue: defaults.barWidth });
+  const barWidthValue = num(barWidth, { ge: 1 });
 
+  if (exists(barWidthValue)) {
+    settings.barWidth = barWidthValue;
+  }
+
   // barHeight
-  settings.barHeight = int(barHeight, { ge: 1, defaultValue: defaults.barHeight });
+  const barHeightValue = num(barHeight, { ge: 1 });
 
+  if (exists(barHeightValue)) {
+    settings.barHeight = barHeightValue;
+  }
+
   // original1DSize
@@ -193,12 +213,14 @@ if (is(Boolean, original1DSize)) {
     // fontSize
-    settings.hri.fontSize = int(hri.fontSize, {
-      ge: 1,
-      defaultValue: defaults.hri.fontSize,
-    });
+    const fontSizeValue = num(hri.fontSize, { ge: 1 });
 
+    if (exists(fontSizeValue)) {
+      settings.hri.fontSize = fontSizeValue;
+    }
+
     // marginTop
-    settings.hri.marginTop = int(hri.marginTop, {
-      ge: 0,
-      defaultValue: defaults.hri.marginTop,
-    });
+    const marginTopValue = num(hri.marginTop, { ge: 0 });
+
+    if (exists(marginTopValue)) {
+      settings.hri.marginTop = marginTopValue;
+    }
   }
@@ -205,0 +227,0 @@

package.json

 {
   "name": "bitgener",
-  "version": "1.0.2",
+  "version": "1.1.0",
   "description": "A lightweight and zero-dependencies pure Node.js barcode library",
@@ -5,0 +5,0 @@ "author": "Adrien Valcke",

No alert changes

Improved metrics

Total package byte prevSize

194774

increased by0.22%

Lines of code

4866

increased by0.31%

No dependency changes