bson - npm Package Compare versions

Comparing version 0.2.9 to 0.2.10

lib/bson/objectid.js

@@ -34,3 +34,3 @@ /**
   // Throw an error if it's not a valid setup
-  if(!valid){
+  if(!valid && id != null){
     throw new Error("Argument passed in must be a single String of 12 bytes or a string of 24 hex characters");
@@ -50,5 +50,11 @@ } else if(valid && typeof id == 'string' && id.length == 24) {
 
-// Allow usage of ObjectId aswell as ObjectID
+// Allow usage of ObjectId as well as ObjectID
 var ObjectId = ObjectID;
 
+// Precomputed hex table enables speedy hex string conversion
+var hexTable = [];
+for (var i = 0; i < 256; i++) {
+  hexTable[i] = (i <= 15 ? '0' : '') + i.toString(16);
+}
+
 /**
@@ -63,12 +69,6 @@ * Return the ObjectID id as a 24 byte hex string representation
 
-  var hexString = ''
-    , number
-    , value;
+  var hexString = '';
 
-  for (var index = 0, len = this.id.length; index < len; index++) {
-    value = BinaryParser.toByte(this.id[index]);
-    number = value <= 15
-      ? '0' + value.toString(16)
-      : value.toString(16);
-    hexString = hexString + number;
+  for (var i = 0; i < this.id.length; i++) {
+    hexString += hexTable[this.id.charCodeAt(i)];
   }
@@ -238,3 +238,5 @@
 ObjectID.isValid = function isValid(id) {
-  if (id != null && 'number' != typeof id && (id.length != 12 && id.length != 24)) {
+  if(id == null) return false;
+
+  if(id != null && 'number' != typeof id && (id.length != 12 && id.length != 24)) {
     return false;
@@ -241,0 +243,0 @@ } else {

package.json

 { "name" :            "bson"
 , "description" :     "A bson parser for node.js and the browser"
 , "keywords" :        ["mongodb", "bson", "parser"]
-, "version" :         "0.2.9"
+, "version" :         "0.2.10"
 , "author" :          "Christian Amor Kvalheim <[e-mail]>"
@@ -6,0 +6,0 @@ , "contributors" :  []

No alert changes

Improved metrics

Lines of code

11745

increased by0.1%

Worsened metrics

Total package byte prevSize

1134272

decreased by-33.51%

Number of package files

48

decreased by-5.88%

No dependency changes