circular-dependency-plugin - npm Package Compare versions

Comparing version 5.1.0 to 5.2.0

index.js

@@ -38,3 +38,3 @@ let path = require('path')
 
-          let maybeCyclicalPathsList = this.isCyclic(module, module, {})
+          let maybeCyclicalPathsList = this.isCyclic(module, module, {}, compilation)
           if (maybeCyclicalPathsList) {
@@ -71,3 +71,3 @@ // allow consumers to override all behavior with onDetected
 
-  isCyclic(initialModule, currentModule, seenModules) {
+  isCyclic(initialModule, currentModule, seenModules, compilation) {
     let cwd = this.options.cwd
@@ -86,3 +86,11 @@
     for (let dependency of currentModule.dependencies) {
-      let depModule = dependency.module
+      let depModule = null
+      if (compilation.moduleGraph) {
+        // handle getting a module for webpack 5
+        depModule = compilation.moduleGraph.getModule(dependency)
+      } else {
+        // handle getting a module for webpack 4
+        depModule = dependency.module
+      }
+
       if (!depModule) { continue }
@@ -106,3 +114,3 @@ // ignore dependencies that don't have an associated resource
 
-      let maybeCyclicalPathsList = this.isCyclic(initialModule, depModule, seenModules)
+      let maybeCyclicalPathsList = this.isCyclic(initialModule, depModule, seenModules, compilation)
       if (maybeCyclicalPathsList) {
@@ -109,0 +117,0 @@ maybeCyclicalPathsList.unshift(path.relative(cwd, currentModule.resource))

package.json

@@ -7,3 +7,4 @@ {
     "memory-fs": "^0.4.1",
-    "webpack": "^4.0.1"
+    "webpack": "^4.0.1",
+    "webpack-next": "npm:webpack@^5.0.0-alpha.19"
   },
@@ -14,3 +15,3 @@ "peerDependencies": {
   "description": "Detect modules with circular dependencies when bundling with webpack.",
-  "version": "5.1.0",
+  "version": "5.2.0",
   "engines": {
@@ -17,0 +18,0 @@ "node": ">=6.0.0"

No alert changes

Improved metrics

Total package byte prevSize

9766

increased by3.61%

Lines of code

108

increased by6.93%

Worsened metrics

Dev dependency count

4

increased by33.33%

No dependency changes