clippy-say - npm Package Compare versions

Comparing version 0.0.1 to 0.0.2

cli.js

@@ -5,12 +5,9 @@ #!/usr/bin/env node
 const proc = require('child_process')
-const argv = require('minimist')(process.argv.slice(2))
-let params;
+const argv = require('minimist')(process.argv.slice(2));
 
-if(argv._.length) {
-    params = Object.keys(argv).map(key => key === '_' ? argv[key] : `--${key} ${argv[key]}`).join(' ');
-} else {
-    // Default value
-    params = 'Clippy';
-}
+const characters = ['Merlin', 'Clippy', 'Rover', 'Links'];
 
-proc.spawn(electron, ['.', ...params.split(' ') ]);
+let character = argv.c || argv.character || 'Clippy';
+if(characters.indexOf(character) === -1) return console.error(`"${character}" is not a valid character. Use ${characters.join(', ')} instead`);
+
+proc.spawn(electron, ['.', ...process.argv.slice(2)]);

package.json

 {
   "name": "clippy-say",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "",
@@ -10,3 +10,3 @@ "main": "index.js",
   "bin": {
-    "clippy-say": "./cli.js"
+    "clippysay": "./cli.js"
   },
@@ -13,0 +13,0 @@ "author": "",

README.md

@@ -22,7 +22,7 @@ # clippy-say
 # Run clippy
-clippy-say
+clippysay
 
 # Run Merlin and let him speak "Hello World"
 # Possible characters: "Clippy", "Merlin", "Rover" and "Links"
-clippy-say Merlin --speak "Hello World"
+clippysay "Hello World" --character "Hello World"
 
@@ -29,0 +29,0 @@ ```

renderer.js

 const electron = require('electron');
 const argv = require('minimist')(electron.remote.process.argv.slice(2));
 
-const speak = argv.s || argv.speak;
+const character = argv.c || argv.character || 'Clippy';
 
 const clippy = require('clippyjs');
-clippy.load(argv._[0], agent => {
+clippy.load(character, agent => {
     agent.show();
-    if(speak) {
-        agent.speak(speak);
-    }
+    agent.speak(...argv._);
 });

No alert changes

Improved metrics

Total package byte prevSize

67120

increased by0.11%

Worsened metrics

Lines of code

1352

decreased by-0.44%

No dependency changes