color-hash - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

coverage/coverage.json

@@ -1,1 +0,1 @@
-{"/home/zenozeng/home/code/color-hash/lib/bkdr-hash.js":{"path":"/home/zenozeng/home/code/color-hash/lib/bkdr-hash.js","s":{"1":1,"2":9,"3":9,"4":9,"5":9,"6":12,"7":9,"8":1},"b":{},"f":{"1":9},"fnMap":{"1":{"name":"(anonymous_1)","line":7,"loc":{"start":{"line":7,"column":15},"end":{"line":7,"column":29}}}},"statementMap":{"1":{"start":{"line":7,"column":0},"end":{"line":17,"column":2}},"2":{"start":{"line":8,"column":4},"end":{"line":8,"column":19}},"3":{"start":{"line":9,"column":4},"end":{"line":9,"column":17}},"4":{"start":{"line":10,"column":4},"end":{"line":10,"column":48}},"5":{"start":{"line":11,"column":4},"end":{"line":15,"column":5}},"6":{"start":{"line":14,"column":8},"end":{"line":14,"column":47}},"7":{"start":{"line":16,"column":4},"end":{"line":16,"column":16}},"8":{"start":{"line":19,"column":0},"end":{"line":19,"column":26}}},"branchMap":{}},"/home/zenozeng/home/code/color-hash/lib/color-hash.js":{"path":"/home/zenozeng/home/code/color-hash/lib/color-hash.js","s":{"1":2,"2":2,"3":6,"4":6,"5":6,"6":6,"7":18,"8":3,"9":18,"10":1,"11":18,"12":4,"13":14,"14":6,"15":8,"16":1,"17":7,"18":18,"19":2,"20":6,"21":6,"22":12,"23":12,"24":6,"25":6,"26":6,"27":2,"28":7,"29":7,"30":7,"31":7,"32":7,"33":7,"34":7,"35":7,"36":2,"37":2,"38":2,"39":2,"40":1,"41":1,"42":2},"b":{"1":[3,3],"2":[3,15],"3":[1,17],"4":[4,14],"5":[6,8],"6":[1,7],"7":[6,3],"8":[12,8],"9":[10,2],"10":[6,5]},"f":{"1":6,"2":18,"3":6,"4":12,"5":7,"6":2,"7":1},"fnMap":{"1":{"name":"(anonymous_1)","line":12,"loc":{"start":{"line":12,"column":14},"end":{"line":12,"column":32}}},"2":{"name":"(anonymous_2)","line":18,"loc":{"start":{"line":18,"column":37},"end":{"line":18,"column":53}}},"3":{"name":"(anonymous_3)","line":43,"loc":{"start":{"line":43,"column":16},"end":{"line":43,"column":34}}},"4":{"name":"(anonymous_4)","line":46,"loc":{"start":{"line":46,"column":57},"end":{"line":46,"column":73}}},"5":{"name":"(anonymous_5)","line":64,"loc":{"start":{"line":64,"column":26},"end":{"line":64,"column":40}}},"6":{"name":"(anonymous_6)","line":84,"loc":{"start":{"line":84,"column":26},"end":{"line":84,"column":40}}},"7":{"name":"(anonymous_7)","line":95,"loc":{"start":{"line":95,"column":26},"end":{"line":95,"column":40}}}},"statementMap":{"1":{"start":{"line":1,"column":0},"end":{"line":1,"column":38}},"2":{"start":{"line":12,"column":0},"end":{"line":36,"column":2}},"3":{"start":{"line":13,"column":4},"end":{"line":13,"column":13}},"4":{"start":{"line":15,"column":4},"end":{"line":15,"column":50}},"5":{"start":{"line":16,"column":4},"end":{"line":16,"column":22}},"6":{"start":{"line":18,"column":4},"end":{"line":35,"column":7}},"7":{"start":{"line":19,"column":8},"end":{"line":21,"column":9}},"8":{"start":{"line":20,"column":12},"end":{"line":20,"column":20}},"9":{"start":{"line":22,"column":8},"end":{"line":24,"column":9}},"10":{"start":{"line":23,"column":12},"end":{"line":23,"column":20}},"11":{"start":{"line":25,"column":8},"end":{"line":33,"column":9}},"12":{"start":{"line":26,"column":12},"end":{"line":26,"column":44}},"13":{"start":{"line":27,"column":15},"end":{"line":33,"column":9}},"14":{"start":{"line":28,"column":12},"end":{"line":28,"column":22}},"15":{"start":{"line":29,"column":15},"end":{"line":33,"column":9}},"16":{"start":{"line":30,"column":12},"end":{"line":30,"column":52}},"17":{"start":{"line":32,"column":12},"end":{"line":32,"column":22}},"18":{"start":{"line":34,"column":8},"end":{"line":34,"column":39}},"19":{"start":{"line":43,"column":0},"end":{"line":55,"column":2}},"20":{"start":{"line":44,"column":4},"end":{"line":44,"column":28}},"21":{"start":{"line":46,"column":4},"end":{"line":49,"column":7}},"22":{"start":{"line":47,"column":8},"end":{"line":47,"column":43}},"23":{"start":{"line":48,"column":8},"end":{"line":48,"column":101}},"24":{"start":{"line":51,"column":4},"end":{"line":51,"column":19}},"25":{"start":{"line":52,"column":4},"end":{"line":52,"column":19}},"26":{"start":{"line":54,"column":4},"end":{"line":54,"column":41}},"27":{"start":{"line":64,"column":0},"end":{"line":75,"column":2}},"28":{"start":{"line":65,"column":4},"end":{"line":65,"column":16}},"29":{"start":{"line":66,"column":4},"end":{"line":66,"column":30}},"30":{"start":{"line":68,"column":4},"end":{"line":68,"column":19}},"31":{"start":{"line":69,"column":4},"end":{"line":69,"column":32}},"32":{"start":{"line":70,"column":4},"end":{"line":70,"column":37}},"33":{"start":{"line":71,"column":4},"end":{"line":71,"column":42}},"34":{"start":{"line":72,"column":4},"end":{"line":72,"column":37}},"35":{"start":{"line":74,"column":4},"end":{"line":74,"column":21}},"36":{"start":{"line":84,"column":0},"end":{"line":87,"column":2}},"37":{"start":{"line":85,"column":4},"end":{"line":85,"column":28}},"38":{"start":{"line":86,"column":4},"end":{"line":86,"column":36}},"39":{"start":{"line":95,"column":0},"end":{"line":98,"column":2}},"40":{"start":{"line":96,"column":4},"end":{"line":96,"column":28}},"41":{"start":{"line":97,"column":4},"end":{"line":97,"column":81}},"42":{"start":{"line":100,"column":0},"end":{"line":100,"column":27}}},"branchMap":{"1":{"line":15,"type":"cond-expr","locations":[{"start":{"line":15,"column":22},"end":{"line":15,"column":33}},{"start":{"line":15,"column":36},"end":{"line":15,"column":49}}]},"2":{"line":19,"type":"if","locations":[{"start":{"line":19,"column":8},"end":{"line":19,"column":8}},{"start":{"line":19,"column":8},"end":{"line":19,"column":8}}]},"3":{"line":22,"type":"if","locations":[{"start":{"line":22,"column":8},"end":{"line":22,"column":8}},{"start":{"line":22,"column":8},"end":{"line":22,"column":8}}]},"4":{"line":25,"type":"if","locations":[{"start":{"line":25,"column":8},"end":{"line":25,"column":8}},{"start":{"line":25,"column":8},"end":{"line":25,"column":8}}]},"5":{"line":27,"type":"if","locations":[{"start":{"line":27,"column":15},"end":{"line":27,"column":15}},{"start":{"line":27,"column":15},"end":{"line":27,"column":15}}]},"6":{"line":29,"type":"if","locations":[{"start":{"line":29,"column":15},"end":{"line":29,"column":15}},{"start":{"line":29,"column":15},"end":{"line":29,"column":15}}]},"7":{"line":44,"type":"binary-expr","locations":[{"start":{"line":44,"column":14},"end":{"line":44,"column":21}},{"start":{"line":44,"column":25},"end":{"line":44,"column":27}}]},"8":{"line":47,"type":"binary-expr","locations":[{"start":{"line":47,"column":16},"end":{"line":47,"column":21}},{"start":{"line":47,"column":25},"end":{"line":47,"column":42}}]},"9":{"line":48,"type":"cond-expr","locations":[{"start":{"line":48,"column":76},"end":{"line":48,"column":90}},{"start":{"line":48,"column":93},"end":{"line":48,"column":100}}]},"10":{"line":54,"type":"binary-expr","locations":[{"start":{"line":54,"column":16},"end":{"line":54,"column":28}},{"start":{"line":54,"column":32},"end":{"line":54,"column":40}}]}}}}
+{"/home/zenozeng/home/code/color-hash/lib/bkdr-hash.js":{"path":"/home/zenozeng/home/code/color-hash/lib/bkdr-hash.js","s":{"1":1,"2":12,"3":12,"4":12,"5":12,"6":360012,"7":359982,"8":360012,"9":12,"10":1},"b":{"1":[359982,30]},"f":{"1":12},"fnMap":{"1":{"name":"(anonymous_1)","line":7,"loc":{"start":{"line":7,"column":15},"end":{"line":7,"column":29}}}},"statementMap":{"1":{"start":{"line":7,"column":0},"end":{"line":18,"column":2}},"2":{"start":{"line":8,"column":4},"end":{"line":8,"column":19}},"3":{"start":{"line":9,"column":4},"end":{"line":9,"column":17}},"4":{"start":{"line":10,"column":4},"end":{"line":10,"column":68}},"5":{"start":{"line":11,"column":4},"end":{"line":16,"column":5}},"6":{"start":{"line":12,"column":8},"end":{"line":14,"column":9}},"7":{"start":{"line":13,"column":12},"end":{"line":13,"column":41}},"8":{"start":{"line":15,"column":8},"end":{"line":15,"column":47}},"9":{"start":{"line":17,"column":4},"end":{"line":17,"column":16}},"10":{"start":{"line":20,"column":0},"end":{"line":20,"column":26}}},"branchMap":{"1":{"line":12,"type":"if","locations":[{"start":{"line":12,"column":8},"end":{"line":12,"column":8}},{"start":{"line":12,"column":8},"end":{"line":12,"column":8}}]}}},"/home/zenozeng/home/code/color-hash/lib/color-hash.js":{"path":"/home/zenozeng/home/code/color-hash/lib/color-hash.js","s":{"1":2,"2":2,"3":6,"4":6,"5":6,"6":6,"7":18,"8":3,"9":18,"10":1,"11":18,"12":4,"13":14,"14":6,"15":8,"16":1,"17":7,"18":18,"19":2,"20":6,"21":6,"22":12,"23":12,"24":6,"25":6,"26":6,"27":2,"28":7,"29":7,"30":7,"31":7,"32":7,"33":7,"34":7,"35":7,"36":2,"37":2,"38":2,"39":2,"40":1,"41":1,"42":2},"b":{"1":[3,3],"2":[3,15],"3":[1,17],"4":[4,14],"5":[6,8],"6":[1,7],"7":[6,3],"8":[12,8],"9":[10,2],"10":[6,5]},"f":{"1":6,"2":18,"3":6,"4":12,"5":7,"6":2,"7":1},"fnMap":{"1":{"name":"(anonymous_1)","line":12,"loc":{"start":{"line":12,"column":14},"end":{"line":12,"column":32}}},"2":{"name":"(anonymous_2)","line":18,"loc":{"start":{"line":18,"column":37},"end":{"line":18,"column":53}}},"3":{"name":"(anonymous_3)","line":43,"loc":{"start":{"line":43,"column":16},"end":{"line":43,"column":34}}},"4":{"name":"(anonymous_4)","line":46,"loc":{"start":{"line":46,"column":57},"end":{"line":46,"column":73}}},"5":{"name":"(anonymous_5)","line":64,"loc":{"start":{"line":64,"column":26},"end":{"line":64,"column":40}}},"6":{"name":"(anonymous_6)","line":84,"loc":{"start":{"line":84,"column":26},"end":{"line":84,"column":40}}},"7":{"name":"(anonymous_7)","line":95,"loc":{"start":{"line":95,"column":26},"end":{"line":95,"column":40}}}},"statementMap":{"1":{"start":{"line":1,"column":0},"end":{"line":1,"column":38}},"2":{"start":{"line":12,"column":0},"end":{"line":36,"column":2}},"3":{"start":{"line":13,"column":4},"end":{"line":13,"column":13}},"4":{"start":{"line":15,"column":4},"end":{"line":15,"column":50}},"5":{"start":{"line":16,"column":4},"end":{"line":16,"column":22}},"6":{"start":{"line":18,"column":4},"end":{"line":35,"column":7}},"7":{"start":{"line":19,"column":8},"end":{"line":21,"column":9}},"8":{"start":{"line":20,"column":12},"end":{"line":20,"column":20}},"9":{"start":{"line":22,"column":8},"end":{"line":24,"column":9}},"10":{"start":{"line":23,"column":12},"end":{"line":23,"column":20}},"11":{"start":{"line":25,"column":8},"end":{"line":33,"column":9}},"12":{"start":{"line":26,"column":12},"end":{"line":26,"column":44}},"13":{"start":{"line":27,"column":15},"end":{"line":33,"column":9}},"14":{"start":{"line":28,"column":12},"end":{"line":28,"column":22}},"15":{"start":{"line":29,"column":15},"end":{"line":33,"column":9}},"16":{"start":{"line":30,"column":12},"end":{"line":30,"column":52}},"17":{"start":{"line":32,"column":12},"end":{"line":32,"column":22}},"18":{"start":{"line":34,"column":8},"end":{"line":34,"column":39}},"19":{"start":{"line":43,"column":0},"end":{"line":55,"column":2}},"20":{"start":{"line":44,"column":4},"end":{"line":44,"column":28}},"21":{"start":{"line":46,"column":4},"end":{"line":49,"column":7}},"22":{"start":{"line":47,"column":8},"end":{"line":47,"column":43}},"23":{"start":{"line":48,"column":8},"end":{"line":48,"column":101}},"24":{"start":{"line":51,"column":4},"end":{"line":51,"column":19}},"25":{"start":{"line":52,"column":4},"end":{"line":52,"column":19}},"26":{"start":{"line":54,"column":4},"end":{"line":54,"column":41}},"27":{"start":{"line":64,"column":0},"end":{"line":75,"column":2}},"28":{"start":{"line":65,"column":4},"end":{"line":65,"column":16}},"29":{"start":{"line":66,"column":4},"end":{"line":66,"column":30}},"30":{"start":{"line":68,"column":4},"end":{"line":68,"column":19}},"31":{"start":{"line":69,"column":4},"end":{"line":69,"column":32}},"32":{"start":{"line":70,"column":4},"end":{"line":70,"column":37}},"33":{"start":{"line":71,"column":4},"end":{"line":71,"column":42}},"34":{"start":{"line":72,"column":4},"end":{"line":72,"column":37}},"35":{"start":{"line":74,"column":4},"end":{"line":74,"column":21}},"36":{"start":{"line":84,"column":0},"end":{"line":87,"column":2}},"37":{"start":{"line":85,"column":4},"end":{"line":85,"column":28}},"38":{"start":{"line":86,"column":4},"end":{"line":86,"column":36}},"39":{"start":{"line":95,"column":0},"end":{"line":98,"column":2}},"40":{"start":{"line":96,"column":4},"end":{"line":96,"column":28}},"41":{"start":{"line":97,"column":4},"end":{"line":97,"column":81}},"42":{"start":{"line":100,"column":0},"end":{"line":100,"column":27}}},"branchMap":{"1":{"line":15,"type":"cond-expr","locations":[{"start":{"line":15,"column":22},"end":{"line":15,"column":33}},{"start":{"line":15,"column":36},"end":{"line":15,"column":49}}]},"2":{"line":19,"type":"if","locations":[{"start":{"line":19,"column":8},"end":{"line":19,"column":8}},{"start":{"line":19,"column":8},"end":{"line":19,"column":8}}]},"3":{"line":22,"type":"if","locations":[{"start":{"line":22,"column":8},"end":{"line":22,"column":8}},{"start":{"line":22,"column":8},"end":{"line":22,"column":8}}]},"4":{"line":25,"type":"if","locations":[{"start":{"line":25,"column":8},"end":{"line":25,"column":8}},{"start":{"line":25,"column":8},"end":{"line":25,"column":8}}]},"5":{"line":27,"type":"if","locations":[{"start":{"line":27,"column":15},"end":{"line":27,"column":15}},{"start":{"line":27,"column":15},"end":{"line":27,"column":15}}]},"6":{"line":29,"type":"if","locations":[{"start":{"line":29,"column":15},"end":{"line":29,"column":15}},{"start":{"line":29,"column":15},"end":{"line":29,"column":15}}]},"7":{"line":44,"type":"binary-expr","locations":[{"start":{"line":44,"column":14},"end":{"line":44,"column":21}},{"start":{"line":44,"column":25},"end":{"line":44,"column":27}}]},"8":{"line":47,"type":"binary-expr","locations":[{"start":{"line":47,"column":16},"end":{"line":47,"column":21}},{"start":{"line":47,"column":25},"end":{"line":47,"column":42}}]},"9":{"line":48,"type":"cond-expr","locations":[{"start":{"line":48,"column":76},"end":{"line":48,"column":90}},{"start":{"line":48,"column":93},"end":{"line":48,"column":100}}]},"10":{"line":54,"type":"binary-expr","locations":[{"start":{"line":54,"column":16},"end":{"line":54,"column":28}},{"start":{"line":54,"column":32},"end":{"line":54,"column":40}}]}}}}

lib/bkdr-hash.js

@@ -10,6 +10,7 @@ /**
     var hash = 0;
-    var max = parseInt(9007199254740991 / seed); // Number.MAX_SAFE_INTEGER equals  9007199254740991
+    var MAX_SAFE_INTEGER = parseInt(9007199254740991 / seed / seed); // Number.MAX_SAFE_INTEGER equals  9007199254740991
     for(var i = 0; i < str.length; i++) {
-        // if(hash > max) {
-        // }
+        if(hash > MAX_SAFE_INTEGER) {
+            hash = parseInt(hash / seed);
+        }
         hash = hash * seed + str.charCodeAt(i);
@@ -16,0 +17,0 @@ }

package.json

 {
     "name": "color-hash",
-    "version": "0.1.2",
+    "version": "0.1.3",
     "description": "Generate color based on the given string (using HSL color space and BKDRHash).",
@@ -5,0 +5,0 @@ "main": "lib/color-hash.js",

README.md

@@ -119,6 +119,4 @@ # Color Hash
 
-100% coverage 47 SLOC
+https://zenozeng.github.io/color-hash/coverage/lcov-report/lib/index.html
 
-https://zenozeng.github.io/color-hash/test/coverage.html
-
 ### Build browser js
@@ -125,0 +123,0 @@

test/bkdr-hash.js

@@ -9,2 +9,22 @@ var BKDRHash = require('../lib/bkdr-hash.js');
     });
+
+    it('should work even if the string is very long', function() {
+        var longstr = '';
+        for(var i = 0; i < 10 * 1000; i++) {
+            longstr += "Hello World.";
+        };
+        var hash = BKDRHash(longstr);
+        assert.notEqual(hash, Infinity);
+        assert.notEqual(hash, 0);
+    });
+
+    it('should return different value for different long string', function() {
+        var longstr = '';
+        for(var i = 0; i < 10 * 1000; i++) {
+            longstr += "Hello World.";
+        };
+        var hash1 = BKDRHash(longstr);
+        var hash2 = BKDRHash(longstr.substring(0, longstr.length - 1) + 'x');
+        assert.notEqual(hash1, hash2);
+    });
 });

No alert changes

Improved metrics

Total package byte prevSize

73580

increased by1.83%

Number of package files

24

increased by4.35%

Lines of code

705

increased by2.77%

Worsened metrics

Number of lines in readme file

131

decreased by-1.5%

No dependency changes