core-validate-commit - npm Package Compare versions

Comparing version 3.19.0 to 3.20.0

lib/format-tap.js

@@ -47,3 +47,3 @@ 'use strict'
       column: m.column || 0,
-      body: body
+      body
     }
@@ -50,0 +50,0 @@ })

lib/index.js

@@ -57,3 +57,3 @@ 'use strict'
         this.emit('commit', {
-          commit: commit,
+          commit,
           messages: this.messages.get(commit.sha) || []
@@ -60,0 +60,0 @@ })

lib/rules/co-authored-by-is-trailer.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -28,3 +28,3 @@ description: 'enforce that "Co-authored-by:" lines are trailers',
         context.report({
-          id: id,
+          id,
           message: 'Co-authored-by is a trailer',
@@ -36,3 +36,3 @@ string: '',
         context.report({
-          id: id,
+          id,
           message: 'Co-authored-by must be a trailer',
@@ -47,3 +47,3 @@ string: firstCoauthor[0],
       context.report({
-        id: id,
+        id,
         message: 'no Co-authored-by metadata',
@@ -50,0 +50,0 @@ string: '',

lib/rules/fixes-url.js

@@ -9,3 +9,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -21,3 +21,3 @@ description: 'enforce format of Fixes URLs',
       context.report({
-        id: id,
+        id,
         message: 'skipping fixes-url',
@@ -38,7 +38,7 @@ string: '',
         context.report({
-          id: id,
+          id,
           message: 'Fixes must be a URL, not an issue number.',
           string: url,
-          line: line,
-          column: column,
+          line,
+          column,
           level: 'fail'
@@ -50,7 +50,7 @@ })
           context.report({
-            id: id,
+            id,
             message: 'Pull request URL must reference a comment or discussion.',
             string: url,
-            line: line,
-            column: column,
+            line,
+            column,
             level: 'fail'
@@ -61,7 +61,7 @@ })
           context.report({
-            id: id,
+            id,
             message: 'Valid fixes URL.',
             string: url,
-            line: line,
-            column: column,
+            line,
+            column,
             level: 'pass'
@@ -73,7 +73,7 @@ })
         context.report({
-          id: id,
+          id,
           message: 'Fixes must be a GitHub URL.',
           string: url,
-          line: line,
-          column: column,
+          line,
+          column,
           level: 'fail'
@@ -80,0 +80,0 @@ })

lib/rules/line-after-title.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -18,3 +18,3 @@ description: 'enforce a blank newline after the commit title',
       context.report({
-        id: id,
+        id,
         message: 'blank line expected after title',
@@ -30,3 +30,3 @@ string: context.body.length ? context.body[0] : '',
     context.report({
-      id: id,
+      id,
       message: 'blank line after title',
@@ -33,0 +33,0 @@ string: '',

lib/rules/line-length.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -25,3 +25,3 @@ description: 'enforce max length of lines in commit body',
       context.report({
-        id: id,
+        id,
         message: 'skipping line-length for release commit',
@@ -43,3 +43,3 @@ string: '',
         context.report({
-          id: id,
+          id,
           message: `Line should be <= ${len} columns.`,
@@ -57,3 +57,3 @@ string: line,
       context.report({
-        id: id,
+        id,
         message: 'line-lengths are valid',
@@ -60,0 +60,0 @@ string: '',

lib/rules/metadata-end.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -30,3 +30,3 @@ description: 'enforce that metadata is at the end of commit messages',
         context.report({
-          id: id,
+          id,
           message: 'commit metadata at end of message',
@@ -43,3 +43,3 @@ string: body[lineNum],
     context.report({
-      id: id,
+      id,
       message: 'metadata is at end of message',
@@ -46,0 +46,0 @@ string: '',

lib/rules/pr-url.js

@@ -7,3 +7,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -18,3 +18,3 @@ description: 'enforce PR-URL',
       context.report({
-        id: id,
+        id,
         message: 'Commit must have a PR-URL.',
@@ -41,7 +41,7 @@ string: context.prUrl,
       context.report({
-        id: id,
+        id,
         message: 'PR-URL must be a URL, not a pull request number.',
         string: context.prUrl,
-        line: line,
-        column: column,
+        line,
+        column,
         level: 'fail'
@@ -51,7 +51,7 @@ })
       context.report({
-        id: id,
+        id,
         message: 'PR-URL must be a GitHub pull request URL.',
         string: context.prUrl,
-        line: line,
-        column: column,
+        line,
+        column,
         level: 'fail'
@@ -61,7 +61,7 @@ })
       context.report({
-        id: id,
+        id,
         message: 'PR-URL is valid.',
         string: context.prUrl,
-        line: line,
-        column: column,
+        line,
+        column,
         level: 'pass'
@@ -68,0 +68,0 @@ })

lib/rules/reviewers.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -19,3 +19,3 @@ description: 'enforce having reviewers',
       context.report({
-        id: id,
+        id,
         message: 'skipping reviewers for release commit',
@@ -32,3 +32,3 @@ string: '',
       return context.report({
-        id: id,
+        id,
         message: 'Commit must have at least 1 reviewer.',
@@ -48,3 +48,3 @@ string: null,
     context.report({
-      id: id,
+      id,
       message: 'reviewers are valid',
@@ -51,0 +51,0 @@ string: '',

lib/rules/subsystem.js

@@ -26,2 +26,3 @@ 'use strict'
   'policy',
+  'sea',
   'src',
@@ -85,3 +86,3 @@ 'test',
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -104,3 +105,3 @@ description: 'enforce subsystem validity',
         context.report({
-          id: id,
+          id,
           message: 'Missing subsystem.',
@@ -115,3 +116,3 @@ string: parsed.title,
         context.report({
-          id: id,
+          id,
           message: 'Release commits do not have subsystems',
@@ -130,7 +131,7 @@ string: '',
           context.report({
-            id: id,
+            id,
             message: `Invalid subsystem: "${sub}"`,
             string: parsed.title,
             line: 0,
-            column: column,
+            column,
             level: 'fail',
@@ -144,3 +145,3 @@ wanted: subs
         context.report({
-          id: id,
+          id,
           message: 'valid subsystems',
@@ -147,0 +148,0 @@ string: parsed.subsystems.join(','),

lib/rules/title-format.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -17,7 +17,8 @@ description: 'enforce commit title format',
       ? context.title.substr(revertPrefixLength,
-        context.title.length - revertPrefixLength - 1) : context.title
+        context.title.length - revertPrefixLength - 1)
+      : context.title
     let pass = true
     if (/[.?!]$/.test(titleWithoutRevertPrefix)) {
       context.report({
-        id: id,
+        id,
         message: 'Do not use punctuation at end of title.',
@@ -36,3 +37,3 @@ string: context.title,
         context.report({
-          id: id,
+          id,
           message: 'Add a space after subsystem(s).',
@@ -52,3 +53,3 @@ string: context.title,
         context.report({
-          id: id,
+          id,
           message: 'Do not use consecutive spaces in title.',
@@ -69,3 +70,3 @@ string: context.title,
         context.report({
-          id: id,
+          id,
           message: 'First word after subsystem(s) in title should be lowercase.',
@@ -83,3 +84,3 @@ string: context.title,
       context.report({
-        id: id,
+        id,
         message: 'Title is formatted correctly.',
@@ -86,0 +87,0 @@ string: '',

lib/rules/title-length.js

@@ -6,3 +6,3 @@ 'use strict'
 module.exports = {
-  id: id,
+  id,
   meta: {
@@ -25,3 +25,3 @@ description: 'enforce max length of commit title',
       context.report({
-        id: id,
+        id,
         message: `Title must be <= ${max} columns.`,
@@ -40,3 +40,3 @@ string: context.title,
       context.report({
-        id: id,
+        id,
         message: `Title should be <= ${len} columns.`,
@@ -53,3 +53,3 @@ string: context.title,
     context.report({
-      id: id,
+      id,
       message: `Title is <= ${len} columns.`,
@@ -56,0 +56,0 @@ string: '',

package.json

 {
   "name": "core-validate-commit",
-  "version": "3.19.0",
+  "version": "3.20.0",
   "description": "Validate the commit message for a particular commit in node core",
@@ -13,11 +13,11 @@ "main": "index.js",
   "dependencies": {
-    "chalk": "^3.0.0",
+    "chalk": "^4.1.2",
     "gitlint-parser-node": "^1.1.0",
     "help": "^3.0.2",
-    "nopt": "^4.0.1"
+    "nopt": "^6.0.0"
   },
   "devDependencies": {
     "check-pkg": "^2.1.1",
-    "standard": "^14.3.4",
-    "tap": "^15.2.3"
+    "standard": "^17.0.0",
+    "tap": "^16.3.4"
   },
@@ -24,0 +24,0 @@ "files": [

No alert changes

Improved metrics

Lines of code

1199

increased by0.17%

Worsened metrics

Total package byte prevSize

33207

decreased by-0.84%

Dependency changes

• + Addedchalk@4.1.2(transitive)

• + Addednopt@6.0.0(transitive)

• - Removedchalk@3.0.0(transitive)

• - Removednopt@4.0.3(transitive)

• - Removedos-homedir@1.0.2(transitive)

• - Removedos-tmpdir@1.0.2(transitive)

• - Removedosenv@0.1.5(transitive)

• Updatedchalk@^4.1.2

• Updatednopt@^6.0.0