derby-templates - npm Package Compare versions

Comparing version 0.8.3 to 0.8.4

lib/templates.js

@@ -589,3 +589,9 @@ var saddle = require('saddle');
   };
-  context.controller.dom.on(this.name, element, listener, false);
+  // Using `context.controller.dom.on` would be better for garbage collection,
+  // but since it synchronously removes listeners on component destroy, it would
+  // break existing code relying on `on-*` listeners firing as a component is
+  // being destroyed. Even with `addEventListener`, browsers should still GC
+  // the listeners once there are no references to the element.
+  element.addEventListener(this.name, listener, false);
+  // context.controller.dom.on(this.name, element, listener, false);
 };
@@ -592,0 +598,0 @@ ElementOn.prototype.apply = function(context, element, event) {

package.json

 {
   "name": "derby-templates",
-  "version": "0.8.3",
+  "version": "0.8.4",
   "main": "index.js",
@@ -5,0 +5,0 @@ "scripts": {

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

72488

increased by0.61%

Lines of code

1861

increased by0.32%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes