ebay-api - npm Package Compare versions

Comparing version 1.9.0 to 1.9.1

lib/errors.js

@@ -15,3 +15,4 @@ /**
   this.name = this.constructor.name;
-  _.extend(this, {message: message}, extraProps);
+  this.message = message;
+  _.extend(this, _.omit(extraProps, ['name', 'message']));
 }
@@ -18,0 +19,0 @@ inherits(EbayClientError, Error);

package.json

 {
   "name": "ebay-api",
   "description": "eBay API Client",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "homepage": "https://github.com/benbuckman/nodejs-ebay-api",
@@ -6,0 +6,0 @@ "author": "Ben Buckman",

test/errors.test.js

@@ -61,4 +61,15 @@ require('./helpers');
 
+      it('can\'t overwrite base properties with extra properties', function() {
+        var err = new errorClass('Original message', {
+          message: 'New message',
+          name: 'UhOh'
+        });
+
+        expect(err.message).to.equal('Original message');
+        expect(err.name).to.equal(errorClassName);
+
+      });
+
     });
   });
 });

No alert changes

Improved metrics

Total package byte prevSize

99020

increased by0.37%

Lines of code

1681

increased by0.54%

No dependency changes