electron-comrade - npm Package Compare versions

Comparing version 0.1.0 to 0.2.0

dist/utils/app-folder.js

@@ -17,3 +17,3 @@ "use strict";
     }
-    if (process.platform === 'win32') {
+    else {
         return path.join(input, 'resources');
@@ -25,8 +25,8 @@ }
     return __awaiter(this, void 0, void 0, function* () {
-        if (process.platform === 'win32') {
-            return getAppFolderWin(options);
-        }
         if (process.platform === 'darwin') {
             return getAppFolderMac(options);
         }
+        else {
+            return getAppFolderNonMac(options);
+        }
     });
@@ -43,3 +43,3 @@ }
 exports.getAppFolderMac = getAppFolderMac;
-function getAppFolderWin({ app }) {
+function getAppFolderNonMac({ app }) {
     return __awaiter(this, void 0, void 0, function* () {
@@ -52,3 +52,3 @@ const contents = yield fs.readdir(app);
 }
-exports.getAppFolderWin = getAppFolderWin;
+exports.getAppFolderNonMac = getAppFolderNonMac;
 //# sourceMappingURL=app-folder.js.map

dist/utils/args.js

@@ -5,4 +5,6 @@ "use strict";
 const fs = require("fs-extra");
+const path = require("path");
 const electron_folder_1 = require("./electron-folder");
 const help_1 = require("./help");
+const electron_bin_1 = require("./electron-bin");
 function parseArguments(argv = process.argv) {
@@ -33,2 +35,7 @@ const parsed = clp(argv);
     }
+    const electronBin = path.join(result.electron, electron_bin_1.getElectronBin());
+    const electronBinExists = fs.existsSync(electronBin);
+    if (!electron_folder_1.isVersion(result.electron) && !electronBinExists) {
+        errors.push(`Could not find Electron binary. Looked for:\n${electronBin}`);
+    }
     if (!fs.existsSync(result.app)) {
@@ -35,0 +42,0 @@ errors.push(`Specified app path does not exist: ${result.app}.`);

dist/utils/electron-bin.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 function getElectronBin() {
-    if (process.platform === 'win32') {
-        return 'electron.exe';
+    switch (process.platform) {
+        case 'win32': return 'electron.exe';
+        case 'darwin': return `Electron.app/Contents/MacOS/Electron`;
+        default: return 'electron';
     }
-    if (process.platform === 'darwin') {
-        return `Electron.app/Contents/MacOS/Electron`;
-    }
 }
 exports.getElectronBin = getElectronBin;
 //# sourceMappingURL=electron-bin.js.map

package.json

 {
   "name": "electron-comrade",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "",
@@ -29,6 +29,2 @@ "main": "dist/index.js",
   },
-  "os": [
-    "win32",
-    "darwin"
-  ],
   "homepage": "https://github.com/felixrieseberg/electron-comrade#readme",
@@ -38,14 +34,14 @@ "devDependencies": {
     "@types/extract-zip": "^1.6.2",
-    "@types/fs-extra": "^5.0.2",
+    "@types/fs-extra": "^5.0.4",
     "@types/jest": "^22.2.3",
     "@types/node": "^6.0.111",
     "@types/semver": "^5.5.0",
-    "jest": "^23.0.1",
-    "ts-jest": "^22.4.6",
-    "tslint": "^5.10.0",
-    "tslint-microsoft-contrib": "^5.0.3",
-    "typescript": "^2.8.3"
+    "jest": "^23.6.0",
+    "ts-jest": "^23.10.5",
+    "tslint": "^5.12.1",
+    "tslint-microsoft-contrib": "^6.0.0",
+    "typescript": "^3.2.4"
   },
   "dependencies": {
-    "clp": "^4.0.10",
+    "clp": "^4.0.11",
     "electron-download": "^4.1.1",
@@ -52,0 +48,0 @@ "extract-zip": "^1.6.7",

README.md

@@ -22,2 +22,3 @@ # Electron Comrade
 Windows:
+
 ```powershell
@@ -27,3 +28,4 @@ electron-comrade --electron 3.0.9 --app ~\AppData\Local\slack\app-3.3.4\
 
-macOS
+macOS:
+
 ```sh
@@ -33,2 +35,8 @@ electron-comrade --electron 3.0.9 --app /Applications/Slack.app
 
+Linux:
+
+```sh
+electron-comrade --electron 3.0.9 --app /usr/lib/slack
+```
+
 Running an installed app with a local build of Electron:
@@ -35,0 +43,0 @@

No alert changes

Improved metrics

Total package byte prevSize

30905

increased by2.91%

Lines of code

406

increased by1.5%

Number of lines in readme file

67

increased by13.56%

Dependency changes

• Updatedclp@^4.0.11