ember-cli-nouislider - npm Package Compare versions

Comparing version 0.14.1 to 1.0.0-rc.1

addon/components/range-slider.js

@@ -0,1 +1,8 @@
+/* eslint ember/closure-actions: 0 */
+
+import { A } from '@ember/array';
+import Component from '@ember/component';
+import { run } from '@ember/runloop';
+import { isEmpty } from '@ember/utils';
+import { observer, computed } from '@ember/object';
 import Ember from 'ember';
@@ -5,11 +12,6 @@ import noUiSlider from 'noUiSlider';
 const {
-  on,
-  run,
-  isEmpty,
-  computed,
-  observer,
   Logger: { warn }
 } = Ember;
 
-export default Ember.Component.extend({
+export default Component.extend({
   attributeBindings: ['disabledOrUndefined:disabled'],
@@ -42,5 +44,10 @@ slider:       null,
 
-  formatTo(value) { return value; },
-  formatFrom(value) { return +value; },
+  formatTo(value) {
+    return value;
+  },
 
+  formatFrom(value) {
+    return +value;
+  },
+
   format: computed('formatTo', 'formatFrom', function() {
@@ -53,4 +60,9 @@ return {
 
-  setup: on('didInsertElement', function() {
-    let $this = this.$().get(0);
+  didInsertElement() {
+    this.setup();
+  },
+
+  setup() {
+    let element = this.get('element');
+    let { noUiSlider: slider } = element;
     let properties = this.getProperties(
@@ -64,11 +76,11 @@ 'start', 'step', 'margin',
     );
-    let sliderEvents = Ember.A(['change', 'set', 'slide', 'update', 'start', 'end']);
+    let sliderEvents = A(['change', 'set', 'slide', 'update', 'start', 'end']);
 
     // We first check if the element has a slider already created
-    if ($this.noUiSlider && $this.noUiSlider.destroy) {
-      $this.noUiSlider.destroy();
+    if (slider && slider.destroy) {
+      slider.destroy();
     }
 
     try {
-      noUiSlider.create($this, properties, true);
+      slider = noUiSlider.create(element, properties, true);
     } catch (err) {
@@ -78,40 +90,39 @@ warn(`[ember-cli-nouislider]: ${err}`);
 
-    let slider = $this.noUiSlider;
+    this.slider = slider;
 
-    // We set slider next sync cycle to avoid deprecation warnings
-    run.schedule('sync', () => {
-      this.set('slider', slider);
+    sliderEvents.forEach(event => {
+      if (!isEmpty(this.get(`on-${event}`))) {
+        slider.on(event, () => {
+          run(this, function() {
+            let val = this.get("slider").get();
+            this.sendAction(`on-${event}`, val);
+          });
+        });
+      }
+    });
 
-      sliderEvents.forEach(event => {
-        if (!isEmpty(this.get(`on-${event}`))) {
-          slider.on(event, () => {
-            run(this, function() {
-              let val = this.get("slider").get();
-              this.sendAction(`on-${event}`, val);
-            });
-          });
-        }
+    /** DEPRECATED AND WILL BE REMOVED BEFORE 1.0 **/
+    slider.on('change', () => {
+      run(this, function () {
+          let val = this.get("slider").get();
+          this.sendDeprecatedAction("change", val);
       });
+    });
 
-      /** DEPRECATED AND WILL BE REMOVED BEFORE 1.0 **/
-      slider.on('change', () => {
+    if (!isEmpty(this.get('slide'))) {
+      slider.on('slide', () => {
         run(this, function () {
-            let val = this.get("slider").get();
-            this.sendDeprecatedAction("change", val);
+          let val = this.get("slider").get();
+          this.sendDeprecatedAction('slide', val);
         });
       });
+    }
+  },
 
-      if (!isEmpty(this.get('slide'))) {
-        slider.on('slide', () => {
-          run(this, function () {
-            let val = this.get("slider").get();
-            this.sendDeprecatedAction('slide', val);
-          });
-        });
-      }
-    });
-  }),
+  didUpdateAttrs() {
+    this.update();
+  },
 
-  update: on('didUpdateAttrs', function() {
-    let slider = this.get('slider');
+  update() {
+    let { slider } = this;
     let properties = this.getProperties(
@@ -126,7 +137,11 @@ 'margin', 'limit', 'step',
     }
-  }),
+  },
 
-  teardown: on('willDestroyElement', function() {
-    var slider = this.get('slider');
+  willDestroyElement() {
+    this.teardown();
+  },
 
+  teardown() {
+    let { slider } = this;
+
     slider.off('change');
@@ -140,10 +155,10 @@ slider.off('slide');
     slider.destroy();
-  }),
+  },
 
-  setVal: observer('start', function() {
-    let slider = this.get('slider');
+  setValue: observer('start', function() {
+    let { slider } = this;
 
     if (slider) {
-      var val = this.get('start');
-      slider.set(val);
+      let value = this.get('start');
+      slider.set(value);
     }
@@ -153,3 +168,3 @@ }),
   // disabled can't be just `false` - this leads to an attribute of disabled="false"
-  disabledOrUndefined: Ember.computed('disabled', function() {
+  disabledOrUndefined: computed('disabled', function() {
     if (this.get('disabled')) {
@@ -159,3 +174,2 @@ return true;
   }),
-
   /**
@@ -166,3 +180,3 @@ * Perform a naive check to see if the deprecated action name exists in our
   sendDeprecatedAction(action, value) {
-    var actionName = this.get(`attrs.${action}`);
+    let actionName = this.get(`attrs.${action}`);
     if(!isEmpty(actionName)) {
@@ -169,0 +183,0 @@ Ember.Logger.warn(`DEPRECATION (ember-cli-nouislider): "${action}" action is deprecated in favor of "on-${action}". Support for "${action}" will be dropped in 1.0`);

app/components/range-slider.js

@@ -1,3 +0,1 @@
-import RangeSlider from 'ember-cli-nouislider/components/range-slider';
-
-export default RangeSlider;
+export { default } from 'ember-cli-nouislider/components/range-slider';

CHANGELOG.md

 ## master
 
+## 1.0.0-rc.1 2018-04-14
+
+* Upgrade to Ember 3.0 (#53 - @tchak & #59 - @tchak)
+* Bump to nouislider 11.0 (#53 - @tchak & #59 - @tchak)
+* Move broccoli-funnel & broccoli-merge-trees to dependencies (from devDependencies)
+
 ## 0.14.1 2017-10-08
@@ -4,0 +10,0 @@

config/environment.js

@@ -1,2 +0,1 @@
-/* eslint-env node */
 'use strict';
@@ -3,0 +2,0 @@

index.js

@@ -1,3 +0,4 @@
-/* jshint node: true */
+/* eslint-env node */
 'use strict';
+
 var path = require('path');
@@ -23,3 +24,3 @@ var Funnel = require('broccoli-funnel');
     var nouisliderTree = new Funnel(path.dirname(require.resolve('nouislider/distribute/nouislider.js')), {
-      files: ['nouislider.js', 'nouislider.min.css'],
+      files: ['nouislider.js', 'nouislider.min.css']
     });
@@ -26,0 +27,0 @@

LICENSE.md

 The MIT License (MIT)
 
-Copyright (c) 2016
+Copyright (c) 2018
 
@@ -5,0 +5,0 @@ Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

package.json

 {
   "name": "ember-cli-nouislider",
-  "version": "0.14.1",
+  "version": "1.0.0-rc.1",
   "description": "Ember range-slider component powered by nouislider",
@@ -14,32 +14,38 @@ "license": "MIT",
     "build": "ember build",
-    "start": "ember server",
+    "lint:js": "eslint ./*.js addon addon-test-support app config lib server test-support tests",
+    "start": "ember serve",
     "test": "ember try:each"
   },
   "dependencies": {
-    "ember-cli-babel": "^6.3.0",
+    "broccoli-funnel": "^2.0.1",
+    "broccoli-merge-trees": "^2.0.0",
+    "ember-cli-babel": "^6.6.0",
     "ember-cli-htmlbars": "^2.0.1",
-    "nouislider": "^10.1.0"
+    "nouislider": "^11.0.3"
   },
   "devDependencies": {
     "broccoli-asset-rev": "^2.4.5",
-    "broccoli-funnel": "^2.0.1",
-    "broccoli-merge-trees": "^2.0.0",
     "ember-ajax": "^3.0.0",
-    "ember-cli": "~2.15.1",
+    "ember-cli": "~3.0.4",
     "ember-cli-dependency-checker": "^2.0.0",
-    "ember-cli-eslint": "^4.0.0",
+    "ember-cli-eslint": "^4.2.1",
     "ember-cli-htmlbars-inline-precompile": "^1.0.0",
     "ember-cli-inject-live-reload": "^1.4.1",
-    "ember-cli-qunit": "^4.0.0",
+    "ember-cli-qunit": "^4.1.1",
     "ember-cli-sass": "^7.0.0",
-    "ember-cli-shims": "^1.1.0",
+    "ember-cli-shims": "^1.2.0",
     "ember-cli-sri": "^2.1.0",
-    "ember-cli-uglify": "^1.2.0",
+    "ember-cli-uglify": "^2.0.0",
     "ember-disable-prototype-extensions": "^1.1.2",
     "ember-export-application-global": "^2.0.0",
     "ember-load-initializers": "^1.0.0",
+    "ember-maybe-import-regenerator": "^0.1.6",
     "ember-resolver": "^4.0.0",
-    "ember-source": "~2.15.0",
-    "ember-welcome-page": "^3.0.0",
-    "loader.js": "^4.2.3"
+    "ember-source": "~3.0.0",
+    "ember-source-channel-url": "^1.0.1",
+    "ember-try": "^0.2.23",
+    "eslint-plugin-ember": "^5.0.0",
+    "eslint-plugin-node": "^5.2.1",
+    "loader.js": "^4.2.3",
+    "qunit-dom": "^0.5.0"
   },
@@ -46,0 +52,0 @@ "keywords": [

README.md

@@ -7,2 +7,3 @@ # ember-cli-nouislider
 [![Ember Observer Score](http://emberobserver.com/badges/ember-cli-nouislider.svg)](http://emberobserver.com/addons/ember-cli-nouislider)
+[![Open Source Helpers](https://www.codetriage.com/kennethkalmer/ember-cli-nouislider/badges/users.svg)](https://www.codetriage.com/kennethkalmer/ember-cli-nouislider)
 
@@ -51,3 +52,3 @@ This ember-cli addon provides you with a range-slider component, based on
 ```handlebars
-{{range-slider start=someValue on-change="changedAction"}}
+{{range-slider start=someValue on-change=(action "changedAction")}}
 ```
@@ -59,5 +60,6 @@
 // app/routes/my-route.js
-import Ember from 'ember';
+import Controller from '@ember/controller';
+import { debug } from '@ember/debug';
 
-export default Ember.Route.extend({
+export default Controller.extend({
   // ...
@@ -67,3 +69,3 @@ actions: {
     changedAction: function(value) {
-      Ember.debug( "New slider value: %@".fmt( value ) );
+      debug( `New slider value: ${value}`);
     }
@@ -93,19 +95,25 @@ }
 * `cd ember-cli-nouislider`
-* `npm install`
+* `yarn install`
 
-## Running
+### Linting
 
-* `ember serve`
-* Visit your app at [http://localhost:4200](http://localhost:4200).
+* `npm run lint:js`
+* `npm run lint:js -- --fix`
 
-## Running Tests
+### Running tests
 
-* `npm test` (Runs `ember try:each` to test your addon against multiple Ember versions)
-* `ember test`
-* `ember test --server`
+* `ember test` – Runs the test suite on the current Ember version
+* `ember test --server` – Runs the test suite in "watch mode"
+* `npm test` – Runs `ember try:each` to test your addon against multiple Ember versions
 
-## Building
+### Running the dummy application
 
-* `ember build`
+* `ember serve`
+* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
 
 For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
+
+License
+------------------------------------------------------------------------------
+
+This project is licensed under the [MIT License](LICENSE.md).

No alert changes

Improved metrics

Total package byte prevSize

262946

increased by881.91%

Number of package files

15

increased by15.38%

Lines of code

360

increased by3.45%

Number of lines in readme file

115

increased by7.48%

Worsened metrics

Dependency count

5

increased by66.67%

Dev dependency count

24

increased by14.29%

Dependency changes

• + Addedbroccoli-funnel@^2.0.1

• + Addedbroccoli-merge-trees@^2.0.0

• + Addedelectron-to-chromium@1.4.768(transitive)

• + Addednouislider@11.1.0(transitive)

• - Removednouislider@10.1.0(transitive)

• Updatedember-cli-babel@^6.6.0

• Updatednouislider@^11.0.3