ember-m3 - npm Package Compare versions

Comparing version 3.0.1 to 3.0.2

CHANGELOG.md

@@ -0,5 +1,22 @@
+## v3.0.2 (2020-08-20)
+
+#### :rocket: Enhancement
+
+- [#837](https://github.com/hjdivad/ember-m3/pull/837) Avoid checking project dependencies more than once per project ([@hjdivad](https://github.com/hjdivad))
+
+#### Committers: 2
+
+- David J. Hamilton ([@hjdivad](https://github.com/hjdivad))
+- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
+
 ## v3.0.1 (2020-08-20)
 
+#### :bug: Bug Fix
+
 Avoid `checker.check` when project depends on ember-data for a performance gain
 
+#### Committers: 1
+
+- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
+
 ## v3.0.0 (2020-06-09)
@@ -6,0 +23,0 @@

index.js

 /* eslint-env node */
 'use strict';
-const semver = require('semver');
+
 const Funnel = require('broccoli-funnel');
@@ -9,5 +9,11 @@ const getDebugMacros = require('./src/debug-macros').debugMacros;
 
-function assertValidEmberData(addon) {
-  let checker = VersionChecker.forProject(addon.project);
+const CHECKED_PROJECT = new WeakSet();
 
+function assertValidEmberData(project) {
+  if (CHECKED_PROJECT.has(project)) {
+    return;
+  }
+
+  let checker = VersionChecker.forProject(project);
+
   // full ember-data brings store and model starting in 3.16
@@ -25,2 +31,4 @@ // so we do not need to check for full ember-data, just the specific packages
   );
+
+  CHECKED_PROJECT.add(project);
 }
@@ -34,11 +42,5 @@
 
+    assertValidEmberData(this.project);
+
     this.configureBabelOptions();
-
-    let emberDataMetaPackage = this.project.addons.find((a) => a.name === 'ember-data');
-
-    if (emberDataMetaPackage === undefined) {
-      assertValidEmberData(this);
-    } else if (semver.lt(emberDataMetaPackage.pkg.version, '3.16.0')) {
-      throw new Error('[ember-m3] requires ember-data@3.16.0 or higher.');
-    }
   },
@@ -45,0 +47,0 @@

package.json

 {
   "name": "ember-m3",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Alternative to @ember-data/model in which attributes and relationships are derived from API Payloads",
@@ -5,0 +5,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

191321

increased by0.14%

Worsened metrics

Lines of code

4228

decreased by-0.02%

No dependency changes