eslint-plugin-jasmine - npm Package Compare versions

Comparing version 2.3.2 to 2.4.0

docs/rules/no-unsafe-spy.md

@@ -8,2 +8,4 @@ # Enforce spies to be defined in before/after/it blocks
 
+This rule checks for the following methods: `spyOn`, `jasmine.createSpy()`, `jasmine.createSpyObj()`.
+
 ## Rule details
@@ -10,0 +12,0 @@

lib/rules/no-unsafe-spy.js

@@ -27,3 +27,6 @@ 'use strict'
           (node.callee.object && node.callee.object.name === 'jasmine') &&
-          (node.callee.property && node.callee.property.name === 'createSpy')
+          (
+            (node.callee.property && node.callee.property.name === 'createSpy') ||
+            (node.callee.property && node.callee.property.name === 'createSpyObj')
+          )
         )
@@ -30,0 +33,0 @@ ) { return }

package.json

@@ -54,3 +54,3 @@ {
   },
-  "version": "2.3.2"
+  "version": "2.4.0"
 }

test/rules/no-unsafe-spy.js

@@ -45,2 +45,10 @@ 'use strict'
       '})'
+    ]),
+    linesToCode([
+      'beforeEach(function () {',
+      '  var tape = jasmine.createSpyObj("tape", ["play", "pause"]);',
+      '   it(function () {',
+      '    expect(tape.play).toBeDefined();',
+      '   })',
+      '})'
     ])
@@ -80,4 +88,17 @@ ],
       ]
+    },
+    {
+      code: linesToCode([
+        'describe(function () {',
+        '  var tape = jasmine.createSpyObj("tape", ["play", "pause"]);',
+        '   it(function () {',
+        '    expect(tape.play).toBeDefined();',
+        '   })',
+        '})'
+      ]),
+      errors: [
+        {message: 'Spy declared outside of before/after/it block'}
+      ]
     }
   ]
 })

No alert changes

Improved metrics

Total package byte prevSize

148192

increased by0.54%

Lines of code

1667

increased by1.46%

No dependency changes