eslint-plugin-lodash-fp - npm Package Compare versions

Comparing version 1.1.2 to 1.1.3

CHANGELOG.md

@@ -9,5 +9,9 @@ # Change Log
 
+## [1.1.3] - 2016-05-02
+### Fixed
+- Fix false positives being returned for any Lodash method used that did not match [`consistent-compose`] method name option ([#14], thanks [@kavington])
+
 ## [1.1.2] - 2016-05-01
 ### Fixed
-- Crash in `no-submodule-destructuring` when doing `var {foo} = bar;` ([#13], thanks [@kavington])
+- Crash in [`no-submodule-destructuring`] when doing `var {foo} = bar;` ([#13], thanks [@kavington])
 - Typo in recommended configuration ([#13], thanks [@kavington])
@@ -75,9 +79,10 @@
 [`prefer-flat-map`]: ./docs/rules/prefer-flat-map.md
+[`prefer-get`]: ./docs/rules/prefer-get.md
 [`prefer-identity`]: ./docs/rules/prefer-identity.md
-[`prefer-get`]: ./docs/rules/prefer-get.md
 
 [`eslint-plugin-lodash`]: https://github.com/wix/eslint-plugin-lodash
 
+[#14]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/14
+[#13]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/13
 [#11]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/11
-[#13]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/13
 
@@ -88,3 +93,4 @@ [@jfmengels]: https://github.com/jfmengels
 
-[Unreleased]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.2...master
+[Unreleased]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.3...master
+[1.1.3]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.2...v1.1.3
 [1.1.2]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.1...v1.1.2
@@ -91,0 +97,0 @@ [1.1.1]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.0...v1.1.1

package.json

 {
   "name": "eslint-plugin-lodash-fp",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "ESLint rules for lodash/fp",
@@ -5,0 +5,0 @@ "license": "MIT",

rules/consistent-compose.js

 'use strict';
 
+var _ = require('lodash/fp');
 var enhance = require('./core/enhance');
 
+var knownComposeMethods = ['flow', 'flowRight', 'compose', 'pipe'];
+var isKnownComposeMethod = _.includes(_, knownComposeMethods);
+
 module.exports = function (context) {
@@ -15,3 +19,3 @@ var info = enhance();
       var name = info.helpers.isMethodCall(node);
-      if (name !== false && name !== composeMethod) {
+      if (isKnownComposeMethod(name) && name !== composeMethod) {
         context.report(node, 'Forbidden use of `' + name + '`. Use `' + composeMethod + '` instead');
@@ -25,3 +29,3 @@ }
   type: 'string',
-  enum: ['flow', 'flowRight', 'compose', 'pipe']
+  enum: knownComposeMethods
 }];

No alert changes

Improved metrics

Total package byte prevSize

47737

increased by1.05%

Lines of code

1122

increased by0.27%

No dependency changes