jfmengels

eslint-plugin-lodash-fp

All notable changes to this project will be documented in this file.

This project adheres to [Semantic Versioning](http://semver.org/).

This change log adheres to standards from [Keep a CHANGELOG](http://keepachangelog.com).

- Fixed incorrect errors for [`use-fp`] on package names starting with `lodash-` ([#41, thanks [@penny-five])

- Fixed crash in `no-extraneous-function-wrapping` when using `return` without an argument.

- Fixed false report in `no-extraneous-function-wrapping` when using the last argument twice in the arguments ([#38], thanks [@godu]).

- **Breaking**: Removed support for Node.js versions < v4.

- Fixed documentation for [`prefer-composition-grouping`].

- Added suggestion in [`prefer-composition-grouping`] to use [`_.overEvery`]/[`_.overSome`] to replace multiple [`_.filter`]/[`_.reject`].

- Added an exception for [`_.bindAll`] in [`no-unused-result`] ([#36], thanks [@dfadler]).

- Fixed [`prefer-composition-grouping`]'s error message ([#30], thanks [@gunar]).

- Fixed [`no-extraneous-iteratee-args`]'s error message.

- [`prefer-composition-grouping`] now handles aliases, and can report multiple errors in the same flow construct.

- [`no-for-each`] now also reports uses of [`_.forIn`] and [`_.forOwn`].

- Added [`no-extraneous-iteratee-args`] rule

- [`no-extraneous-args`] now also handles aliases.

- Fixed crash in [`no-extraneous-function-wrapping`].

- [`no-extraneous-args`] now recommends an alternative whenever possible, and tells when to use an array for method that used rest args.

- Fix false positives being returned for any Lodash method used that did not match [`consistent-compose`] method name option ([#14], thanks [@kavington])

- Crash in [`no-submodule-destructuring`] when doing `const {foo} = bar;` ([#13], thanks [@kavington])

- Typo in recommended configuration ([#13], thanks [@kavington])

- Problems with `npm` while publishing, added missing files.

- Fix typo preventing the package from loading ([#11], thanks [@izaakschroeder])

- Added [`prefer-composition-grouping`] rule

- Added [`no-submodule-destructuring`] rule

- Added [`prefer-constant`] rule from [`eslint-plugin-lodash`]

- Added [`prefer-get`] rule from [`eslint-plugin-lodash`]

- Added [`no-extraneous-function-wrapping`] rule

[`consistent-compose`]: ./docs/rules/consistent-compose.md

[`consistent-name`]: ./docs/rules/consistent-name.md

[`no-argumentless-calls`]: ./docs/rules/no-argumentless-calls.md

[`no-extraneous-args`]: ./docs/rules/no-extraneous-args.md

[`no-extraneous-function-wrapping`]: ./docs/rules/no-extraneous-function-wrapping.md

[`no-extraneous-iteratee-args`]: ./docs/rules/no-extraneous-iteratee-args.md

[`no-for-each`]: ./docs/rules/no-for-each.md

[`no-partial-of-curried`]: ./docs/rules/no-partial-of-curried.md

[`no-single-composition`]: ./docs/rules/no-single-composition.md

[`no-submodule-destructuring`]: ./docs/rules/no-submodule-destructuring.md

[`no-unused-result`]: ./docs/rules/no-unused-result.md

[`prefer-compact`]: ./docs/rules/prefer-compact.md

[`prefer-composition-grouping`]: ./docs/rules/prefer-composition-grouping.md

[`prefer-constant`]: ./docs/rules/prefer-constant.md

[`prefer-flat-map`]: ./docs/rules/prefer-flat-map.md

[`prefer-get`]: ./docs/rules/prefer-get.md

[`prefer-identity`]: ./docs/rules/prefer-identity.md

[`preferred-alias`]: ./docs/rules/preferred-alias.md

[`_.bindAll`]: https://lodash.com/docs#filter

[`_.filter`]: https://lodash.com/docs#filter

[`_.forIn`]: https://lodash.com/docs#forIn

[`_.forOwn`]: https://lodash.com/docs#forOwn

[`_.overEvery`]: https://lodash.com/docs#overEvery

[`_.overSome`]: https://lodash.com/docs#overSome

[`_.reject`]: https://lodash.com/docs#reject

[`eslint`]: https://github.com/eslint/eslint

[`eslint-plugin-lodash`]: https://github.com/wix/eslint-plugin-lodash

[#36]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/36

[#14]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/14

[#11]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/11

[#41]: https://github.com/jfmengels/eslint-plugin-lodash-fp/issues/41

[#38]: https://github.com/jfmengels/eslint-plugin-lodash-fp/issues/38

[#30]: https://github.com/jfmengels/eslint-plugin-lodash-fp/issues/30

[#13]: https://github.com/jfmengels/eslint-plugin-lodash-fp/pull/13

[@izaakschroeder]: https://github.com/izaakschroeder

[@jfmengels]: https://github.com/jfmengels

[@kavington]: https://github.com/kavington

[@penny-five]: https://github.com/penny-five

[Unreleased]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v2.0.1...master

[2.0.1]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v2.0.0...v2.0.1

[2.0.0]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.3.0...v2.0.0

[1.3.0]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.2.0...v1.3.0

[1.2.0]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.2...v1.2.0

[1.1.3]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.2...v1.1.3

[1.1.2]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.1...v1.1.2

[1.1.1]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.1.0...v1.1.1

[1.1.0]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.0.2...v1.1.0

[1.0.2]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.0.1...v1.0.2

[1.0.1]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v1.0.0...v1.0.1

[1.0.0]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v0.1.0...v1.0.0

[0.1.0]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v0.0.3...v0.1.0

[0.0.3]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v0.0.2...v0.0.3

[0.0.2]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v0.0.1...v0.0.2

  "description": "ESLint rules for lodash/fp",

  "repository": "jfmengels/eslint-plugin-lodash-fp",

    "update-md": "inject-in-tag ./rule-description.js readme.md"

# eslint-plugin-lodash-fp [![Build Status](https://travis-ci.org/jfmengels/eslint-plugin-lodash-fp.svg?branch=master)](https://travis-ci.org/jfmengels/eslint-plugin-lodash-fp)

$ npm install --save-dev eslint eslint-plugin-lodash-fp

      "lodash-fp/consistent-compose": "off",

      "lodash-fp/no-argumentless-calls": "error",

      "lodash-fp/no-extraneous-args": "error",

      "lodash-fp/no-extraneous-function-wrapping": "error",

      "lodash-fp/no-extraneous-iteratee-args": "error",

      "lodash-fp/no-partial-of-curried": "error",

      "lodash-fp/no-single-composition": "error",

      "lodash-fp/no-submodule-destructuring": "error",

      "lodash-fp/no-unused-result": "error",

      "lodash-fp/prefer-compact": "error",

      "lodash-fp/prefer-composition-grouping": "error",

      "lodash-fp/prefer-flat-map": "error",

      "lodash-fp/preferred-alias": "off",

- [consistent-compose](docs/rules/consistent-compose.md) - Enforce a consistent composition method.

- [consistent-name](docs/rules/consistent-name.md) - Enforce a consistent name for Lodash.

- [no-argumentless-calls](docs/rules/no-argumentless-calls.md) - Forbid argument-less calls of Lodash methods.

- [no-chain](docs/rules/no-chain.md) - Forbid the use of [`_.chain`](https://lodash.com/docs#chain)

- [no-extraneous-args](docs/rules/no-extraneous-args.md) - No extraneous arguments to methods with a fixed arity.

- [no-extraneous-function-wrapping](docs/rules/no-extraneous-function-wrapping.md) - Avoid unnecessary function wrapping.

- [no-extraneous-iteratee-args](docs/rules/no-extraneous-iteratee-args.md) - No extraneous parameters in iteratees.

- [no-for-each](docs/rules/no-for-each.md) -  Forbid the use of [`_.forEach`](https://lodash.com/docs#forEach)

- [no-partial-of-curried](docs/rules/no-partial-of-curried.md) - No use of [`_.partial`](https://lodash.com/docs#partial) on curried Lodash methods.

- [no-single-composition](docs/rules/no-single-composition.md) - Enforce at least two methods arguments for composition methods.

- [no-submodule-destructuring](docs/rules/no-submodule-destructuring.md) - Forbid destructuring of Lodash submodules.

- [no-unused-result](docs/rules/no-unused-result.md) - Enforce that the result of a Lodash method call gets used.

- [prefer-compact](docs/rules/prefer-compact.md) - Prefer [`_.compact`](https://lodash.com/docs#compact) over [`_.filter`](https://lodash.com/docs#filter) with identity function.

- [prefer-composition-grouping](docs/rules/prefer-composition-grouping.md) - Prefer grouping similar methods in composition methods.

- [prefer-constant](docs/rules/prefer-constant.md) - Prefer [`_.constant`](https://lodash.com/docs#constant) over functions returning literals.

- [prefer-flat-map](docs/rules/prefer-flat-map.md) - Prefer [`_.flatMap`](https://lodash.com/docs#flatMap) over consecutive [`_.map`](https://lodash.com/docs#map) and [`_.flatten`](https://lodash.com/docs#flatten).

- [prefer-get](docs/rules/prefer-get.md) - Prefer [`_.get`](https://lodash.com/docs#get) over multiple `&&`.

- [prefer-identity](docs/rules/prefer-identity.md) - Prefer [`_.identity`](https://lodash.com/docs#identity) over functions returning their argument.

- [preferred-alias](docs/rules/preferred-alias.md) - Limit the use of aliases.

- [use-fp](docs/rules/use-fp.md) - Use lodash/fp instead of Lodash.

This plugin exports a [`recommended` configuration](index.js) that enforces good practices.

To enable this configuration, use the `extends` property in your `package.json`.

		"extends": "plugin:lodash-fp/recommended"

See [ESLint documentation](http://eslint.org/docs/user-guide/configuring#extending-configuration-files) for more information about extending configuration files.

const enhance = require('./core/enhance');

const isStaticRequire = require('./core/static-require');

const lodashRegex = /^lodash($|\/(?!fp))/;

function reportIfLodashButNotFp(context, node, name) {

  if (name && name.indexOf('lodash') === 0 && name.indexOf('lodash/fp') === -1) {

    context.report(node, 'Unallowed import of `lodash`. Use `lodash/fp` instead');

      reportIfLodashButNotFp(context, node, node.source.value);

        reportIfLodashButNotFp(context, node, node.arguments[0].value);

      description: 'Use lodash/fp instead of Lodash.',

		@@ -7,3 +7,4 @@ # Change Log
		## [Unreleased]
		- (none)
		### Fixed
		- Fixed incorrect errors for [`use-fp`] on package names starting with `lodash-` ([#41, thanks [@penny-five])

		@@ -101,3 +102,3 @@ ## [2.0.1] - 2016-08-24
		- Added [`no-chain`] rule
		- Added [`no-fp`] rule
		- Added [`use-fp`] rule

		@@ -112,3 +113,2 @@ [`consistent-compose`]: ./docs/rules/consistent-compose.md
		[`no-for-each`]: ./docs/rules/no-for-each.md
		[`no-fp`]: ./docs/rules/no-fp.md
		[`no-partial-of-curried`]: ./docs/rules/no-partial-of-curried.md
		@@ -125,2 +125,3 @@ [`no-single-composition`]: ./docs/rules/no-single-composition.md
		[`preferred-alias`]: ./docs/rules/preferred-alias.md
		[`use-fp`]: ./docs/rules/use-fp.md

		@@ -142,2 +143,3 @@ [`_.bindAll`]: https://lodash.com/docs#filter

		[#41]: https://github.com/jfmengels/eslint-plugin-lodash-fp/issues/41
		[#38]: https://github.com/jfmengels/eslint-plugin-lodash-fp/issues/38
		@@ -153,2 +155,3 @@ [#30]: https://github.com/jfmengels/eslint-plugin-lodash-fp/issues/30
		[@kavington]: https://github.com/kavington
		[@penny-five]: https://github.com/penny-five

		@@ -155,0 +158,0 @@ [Unreleased]: https://github.com/jfmengels/eslint-plugin-lodash-fp/compare/v2.0.1...master

		{
		"name": "eslint-plugin-lodash-fp",
		"version": "2.0.1",
		"version": "2.1.0",
		"description": "ESLint rules for lodash/fp",
		@@ -5,0 +5,0 @@ "license": "MIT",

		@@ -95,2 +95,3 @@ # eslint-plugin-lodash-fp [![Build Status](https://travis-ci.org/jfmengels/eslint-plugin-lodash-fp.svg?branch=master)](https://travis-ci.org/jfmengels/eslint-plugin-lodash-fp)
		- [use-fp](docs/rules/use-fp.md) - Use lodash/fp instead of Lodash.

		<!-- RULES:END -->
		@@ -97,0 +98,0 @@

		@@ -6,4 +6,6 @@ 'use strict';

		const lodashRegex = /^lodash($\|\/(?!fp))/;

		function reportIfLodashButNotFp(context, node, name) {
		if (name && name.indexOf('lodash') === 0 && name.indexOf('lodash/fp') === -1) {
		if (lodashRegex.test(name)) {
		context.report(node, 'Unallowed import of `lodash`. Use `lodash/fp` instead');
		@@ -10,0 +12,0 @@ }

Improved metrics