eventsource - npm Package Compare versions

Comparing version 0.1.5 to 0.1.6

History.md

@@ -0,1 +1,5 @@
+# [0.1.6](https://github.com/aslakhellesoy/eventsource-node/compare/v0.1.5...v0.1.6)
+
+* Ignore headers without a value. ([#41](https://github.com/aslakhellesoy/eventsource-node/issues/41), [#43](https://github.com/aslakhellesoy/eventsource-node/pull/43) Adriano Raiano)
+
 # [0.1.5](https://github.com/aslakhellesoy/eventsource-node/compare/v0.1.4...v0.1.5)
@@ -2,0 +6,0 @@

lib/eventsource.js

@@ -80,3 +80,5 @@ var original = require('original')
         var header = eventSourceInitDict.headers[i];
-        options.headers[i] = header;
+        if (header) {
+          options.headers[i] = header;
+        }
       }
@@ -101,4 +103,2 @@ }
 
-//      if (res.statusCode == 204) return self.close();
-
       if (res.statusCode !== 200) {
@@ -105,0 +105,0 @@ _emit('error', new Event('error', {status: res.statusCode}));

package.json

 {
   "name": "eventsource",
-  "version": "0.1.5",
+  "version": "0.1.6",
   "description": "W3C compliant EventSource client for Node.js",
@@ -5,0 +5,0 @@ "keywords": [

test/eventsource_test.js

@@ -353,3 +353,3 @@ var EventSource = require('../lib/eventsource')
 
-  it('sets headers by user', function (done) {
+  it('sets request headers', function (done) {
     var server = createServer(function (err, server) {
@@ -374,2 +374,29 @@ if (err) return done(err);
 
+  it("does not set request headers that don't have a value", function (done) {
+    var server = createServer(function (err, server) {
+      if (err) return done(err);
+
+      server.on('request', function (req) {
+        assert.equal(req.headers['user-agent'], 'test');
+        assert.equal(req.headers['cookie'], 'test=test');
+        assert.equal(req.headers['last-event-id'], '99');
+        assert.equal(req.headers['X-Something'], undefined);
+        server.close(done);
+      });
+
+      var headers = {
+        'User-Agent': 'test',
+        'Cookie': 'test=test',
+        'Last-Event-ID': '99',
+        'X-Something': null
+      };
+
+      assert.doesNotThrow(
+        function() {
+          new EventSource(server.url, {headers: headers});
+        }
+      );
+    });
+  });
+
   [301, 307].forEach(function (status) {
@@ -376,0 +403,0 @@ it('follows http ' + status + ' redirect', function (done) {

No alert changes

Improved metrics

Total package byte prevSize

45615

increased by2.3%

Lines of code

994

increased by2.47%

No dependency changes