faker - npm Package Compare versions

Comparing version 1.0.1 to 1.1.0

BUILD/BUILD.js

@@ -62,12 +62,19 @@ #!/usr/bin/env node
 // if we are running in a CommonJS env, export everything out
-code +=["\nif (typeof define == 'function'){",
-"   define(function(){",
-"		return faker;",
-"   });",
+code += ["\n",
+"if (typeof exports === 'object') {",
+"  // CommonJS",
+"  module.exports = faker;",
 "}",
-"else if(typeof module !== 'undefined' && module.exports) {",
-"	module.exports = faker;",
+"else if (typeof define === 'function' && define.amd) {",
+"  // AMD",
+"  define(function () {",
+"    return faker;",
+"  });",
 "}",
 "else {",
-"	window.faker = faker;",
+"  // Global Variables",
+"if (!window && this){ ",
+"		window = this;",
+"	}",
+"  window.faker = faker;",
 "}",
@@ -74,0 +81,0 @@ "",

lib/name.js

@@ -25,8 +25,8 @@ var faker = require('../index');
         case 0:
-            return faker.random.name_prefix() + " " + this.firstName() + " " + this.lastName();
+            return faker.random.name_prefix() + " " + _name.firstName() + " " + _name.lastName();
         case 1:
-            return this.firstName() + " " + this.lastName() + " " + faker.random.name_suffix();
+            return _name.firstName() + " " + _name.lastName() + " " + faker.random.name_suffix();
         }
 
-        return this.firstName() + " " + this.lastName();
+        return _name.firstName() + " " + _name.lastName();
     }
@@ -33,0 +33,0 @@ };

lib/random.js

 var definitions = require('./definitions');
 var random = {
     // returns a single random number based on a max number or range
-    number: function (range) {
-        if(Array.isArray(range)) {
-          var min = range[0];
-          var max = range[1];
-          return Math.floor((Math.random() * max) + min);
+    number: function (min, max) {
+        if (max === undefined) {
+            max = min;
+            min = 0;
         }
-        return Math.floor(Math.random() * range);
+        return Math.floor((Math.random() * max) + min);
     },
@@ -12,0 +11,0 @@

package.json

 {
     "name": "faker",
     "description": "Generate massive amounts of fake contextual data",
-    "version": "1.0.1",
+    "version": "1.1.0",
     "contributors": [
@@ -6,0 +6,0 @@ "Marak Squires <[e-mail]>",

test/random.unit.js

@@ -14,6 +14,5 @@ if (typeof module !== 'undefined') {
     it("returns a random number between a range", function() {
-      var range = [1, 10];
-      var min = range[0];
-      var max = range[1]
-      var randomNumber = faker.random.number(range);
+      var min = 1;
+      var max = 10;
+      var randomNumber = faker.random.number(1, 10);
       assert.ok( randomNumber >= min);
@@ -20,0 +19,0 @@ assert.ok( randomNumber <= max);

No alert changes

Improved metrics

Total package byte prevSize

1049559

increased by0.05%

Number of package files

58

increased by1.75%

Lines of code

13681

increased by0.1%

No dependency changes