fd-slicer - npm Package Compare versions

Comparing version 0.3.0 to 0.3.1

CHANGELOG.md

@@ -0,1 +1,5 @@
+### 0.3.1
+
+ * write stream: fix end option behavior
+
 ### 0.3.0
@@ -2,0 +6,0 @@

index.js

@@ -148,3 +148,3 @@ var fs = require('fs');
 
-  if (self.bytesWritten + buffer.length > self.endOffset) {
+  if (self.pos + buffer.length > self.endOffset) {
     var err = new Error("maximum file length exceeded");
@@ -151,0 +151,0 @@ err.code = 'ETOOBIG';

package.json

 {
   "name": "fd-slicer",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "safely create multiple ReadStream or WriteStream objects from the same file descriptor",
@@ -5,0 +5,0 @@ "main": "index.js",

test/test.js

@@ -194,2 +194,15 @@ var FdSlicer = require('../');
 
+  it("write stream start and end work together", function(done) {
+    fs.open(testOutBlobFile, 'w', function(err, fd) {
+      if (err) return done(err);
+      var fdSlicer = new FdSlicer(fd, {autoClose: true});
+      var ws = fdSlicer.createWriteStream({start: 1, end: 1000});
+      ws.on('error', function(err) {
+        assert.strictEqual(err.code, 'ETOOBIG');
+        done();
+      });
+      ws.end(new Buffer(1000));
+    });
+  });
+
   it("write stream emits progress events", function(done) {
@@ -196,0 +209,0 @@ fs.open(testOutBlobFile, 'w', function(err, fd) {

No alert changes

Improved metrics

Total package byte prevSize

19586

increased by2.51%

Lines of code

366

increased by3.39%

No dependency changes